From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH]: Add bambam
Date: Wed, 31 Aug 2016 12:21:16 -0500
Message-ID: <20160831122116.0f7e5581@openmailbox.org>
References: <20160830204313.GA25061@macbook42.flashner.co.il>
	<87k2exe7xy.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bf9Cm-0004ds-Nm
	for guix-devel@gnu.org; Wed, 31 Aug 2016 13:21:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bf9Ci-0003ee-Eu
	for guix-devel@gnu.org; Wed, 31 Aug 2016 13:21:39 -0400
Received: from smtp9.openmailbox.org ([62.4.1.43]:57898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bf9Ci-0003eT-55
	for guix-devel@gnu.org; Wed, 31 Aug 2016 13:21:36 -0400
In-Reply-To: <87k2exe7xy.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

On Wed, 31 Aug 2016 10:03:37 +0300
Alex Kost <alezost@gmail.com> wrote:

> Only a couple of small things :-)
> 
> [...]
> > +(define-public bambam
> > +  (package
> > +    (name "bambam")
> > +    (version "0.5")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (string-append "https://github.com/porridge/bambam/archive/"
> > +                            version ".tar.gz"))
> > +        (file-name (string-append name "-" version ".tar.gz"))
> > +        (sha256
> > +         (base32
> > +          "10w110mjdwbvddzihh9rganvvjr5jfiz8cs9n7w12zndwwcc3ria"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:python ,python-2
> > +       #:tests? #f ; no tests
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (delete 'build)
> > +         (add-before 'install 'patch-data-dir-location
> > +           (lambda _
> > +             (substitute* "bambam.py"
> > +                          (("'data'")
> > +                           "'../share/bambam/data'"))  
> 
> This is an unusual indentation, I would write:
> 
>              (substitute* "bambam.py"
>                (("'data'") "'../share/bambam/data'"))
> 
> 
> > +             #t))
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out   (assoc-ref outputs "out"))
> > +                    (bin   (string-append out "/bin"))
> > +                    (share (string-append out "/share")))
> > +               (mkdir-p bin)
> > +               (copy-file "bambam.py" (string-append bin "/bambam"))
> > +               (install-file "bambam.6" (string-append share "/man/man6"))
> > +               (copy-recursively "data" (string-append share "/bambam/data")))
> > +             #t))
> > +         (add-after 'install 'wrap-binary
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out (assoc-ref outputs "out"))
> > +                    (bin (string-append out "/bin/bambam")))
> > +               (wrap-program bin
> > +                 `("PYTHONPATH" ":" prefix (,(getenv "PYTHONPATH")))))
> > +             #t)))))
> > +    (inputs
> > +     `(("python-pygame" ,python-pygame)))
> > +    (home-page "https://github.com/porridge/bambam")
> > +    (synopsis "keyboard mashing and doodling game for babies")  
>                   Keyboard
> "guix lint" reported it should begin with an upper-case letter.
> 
> > +    (description "Bambam is a simple baby keyboard (and gamepad) masher
> > +application that locks the keyboard and mouse and instead displays bright
> > +colors, pictures, and sounds.")
> > +    (license license:gpl3+)))  
> 

Since I accidentaly pushed this patch with another batch, I went ahead
and made these changes.  I also removed the wrap-binary phase, which is
handled by python-build-system.  Pushed in
46a0622481c398bd9337522e93f6f9082d2b9015.

Thanks,
`~Eric