From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/3] gnu: Add gnuastro Date: Tue, 30 Aug 2016 16:45:23 -0400 Message-ID: <20160830204523.GA10937@jasmine> References: <1472584872-19300-1-git-send-email-jmd@gnu.org> <1472584872-19300-3-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bepuf-0008Ud-H7 for guix-devel@gnu.org; Tue, 30 Aug 2016 16:45:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bepub-0001Dy-BY for guix-devel@gnu.org; Tue, 30 Aug 2016 16:45:40 -0400 Content-Disposition: inline In-Reply-To: <1472584872-19300-3-git-send-email-jmd@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org On Tue, Aug 30, 2016 at 09:21:12PM +0200, John Darrington wrote: > * gnu/packages/astronomy.scm (gnuastro): New variable. > + (source > + (origin I would shift this one column to the right, and the rest of (source) accordingly. > + (method url-fetch) > + (uri (string-append "mirror://gnu/gnuastro/gnuastro-" > + version ".tar.gz")) The (uri) should be aligned with (method url-fetch). Otherwise LGTM.