From: Leo Famulari <leo@famulari.name>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add gnuastro
Date: Tue, 30 Aug 2016 16:45:23 -0400 [thread overview]
Message-ID: <20160830204523.GA10937@jasmine> (raw)
In-Reply-To: <1472584872-19300-3-git-send-email-jmd@gnu.org>
On Tue, Aug 30, 2016 at 09:21:12PM +0200, John Darrington wrote:
> * gnu/packages/astronomy.scm (gnuastro): New variable.
> + (source
> + (origin
I would shift this one column to the right, and the rest of (source)
accordingly.
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/gnuastro/gnuastro-"
> + version ".tar.gz"))
The (uri) should be aligned with (method url-fetch). Otherwise LGTM.
next prev parent reply other threads:[~2016-08-30 20:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 19:21 [PATCH 1/3] gnu: Add cfitsio John Darrington
2016-08-30 19:21 ` [PATCH 2/3] gnu: Add wcslib John Darrington
2016-08-30 20:47 ` Leo Famulari
2016-08-31 6:42 ` Alex Kost
2016-09-12 13:44 ` Alex Kost
2016-09-12 15:40 ` John Darrington
2016-09-13 8:10 ` Alex Kost
2016-09-13 12:44 ` John Darrington
2016-08-30 19:21 ` [PATCH 3/3] gnu: Add gnuastro John Darrington
2016-08-30 20:45 ` Leo Famulari [this message]
2016-08-31 6:47 ` Alex Kost
2016-08-30 20:47 ` [PATCH 1/3] gnu: Add cfitsio Leo Famulari
2016-08-31 6:45 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830204523.GA10937@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).