[PATCH 2/2] Feed2maildir: Add feed2maildir

[PATCH 2/2] Feed2maildir: Add feed2maildir

[Matthew Jordan]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]

Good Day,

This a patch to add feed2maildir.
Let me know if I need to change anything.


[-- Attachment #2: patch to add feed2maildir. --]
[-- Type: text/x-patch, Size: 1949 bytes --]

From 2bc27ff76ae53f9e7556d55a3dc2b4ffde6f72f7 Mon Sep 17 00:00:00 2001
From: "Matthew O'N.S Jordan" <matthewjordannm@gmail.com>
Date: Sun, 21 Aug 2016 11:47:17 -0400
Subject: [PATCH 2/2] gnu: Add feed2maildir

* gnu/packages/mail.scm (python-feed2maildir): New variable.
---
 gnu/packages/mail.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 49bf8f7..d37557c 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2016 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2016 Troy Sankey <sankeytms@gmail.com>
 ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1305,3 +1306,29 @@ Khard can also be used from within the email client @command{mutt}.")
   (description "Mail::SPF is the Sender Policy Framework implemented
 in Perl.")
   (license bsd-3)))
+
+(define-public python-feed2maildir
+  (package
+    (name "feed2maildir")
+    (version "0.3.5.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://pypi.python.org/packages/5f/e7/d6d7235f13aced7aaa08bbd0d5bb95c87f2945c29e290caa399a014eaeae/"
+             name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "18g3v99s6703wgc90cgrdz6i3viqk857liy05ndvfjsidnikym44"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f))
+    (inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-feedparser" ,python-feedparser)
+       ("python-dateutil" ,python-dateutil-2)))
+    (home-page "https://github.com/sulami/feed2maildir")
+    (synopsis "Convert feeds to maildirs")
+    (description "Convert feeds to maildirs")
+    (license
+     (non-copyleft "https://github.com/sulami/feed2maildir/blob/master/LICENSE"))))
-- 
2.9.0


[-- Attachment #3: Type: text/plain, Size: 28 bytes --]


Sincerely,

Matthew Jordan

Re: [PATCH 2/2] Feed2maildir: Add feed2maildir

[Leo Famulari]

On Sun, Aug 21, 2016 at 12:13:45PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 2/2] gnu: Add feed2maildir
> 
> * gnu/packages/mail.scm (python-feed2maildir): New variable.

Thanks!

I have the same feedback for this package as I did for
python-feedparser. Additional comments below.

> +    (arguments
> +     `(#:tests? #f))

When skipping tests, we must leave a code comment explaining why. It can
be as simple as "No test suite" if that's the case.

> +    (license
> +     (non-copyleft "https://github.com/sulami/feed2maildir/blob/master/LICENSE"))))

This is the ISC license.