From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/2] Feed2maildir: Add feed2maildir
Date: Tue, 30 Aug 2016 15:19:31 -0400
Message-ID: <20160830191931.GB7311@jasmine>
References: <87zio6f6bq.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1beoZV-00015k-4w
	for guix-devel@gnu.org; Tue, 30 Aug 2016 15:19:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1beoZP-0002Dq-Tv
	for guix-devel@gnu.org; Tue, 30 Aug 2016 15:19:44 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1beoZO-0002Cv-NS
	for guix-devel@gnu.org; Tue, 30 Aug 2016 15:19:39 -0400
Content-Disposition: inline
In-Reply-To: <87zio6f6bq.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Matthew Jordan <matthewjordannm@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

On Sun, Aug 21, 2016 at 12:13:45PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 2/2] gnu: Add feed2maildir
> 
> * gnu/packages/mail.scm (python-feed2maildir): New variable.

Thanks!

I have the same feedback for this package as I did for
python-feedparser. Additional comments below.

> +    (arguments
> +     `(#:tests? #f))

When skipping tests, we must leave a code comment explaining why. It can
be as simple as "No test suite" if that's the case.

> +    (license
> +     (non-copyleft "https://github.com/sulami/feed2maildir/blob/master/LICENSE"))))

This is the ISC license.