[PATCH 1/2] Feed2maildir: Add python-feedparser

[PATCH 1/2] Feed2maildir: Add python-feedparser

[Matthew Jordan]

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

Good Day,

This patch is to add python-feedparser.
Left me know if need to make any adjustments.


[-- Attachment #2: patch to add feedparser. --]
[-- Type: text/x-patch, Size: 1964 bytes --]

From 41357ed77b80d7d151b341eef509685b45266546 Mon Sep 17 00:00:00 2001
From: "Matthew O'N.S Jordan" <matthewjordannm@gmail.com>
Date: Sun, 21 Aug 2016 11:45:52 -0400
Subject: [PATCH 1/2] gnu: Add python-feedparser

* gnu/packages/python.scm (python-feedparser): New variable.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 15c957e..a8a9857 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2016 Troy Sankey <sankeytms@gmail.com>
 ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
 ;;; Copyright © 2016 Dylan Jeffers <sapientech@sapientech@openmailbox.org>
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -9983,3 +9984,29 @@ hardware-accelerated multitouch applications.")
 
 (define-public python2-kivy-next
   (package-with-python2 python-kivy-next))
+
+(define-public python-feedparser
+  (package
+    (name "python-feedparser")
+    (version "5.2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://pypi.python.org/packages/91/d8/7d37fec71ff7c9dbcdd80d2b48bcdd86d6af502156fc93846fb0102cb2c4/feedparser-"
+             version ".tar.bz2"))
+       (sha256
+        (base32
+         "00hb4qg2am06g81mygfi1jsbx8830024jm45g6qp9g8fr6am91yf"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page "https://github.com/kurtmckee/feedparser")
+    (synopsis
+     "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
+Atom 0.3, and Atom 1.0 feeds")
+    (description
+     "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
+Atom 0.3, and Atom 1.0 feeds")
+    (license
+     (non-copyleft "https://github.com/kurtmckee/feedparser/blob/develop/LICENSE"))))
-- 
2.9.0


[-- Attachment #3: Type: text/plain, Size: 28 bytes --]


Sincerely,

Matthew Jordan

Re: [PATCH 1/2] Feed2maildir: Add python-feedparser

[Leo Famulari]

On Sun, Aug 21, 2016 at 12:10:23PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 1/2] gnu: Add python-feedparser
> 
> * gnu/packages/python.scm (python-feedparser): New variable.

Thanks for these patches!

> +       (uri (string-append
> +             "https://pypi.python.org/packages/91/d8/7d37fec71ff7c9dbcdd80d2b48bcdd86d6af502156fc93846fb0102cb2c4/feedparser-"
> +             version ".tar.bz2"))

This should use the "pypi-uri" URL system.

> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)))

Does it build without setuptools? If not, setuptools should probably be
a native-input, assuming that setuptools is only used to build.

> +    (synopsis
> +     "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
> +Atom 0.3, and Atom 1.0 feeds")
> +    (description
> +     "Universal feed parser, handles RSS 0.9x, RSS 1.0, RSS 2.0, CDF,
> +Atom 0.3, and Atom 1.0 feeds")

`guix lint` should have some suggestions for the synopsis and
description. Probably, the synopsis should be something like "Parse Atom
and RSS feeds in Python". And the description should be a complete
sentence.

> +    (license
> +     (non-copyleft "https://github.com/kurtmckee/feedparser/blob/develop/LICENSE"))))

The licenses appear to be bsd-2 or very similar variants of bsd-2.

And, does the software support Python 2? If so, we like to add both
language versions at once.

Can you send an updated patch?