From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: =?utf-8?B?4oCYZ3VpeCBsaW50?= =?utf-8?B?4oCZ?= URL checks Date: Tue, 30 Aug 2016 14:28:03 -0400 Message-ID: <20160830182803.GD2595@jasmine> References: <87h9ajqkw1.fsf@gmail.com> <20160818012541.GA31426@jasmine> <8737lp6c3a.fsf_-_@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1benlg-0003xN-FN for guix-devel@gnu.org; Tue, 30 Aug 2016 14:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1benlb-0007fh-C0 for guix-devel@gnu.org; Tue, 30 Aug 2016 14:28:15 -0400 Content-Disposition: inline In-Reply-To: <8737lp6c3a.fsf_-_@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel , Alex Kost On Sun, Aug 28, 2016 at 01:12:09AM +0200, Ludovic Courtès wrote: > Leo Famulari skribis: > > I wonder, are there any drawbacks of making the linter check that the > > URL provides the data named by the hash? > > The rationale so far was that ‘guix lint foo’ should be fast (a couple > of seconds at most), and ‘guix lint’ (all packages) should complete in > less than a day. ;-) Reasonable :) > Thus, the ‘source’ and ‘home-page’ checks simply ensure that the URI > points to something accessible instead of actually downloading the > thing. This is fast and catches the most obvious errors, but has the > drawback of not catching the right-URL-wrong-hash kind of errors. I guess that `guix build --check --source foo` is the right way to check for this mistake.