From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: Add gzstream. Date: Tue, 30 Aug 2016 13:48:46 -0500 Message-ID: <20160830134846.328552cd@openmailbox.org> References: <87eg56yvdh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beo5i-0005bk-3m for guix-devel@gnu.org; Tue, 30 Aug 2016 14:48:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beo5e-0003c5-Qp for guix-devel@gnu.org; Tue, 30 Aug 2016 14:48:58 -0400 Received: from smtp12.openmailbox.org ([62.4.1.46]:45485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beo5e-0003bW-HD for guix-devel@gnu.org; Tue, 30 Aug 2016 14:48:54 -0400 In-Reply-To: <87eg56yvdh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Thanks for the patch! Comments below: On Tue, 30 Aug 2016 19:17:14 +0100 Marius Bakke wrote: > From 5e96b895c1ed77a6bfdcbe5c6dbd68220fd5a8dc Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Fri, 12 Aug 2016 02:29:51 +0100 > Subject: [PATCH 1/1] gnu: Add gzstream. > > * gnu/packages/compression.scm (gzstream): New variable. > --- > [...] > + (source (origin > + (method url-fetch) > + (uri > + ;; No versioned URL, but last release was in 2003. > + "http://www.cs.unc.edu/Research/compgeom/gzstream/gzstream.tgz") > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "00y19pqjsdj5zcrx4p9j56pl73vayfwnb7y2hvp423nx0cwv5b4r")))) There's a gzstream.o file in the tarball. Could you remove it an origin snippet? > [...] > + (home-page "http://www.cs.unc.edu/Research/compgeom/gzstream/") > + (synopsis "C++ library that provides the functionality of zlib in a C++ iostream") Maybe: "Compressed C++ iostream" > + (description "gzstream is a small library for providing zlib functionality in a C++ > +iostream. It is basically just a wrapper.") The second sentence may be left off, IMO. > + (license license:lgpl2.1))) ^ This should be lgpl2.1+ because of the "or later" in the file headers. Could you send an updated patch? `~Eric