From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
Date: Tue, 30 Aug 2016 13:26:50 -0500
Message-ID: <20160830132650.0bdcdb6f@openmailbox.org>
References: <87shtmo1mc.fsf@we.make.ritual.n0.is>
	<20160830114904.2ec3512c@openmailbox.org>
	<878tveuqh5.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1benkY-0003Tj-VF
	for guix-devel@gnu.org; Tue, 30 Aug 2016 14:27:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1benkT-0007XD-MI
	for guix-devel@gnu.org; Tue, 30 Aug 2016 14:27:05 -0400
Received: from smtp10.openmailbox.org ([62.4.1.44]:38847)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1benkT-0007X2-CL
	for guix-devel@gnu.org; Tue, 30 Aug 2016 14:27:01 -0400
In-Reply-To: <878tveuqh5.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org

On Tue, 30 Aug 2016 17:16:38 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> Eric Bavier <ericbavier@openmailbox.org> writes:
>=20
> > On Tue, 30 Aug 2016 12:57:47 +0000
> > ng0 <ng0@we.make.ritual.n0.is> wrote:
> > =20
> >> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
> >> From: ng0 <ng0@we.make.ritual.n0.is>
> >> Date: Tue, 30 Aug 2016 12:52:51 +0000
> >> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
> >>=20
> >> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for =
api.metacpan.org.
> >> (cpan-fetch-module)[json-fetch]: Likewise.
> >> ---
> >>  guix/import/cpan.scm | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>=20
> >> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
> >> index 213a155..5d393ac 100644
> >> --- a/guix/import/cpan.scm
> >> +++ b/guix/import/cpan.scm
> >> @@ -2,6 +2,7 @@
> >>  ;;; Copyright =C2=A9 2014 Eric Bavier <bavier@member.fsf.org>
> >>  ;;; Copyright =C2=A9 2015 Mark H Weaver <mhw@netris.org>
> >>  ;;; Copyright =C2=A9 2016 Alex Sassmannshausen <alex@pompo.co>
> >> +;;; Copyright =C2=A9 2016 ng0 <ng0@we.make.ritual.n0.is> =20
> >
> > This patch may be one of those cases, discussed recently on the mailing
> > list, where a copyright addition is not appropriate. =20
>=20
> "Discussed recently on the mailing list" is one of those occassions
> where I'd like to point out that it is a mailing list and therefore is not
> very good in giving information unless you search for them.
> If there was a conclusion to a longer discussion, please put it into the
> contributing section of the manual, otherwise this will be repeated over
> and over again, thanks.

It was simply pointed out that the GNU Coding Standards discusses
trivial vs nontrivial code changes.

> I don't necessarily need this copyright addition, so if it looks
> otherwise good, can you remove it for mie before commiting the patch, or
> do you want me to send it again?

I adjust the patch and pushed it in
7a62263ee50c9e2894ea0e746b89f04e3b6484c3.

Thanks,
`~Eric