unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: gno <gnopap@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] gnu: lua: Build with support for dynamic libraries.
Date: Tue, 30 Aug 2016 02:37:13 -0400	[thread overview]
Message-ID: <20160830063713.GB4193@jasmine> (raw)
In-Reply-To: <20160823020240.3304b5a4@gmail.com>

On Tue, Aug 23, 2016 at 02:02:40AM +0200, gno wrote:
> On Mon, 22 Aug 2016 21:39:12 +0200
> Ricardo Wurmus <rekado@elephly.net> wrote:
> > +       #:make-flags
> > +       '("CFLAGS=-fPIC -DLUA_DL_DLOPEN -DLUA_USE_POSIX"
> > +         "linux")
> 
> This doesn't work for me - lua-lgi still complains about lua not being
> able to dynamically load. But this does work:
> 
> (replace 'build
>   (lambda _ (zero? (system* "make"
>      "LDFLAGS=-ldl" "CFLAGS=-fPIC -DLUA_USE_DLOPEN" "linux"))))
> 
> I tried adding LDFLAGS in #make-flags to no avail.

Based on my reading of the Makefile (and the 'src/Makefile'), I think we
should be using MYCFLAGS and MYLDFLAGS.

CFLAGS and LDFLAGS include MYCFLAGS and MYLDFLAGS, respectively, but
they also include some default flags and platform-dependent flags. By
setting CFLAGS and LDFLAGS directly, we lose those default and
platform-dependent values.

By the way, '-ldl' does get passed to GCC in 'src/Makefile', but I don't
think it gets passed to the linker, although my knowledge here is not
strong.

  parent reply	other threads:[~2016-08-30  6:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-22 19:39 [PATCH 0/7] Add Prosody Ricardo Wurmus
2016-08-22 19:39 ` [PATCH 1/7] gnu: lua: Build with support for dynamic libraries Ricardo Wurmus
2016-08-22 20:05   ` Leo Famulari
2016-08-23  0:02   ` gno
2016-08-28  8:23     ` Ricardo Wurmus
2016-08-30  6:37     ` Leo Famulari [this message]
2016-08-22 19:39 ` [PATCH 2/7] gnu: lua: Use "license:" prefix Ricardo Wurmus
2016-08-22 19:39 ` [PATCH 3/7] gnu: Add lua5.1-expat Ricardo Wurmus
2016-08-22 19:53   ` Leo Famulari
2016-08-22 19:39 ` [PATCH 4/7] gnu: Add lua5.1-socket Ricardo Wurmus
2016-08-22 19:39 ` [PATCH 5/7] gnu: Add lua5.1-filesystem Ricardo Wurmus
2016-08-22 19:39 ` [PATCH 6/7] gnu: Add luasec Ricardo Wurmus
2016-08-22 19:39 ` [PATCH 7/7] gnu: Add prosody Ricardo Wurmus
2016-08-23  1:33   ` Leo Famulari
2016-08-28 10:37     ` Ricardo Wurmus
2016-08-30  1:36       ` Leo Famulari
2016-08-22 20:03 ` [PATCH 0/7] Add Prosody Leo Famulari
2016-08-22 20:37   ` Ricardo Wurmus
     [not found] <9cf2a138-d37a-b88e-57f6-c053b0dbb670@gmail.com>
2016-08-30  8:44 ` [PATCH 1/7] gnu: lua: Build with support for dynamic libraries gno
2016-08-30 19:33   ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160830063713.GB4193@jasmine \
    --to=leo@famulari.name \
    --cc=gnopap@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).