From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: Addition to gnu-build-system: make test. Date: Sun, 28 Aug 2016 14:23:53 +0200 Message-ID: <20160828122353.GA27216@jocasta.intra> References: <87inunse1q.fsf@we.make.ritual.n0.is> <20160828090544.GE26988@macbook42.flashner.co.il> <20160828094103.GA25813@jocasta.intra> <87a8fxkw78.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdz86-0001ER-P5 for guix-devel@gnu.org; Sun, 28 Aug 2016 08:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdz82-00026d-JF for guix-devel@gnu.org; Sun, 28 Aug 2016 08:24:01 -0400 Received: from de.cellform.com ([88.217.224.109]:39377 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdz82-00026N-6H for guix-devel@gnu.org; Sun, 28 Aug 2016 08:23:58 -0400 Content-Disposition: inline In-Reply-To: <87a8fxkw78.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Why not generalise that: check-alias "test" which defaults to check. Or something similar. J' On Sun, Aug 28, 2016 at 10:46:19AM +0000, ng0 wrote: Can we ease it up in a different way for applications which do not have aliases? Maybe using something like #:check-is-tests? #t in the arguments, which fails when check and test exist? =20 John Darrington writes: =20 > [ Unknown signature status ] > "make check" is what the Gnu Coding Standards specify: > http://www.gnu.org/prep/standards/standards.html#Standard-Targets > > So I think it should stay as it is - at least for the gnu-build-syst= em > > J' > > On Sun, Aug 28, 2016 at 12:05:47PM +0300, Efraim Flashner wrote: > On Fri, Aug 26, 2016 at 04:14:25PM +0000, ng0 wrote: > >=20 > > 2016-08-26 15:16 recently when I pointed out to someone= and they > > added a make check which just calls the original make test, I= was > > wondering if our gnu build system should try for make test an= d make > > check.. this seems to be very common test instead of check > > 2016-08-26 15:19 ng0: Or maybe try one if the ot= her fails? > > 2016-08-26 15:19 yes.. very often I had to replace chec= k with just > > test > > 2016-08-26 15:21 It might be worth bringing up o= n the > > guix-devel mailing list to see what others think. > > 2016-08-26 15:21 yes.. I will do so later > >=20 > > What do others think? How can we extend gnu-build-system so t= hat make > > test can be used but make check is not ignored? > > --=20 > > ng0 > > For non-prism friendly talk find me on http://www.psyced.org > >=20 > =20 > I was curious how many times we use test-target: > =20 > $ grep test-target gnu/packages/*scm | wc -l > 87 > $ grep test-target gnu/packages/*scm | grep \"test\" | wc -l > 52 > $ grep test-target gnu/packages/*scm | grep \"tests\" | wc -l > 8 > =20 > I guess the real question is, will running an extra `make test'= after > `make check' break anything? Also, I'm sure some of the makefil= es have > one as an alias of the other, we don't want to run the tests tw= ice. > =20 > =20 > --=20 > Efraim Flashner ?????????? ????????= ?? > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > Confidentiality cannot be guaranteed on emails sent or received= unencrypted > > > > --=20 > Avoid eavesdropping. Send strong encryted email. > PGP Public key ID: 1024D/2DE827B3=20 > fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 > See http://sks-keyservers.net or any PGP keyserver for public key. > =20 --=20 ng0 For non-prism friendly talk find me on http://www.psyced.org --=20 Avoid eavesdropping. Send strong encryted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfC19kACgkQimdxnC3oJ7PFNQCfcIuFr6AcXQ4yaspN1hOHbArP pq4AnRR+gqyvS2FnYIykrR7rLj7NeODE =zJGH -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--