From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: Addition to gnu-build-system: make test. Date: Sun, 28 Aug 2016 11:41:03 +0200 Message-ID: <20160828094103.GA25813@jocasta.intra> References: <87inunse1q.fsf@we.make.ritual.n0.is> <20160828090544.GE26988@macbook42.flashner.co.il> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdwaV-0007tt-3U for guix-devel@gnu.org; Sun, 28 Aug 2016 05:41:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdwaQ-0001pF-TY for guix-devel@gnu.org; Sun, 28 Aug 2016 05:41:10 -0400 Received: from de.cellform.com ([88.217.224.109]:39351 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdwaQ-0001p7-Kh for guix-devel@gnu.org; Sun, 28 Aug 2016 05:41:06 -0400 Content-Disposition: inline In-Reply-To: <20160828090544.GE26988@macbook42.flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org, ng0 --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable "make check" is what the Gnu Coding Standards specify: http://www.gnu.org/prep/standards/standards.html#Standard-Targets So I think it should stay as it is - at least for the gnu-build-system J' On Sun, Aug 28, 2016 at 12:05:47PM +0300, Efraim Flashner wrote: On Fri, Aug 26, 2016 at 04:14:25PM +0000, ng0 wrote: >=20 > 2016-08-26 15:16 recently when I pointed out to someone and th= ey > added a make check which just calls the original make test, I was > wondering if our gnu build system should try for make test and make > check.. this seems to be very common test instead of check > 2016-08-26 15:19 ng0: Or maybe try one if the other fai= ls? > 2016-08-26 15:19 yes.. very often I had to replace check with = just > test > 2016-08-26 15:21 It might be worth bringing up on the > guix-devel mailing list to see what others think. > 2016-08-26 15:21 yes.. I will do so later >=20 > What do others think? How can we extend gnu-build-system so that make > test can be used but make check is not ignored? > --=20 > ng0 > For non-prism friendly talk find me on http://www.psyced.org >=20 =20 I was curious how many times we use test-target: =20 $ grep test-target gnu/packages/*scm | wc -l 87 $ grep test-target gnu/packages/*scm | grep \"test\" | wc -l 52 $ grep test-target gnu/packages/*scm | grep \"tests\" | wc -l 8 =20 I guess the real question is, will running an extra `make test' after `make check' break anything? Also, I'm sure some of the makefiles have one as an alias of the other, we don't want to run the tests twice. =20 =20 --=20 Efraim Flashner ?????????? ?????????? GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencr= ypted --=20 Avoid eavesdropping. Send strong encryted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfCsa8ACgkQimdxnC3oJ7MMNACggXtyRKtSGlUxZQBafX3f+rqP JGgAn24DB1FLL1CbsRfjrETGhE0ifL6q =e8p8 -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--