[PATCH 00/31] KDE Tier 3 Packages

[PATCH 00/31] KDE Tier 3 Packages

[David Craven]

kdewebkit is missing

kio, kservice, kxmlgui, kemoticons, kiconthemes, plasma-frameworks,
krunner, ktexteditor and knewstuff have tests disabled

David Craven (31):
  gnu: qtbase: Add native search paths.
  gnu: qt: Import licenses using #:prefix license:.
  build: Add wrap-qt-program.
  gnu: Add baloo.
  gnu: Add kactivities.
  gnu: Add kactivities-stats.
  gnu: Add kbookmarks.
  gnu: Add kcmutils.
  gnu: Add kconfigwidgets.
  gnu: Add kdeclarative.
  gnu: Add kded.
  gnu: Add kdesignerplugin.
  gnu: Add kdesu.
  gnu: Add kemoticons.
  gnu: Add kglobalaccel.
  gnu: Add kiconthemes.
  gnu: Add kinit.
  gnu: Add kio.
  gnu: Add knewstuff.
  gnu: Add knotifyconfig.
  gnu: Add kparts.
  gnu: Add kpeople.
  gnu: Add krunner.
  gnu: Add kservice.
  gnu: Add ktexteditor.
  gnu: Add ktextwidgets.
  gnu: Add kwallet.
  gnu: Add kxmlgui.
  gnu: Add kxmlrpcclient.
  gnu: Add plasma-framework.
  gnu: Add kpmcore.

 Makefile.am                     |    1 +
 gnu/packages/kde-frameworks.scm | 1303 +++++++++++++++++++++++++++++++++++++++
 gnu/packages/qt.scm             |   28 +-
 guix/build/qt-utils.scm         |   40 ++
 4 files changed, 1364 insertions(+), 8 deletions(-)
 create mode 100644 guix/build/qt-utils.scm

-- 
2.9.0

[PATCH 01/31] gnu: qtbase: Add native search paths.

[David Craven]

* gnu/packages/qt.scm (qtbase)[native-search-paths]:
Add QML2_IMPORT_PATH.
Add QT_PLUGIN_PATH.
Add XDG_DATA_DIRS.
Add XDG_CONFIG_DIRS.
---
 gnu/packages/qt.scm | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index a7eee7c..5a93ea2 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -474,7 +474,19 @@ developers using C++ or QML, a CSS & JavaScript like language.")
     (native-search-paths
      (list (search-path-specification
             (variable "QMAKEPATH")
-            (files '("")))))
+            (files '("")))
+           (search-path-specification
+            (variable "QML2_IMPORT_PATH")
+            (files '("qml")))
+           (search-path-specification
+            (variable "QT_PLUGIN_PATH")
+            (files '("plugins")))
+           (search-path-specification
+            (variable "XDG_DATA_DIRS")
+            (files '("share")))
+           (search-path-specification
+            (variable "XDG_CONFIG_DIRS")
+            (files '("etc/xdg")))))
     (home-page "https://www.qt.io/")
     (synopsis "Cross-platform GUI library")
     (description "Qt is a cross-platform application and UI framework for
-- 
2.9.0

[PATCH 02/31] gnu: qt: Import licenses using #:prefix license:.

[David Craven]

* gnu/packages/qt.scm
(qt)[license]: Use license:.
(qt-4)[license]: Use license:.
(qtbase)[license]: Use license:.
(python-sip)[license]: Use license:.
(python-pyqt)[license]: Use license:.
(qtkeychain)[license]: Use license:.
---
 gnu/packages/qt.scm | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 5a93ea2..95690fa 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -20,7 +20,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages qt)
-  #:use-module ((guix licenses) #:select (bsd-3 gpl2 gpl3 lgpl2.1 lgpl2.1+ lgpl3 x11-style))
+  #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build utils)
@@ -206,7 +206,7 @@
     (synopsis "Cross-platform GUI library")
     (description "Qt is a cross-platform application and UI framework for
 developers using C++ or QML, a CSS & JavaScript like language.")
-    (license lgpl2.1)
+    (license license:lgpl2.1)
 
     ;; Qt 4: 'QBasicAtomicPointer' leads to build failures on MIPS;
     ;; see <http://hydra.gnu.org/build/112828>.
@@ -491,7 +491,7 @@ developers using C++ or QML, a CSS & JavaScript like language.")
     (synopsis "Cross-platform GUI library")
     (description "Qt is a cross-platform application and UI framework for
 developers using C++ or QML, a CSS & JavaScript like language.")
-    (license (list lgpl2.1 lgpl3))))
+    (license (list license:lgpl2.1 license:lgpl3))))
 
 (define-public qtsvg
   (package (inherit qtbase)
@@ -920,7 +920,7 @@ is then compiled to create the bindings extension module.  The SIP Python
 module provides support functions to the automatically generated code.")
     ;; There is a choice between a python like license, gpl2 and gpl3.
     ;; For compatibility with pyqt, we need gpl3.
-    (license gpl3)))
+    (license license:gpl3)))
 
 (define-public python2-sip
   (package (inherit python-sip)
@@ -985,7 +985,7 @@ module provides support functions to the automatically generated code.")
      "PyQt is a set of Python v2 and v3 bindings for the Qt application
 framework.  The bindings are implemented as a set of Python modules and
 contain over 620 classes.")
-    (license gpl3)))
+    (license license:gpl3)))
 
 (define-public python2-pyqt
   (package (inherit python-pyqt)
@@ -1067,7 +1067,7 @@ contain over 620 classes.")
                              "--destdir" lib
                              "--sipdir" sip))))
          %standard-phases)))
-    (license (list gpl2 gpl3)))) ; choice of either license
+    (license (list license:gpl2 license:gpl3)))) ; choice of either license
 
 (define-public qtkeychain
   (package
@@ -1101,4 +1101,4 @@ contain over 620 classes.")
     (description
       "QtKeychain is a Qt library to store passwords and other secret data
 securely.  It will not store any data unencrypted unless explicitly requested.")
-    (license bsd-3)))
+    (license license:bsd-3)))
-- 
2.9.0

[PATCH 03/31] build: Add wrap-qt-program.

[David Craven]

* guix/build/qt-utils.scm (wrap-qt-program): New file.
---
 Makefile.am             |  1 +
 guix/build/qt-utils.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+)
 create mode 100644 guix/build/qt-utils.scm

diff --git a/Makefile.am b/Makefile.am
index 8bae85e..165dfe9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -107,6 +107,7 @@ MODULES =					\
   guix/build/emacs-utils.scm			\
   guix/build/graft.scm				\
   guix/build/bournish.scm			\
+  guix/build/qt-utils.scm			\
   guix/search-paths.scm				\
   guix/packages.scm				\
   guix/import/utils.scm				\
diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm
new file mode 100644
index 0000000..48a3267
--- /dev/null
+++ b/guix/build/qt-utils.scm
@@ -0,0 +1,40 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 David Craven <david@craven.ch>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (guix build qt-utils)
+  #:use-module (guix build utils)
+  #:export (wrap-qt-program))
+
+(define (wrap-qt-program out program)
+  (define (suffix env-var path)
+    (let ((env-val (getenv env-var)))
+      (if env-val (string-append env-val ":" path) path)))
+
+  (let ((qml-path        (suffix "QML2_IMPORT_PATH"
+                                 (string-append out "/qml")))
+        (plugin-path     (suffix "QT_PLUGIN_PATH"
+                                 (string-append out "/plugins")))
+        (xdg-data-path   (suffix "XDG_DATA_DIRS"
+                                 (string-append out "/share")))
+        (xdg-config-path (suffix "XDG_CONFIG_DIRS"
+                                 (string-append out "/etc/xdg"))))
+    (wrap-program (string-append out "/bin/" program)
+      `("QML2_IMPORT_PATH" = (,qml-path))
+      `("QT_PLUGIN_PATH" = (,plugin-path))
+      `("XDG_DATA_DIRS" = (,xdg-data-path))
+      `("XDG_CONFIG_DIRS" = (,xdg-config-path)))))
-- 
2.9.0

[PATCH 04/31] gnu: Add baloo.

[David Craven]

* gnu/packages/kde-frameworks.scm (baloo): New variable.
---
 gnu/packages/kde-frameworks.scm | 63 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6ba454d..ff93e62 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -30,6 +30,7 @@
   #:use-module (gnu packages boost)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages databases)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
@@ -1461,3 +1462,65 @@ different physical units.  It supports converting different prefixes (e.g. kilo,
 mega, giga) as well as converting between different unit systems (e.g. liters,
 gallons).")
     (license license:lgpl2.1+)))
+
+
+;; Tier 3
+;;
+;; Tier 3 frameworks are generally more powerful, comprehensive packages, and
+;; consequently have more complex dependencies.
+
+(define-public baloo
+  (package
+    (name "baloo")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1ayfdg6j9lvas17ryjdv4a0kaj6vw3bxfy2x9nadl0gkc9pak4nh"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kcoreaddons" ,kcoreaddons)
+       ("kfilemetadata" ,kfilemetadata)))
+    (native-inputs
+     `(("dbus" ,dbus)
+       ("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kbookmarks" ,kbookmarks)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kidletime" ,kidletime)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("lmdb" ,lmdb)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("solid" ,solid)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t))
+         (replace 'check
+           (lambda _
+             (setenv "DBUS_FATAL_WARNINGS" "0")
+             (zero? (system* "dbus-launch" "ctest" ".")))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "File searching and indexing")
+    (description "Baloo provides file searching and indexing.  It does so by
+maintaining an index of the contents of your files.")
+    (license (list license:gpl2+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 05/31] gnu: Add kactivities.

[David Craven]

* gnu/packages/kde-frameworks.scm (kactivities): New variable.
---
 gnu/packages/kde-frameworks.scm | 56 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index ff93e62..e81c5f8 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -29,6 +29,7 @@
   #:use-module (gnu packages attr)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages bison)
+  #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages docbook)
@@ -1524,3 +1525,58 @@ gallons).")
     (description "Baloo provides file searching and indexing.  It does so by
 maintaining an index of the contents of your files.")
     (license (list license:gpl2+ license:lgpl2.1+))))
+
+(define-public kactivities
+  (package
+    (name "kactivities")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0s8g43zk6h35bq1am1nnhj0qvmhd6kz42gs8l7ybga0367jghzhf"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("boost" ,boost)
+       ("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("solid" ,solid)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Core components for the KDE Activity concept")
+    (description "When a user is interacting with a computer, there are three
+main areas of contextual information that may affect the behaviour of the
+system: who the user is, where they are, and what they are doing.
+
+Activities deal with the last one.  An activity might be \"developing a KDE
+application\", \"studying 19th century art\", \"composing music\" or \"watching
+funny videos\".  Each of these activites may involve multiple applications, and
+a single application may be used in multiple activities (for example, most
+activities are likely to involve using a web browser, but different activities
+will probably involve different websites).
+
+KActivities provides the infrastructure needed to manage a user's activites,
+allowing them to switch between tasks, and for applications to update their
+state to match the user's current activity.  This includes a daemon, a library
+for interacting with that daemon, and plugins for integration with other
+frameworks.")
+    (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 06/31] gnu: Add kactivities-stats.

[David Craven]

* gnu/packages/kde-frameworks.scm (kactivities-stats): New variable.

Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
---
 gnu/packages/kde-frameworks.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index e81c5f8..f7799bd 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1580,3 +1580,37 @@ state to match the user's current activity.  This includes a daemon, a library
 for interacting with that daemon, and plugins for integration with other
 frameworks.")
     (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))
+
+;; NOTE: This package is listed as a tier 2 package even dough it requires
+;;       kactivities - a tier 3 package.
+(define-public kactivities-stats
+  (package
+    (name "kactivities-stats")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1z3xvpifxbd05b2xaxxyiypcpid7jgjb1qpwiyjj1gnfp4rjmzpc"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("boost" ,boost)
+       ("kactivities" ,kactivities)
+       ("kconfig" ,kconfig)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Access usage statistics collected by the activity manager")
+    (description "The KActivitiesStats library provides a querying mechanism for
+the data that the activitiy manager collects - which documents hae been opened
+by which applications, and what documents have been linked to which activity.
+The activity manager also keeps the score for each document which gets higher
+when a particular document has been often accessed or kept open for longer
+periods of time.  This score is also available through the querying mechanism.")
+    (license (list license:lgpl2.0+ license:lgpl2.1+ license:lgpl3+))))
-- 
2.9.0

[PATCH 07/31] gnu: Add kbookmarks.

[David Craven]

* gnu/packages/kde-frameworks.scm (kbookmarks): New variable.
---
 gnu/packages/kde-frameworks.scm | 42 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index f7799bd..66c036b 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1614,3 +1614,45 @@ The activity manager also keeps the score for each document which gets higher
 when a particular document has been often accessed or kept open for longer
 periods of time.  This score is also available through the querying mechanism.")
     (license (list license:lgpl2.0+ license:lgpl2.1+ license:lgpl3+))))
+
+(define-public kbookmarks
+  (package
+    (name "kbookmarks")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "10d8dnhvbrwp0dbmz93cqfdff6ir8iy3yiwaf9ihj6ma124qlyjn"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kwidgetsaddons" ,kwidgetsaddons)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Bookmarks management library")
+    (description "KBookmarks lets you access and manipulate bookmarks stored
+using the XBEL format.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 08/31] gnu: Add kcmutils.

[David Craven]

* gnu/packages/kde-frameworks.scm (kcmutils): New variable.
---
 gnu/packages/kde-frameworks.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 66c036b..88ee496 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1656,3 +1656,42 @@ periods of time.  This score is also available through the querying mechanism.")
     (description "KBookmarks lets you access and manipulate bookmarks stored
 using the XBEL format.")
     (license license:lgpl2.1+)))
+
+(define-public kcmutils
+  (package
+    (name "kcmutils")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0aws1c76s6wbp0xpr6qv6cfwq8dw82v00pkf9gy84sbxknwjnizk"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kconfigwidgets" ,kconfigwidgets)
+       ("kservice" ,kservice)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kdeclarative" ,kdeclarative)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kpackage" ,kpackage)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Utilities for KDE System Settings modules")
+    (description "KCMUtils provides various classes to work with KCModules.
+KCModules can be created with the KConfigWidgets framework.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 09/31] gnu: Add kconfigwidgets.

[David Craven]

* gnu/packages/kde-frameworks.scm (kconfigwidgets): New variable.
---
 gnu/packages/kde-frameworks.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 88ee496..bf42d03 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1695,3 +1695,43 @@ using the XBEL format.")
     (description "KCMUtils provides various classes to work with KCModules.
 KCModules can be created with the KConfigWidgets framework.")
     (license license:lgpl2.1+)))
+
+(define-public kconfigwidgets
+  (package
+    (name "kconfigwidgets")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0v25r50gh5i984lzlv0rradghglcfqf0gsfmnkn23h87b86fm9l2"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kconfig" ,kconfig)
+       ("kwidgetsaddons" ,kwidgetsaddons)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kcoreaddons" ,kcoreaddons)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Widgets for configuration dialogs")
+    (description "KConfigWidgets provides easy-to-use classes to create
+configuration dialogs, as well as a set of widgets which uses KConfig to store
+their settings.")
+    (license (list license:gpl2+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 10/31] gnu: Add kdeclarative.

[David Craven]

* gnu/packages/kde-frameworks.scm (kdeclarative): New variable.
---
 gnu/packages/kde-frameworks.scm | 59 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index bf42d03..a85796a 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1735,3 +1735,62 @@ KCModules can be created with the KConfigWidgets framework.")
 configuration dialogs, as well as a set of widgets which uses KConfig to store
 their settings.")
     (license (list license:gpl2+ license:lgpl2.1+))))
+
+(define-public kdeclarative
+  (package
+    (name "kdeclarative")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "00ik9q1r6y6g5rkdq96yczgrxmcg85x00lipyljvc3x6xw6bixbz"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kconfig" ,kconfig)
+       ("kpackage" ,kpackage)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("xorg-server" ,xorg-server)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kglobalaccel" ,kglobalaccel)
+       ("kguiaddons" ,kguiaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("solid" ,solid)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'start-xorg-server
+           (lambda* (#:key inputs #:allow-other-keys)
+             ;; The test suite requires a running X server.
+             (system (string-append (assoc-ref inputs "xorg-server")
+                                    "/bin/Xvfb :1 -screen 0 640x480x24 &"))
+             (setenv "DISPLAY" ":1")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Integration of QML and KDE work spaces")
+    (description "KDeclarative provides integration of QML and KDE work spaces.
+It's comprises two parts: a library used by the C++ part of your application to
+intergrate QML with KDE Frameworks specific features, and a series of QML imports
+that offer bindings to some of the Frameworks.")
+    (license (list license:gpl2+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 11/31] gnu: Add kded.

[David Craven]

* gnu/packages/kde-frameworks.scm (kded): New variable.
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a85796a..a26c139 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1794,3 +1794,35 @@ It's comprises two parts: a library used by the C++ part of your application to
 intergrate QML with KDE Frameworks specific features, and a series of QML imports
 that offer bindings to some of the Frameworks.")
     (license (list license:gpl2+ license:lgpl2.1+))))
+
+(define-public kded
+  (package
+    (name "kded")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0ngpxdxb596myn5r4kjxahx195bwklq33yvgjvcbxi2clg2wccaj"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kdoctools" ,kdoctools)
+       ("kinit" ,kinit)
+       ("kservice" ,kservice)
+       ("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Central daemon of KDE work spaces")
+    (description "KDED stands for KDE Daemon.  KDED runs in the background and
+performs a number of small tasks.  Some of these tasks are built in, others are
+started on demand.")
+    (license (list license:lgpl2.0+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 12/31] gnu: Add kdesignerplugin.

[David Craven]

* gnu/packages/kde-frameworks.scm (kdesignerplugin): New variable.
---
 gnu/packages/kde-frameworks.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a26c139..3c37ad1 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1826,3 +1826,40 @@ that offer bindings to some of the Frameworks.")
 performs a number of small tasks.  Some of these tasks are built in, others are
 started on demand.")
     (license (list license:lgpl2.0+ license:lgpl2.1+))))
+
+(define-public kdesignerplugin
+  (package
+    (name "kdesignerplugin")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0i0s8pwwhwh5hyyvkv0cnj0yyv0g5bnm5xw18knv2yagiy4bvb2j"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kdoctools" ,kdoctools)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Integrating KDE frameworks widgets with Qt Designer")
+    (description "This framework provides plugins for Qt Designer that allow it
+to display the widgets provided by various KDE frameworks, as well as a utility
+(kgendesignerplugin) that can be used to generate other such plugins from
+ini-style description files.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 13/31] gnu: Add kdesu.

[David Craven]

* gnu/packages/kde-frameworks.scm (kdesu): New variable.
---
 gnu/packages/kde-frameworks.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 3c37ad1..9d37020 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1863,3 +1863,34 @@ to display the widgets provided by various KDE frameworks, as well as a utility
 (kgendesignerplugin) that can be used to generate other such plugins from
 ini-style description files.")
     (license license:lgpl2.1+)))
+
+(define-public kdesu
+  (package
+    (name "kdesu")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1ivcnhgvq75xvl0w9g7m45qzallz42ijaq0n1ap09lpdfmjbnrxk"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kpty" ,kpty)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("ki18n" ,ki18n)
+       ("kservice" ,kservice)
+       ("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "User interface for running shell commands with root privileges")
+    (description "KDESU provides functionality for building GUI front ends for
+(password asking) console mode programs.  kdesu and kdessh use it to interface
+with su and ssh respectively.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 14/31] gnu: Add kemoticons.

[David Craven]

* gnu/packages/kde-frameworks.scm (kemoticons): New variable.
---
 gnu/packages/kde-frameworks.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 9d37020..bf647d5 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1894,3 +1894,42 @@ ini-style description files.")
 (password asking) console mode programs.  kdesu and kdessh use it to interface
 with su and ssh respectively.")
     (license license:lgpl2.1+)))
+
+(define-public kemoticons
+  (package
+    (name "kemoticons")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0gmc52k5jb553jvzxwsq79v5y87kgav8i5qqv4bqc9yl7p866zhn"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kservice" ,kservice)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("karchive" ,karchive)
+       ("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f ; FIXME: 2/2 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen"))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Convert text emoticons to graphical emoticons")
+    (description "KEmoticons converts emoticons from text to a graphical
+representation with images in HTML.  It supports setting different themes for
+emoticons coming from different providers.")
+    (license (list license:gpl2+ license:lgpl2.1+ license:cc-by-sa4.0))))
-- 
2.9.0

[PATCH 15/31] gnu: Add kglobalaccel.

[David Craven]

* gnu/packages/kde-frameworks.scm (kglobalaccel): New variable.

Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
---
 gnu/packages/kde-frameworks.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index bf647d5..f3fa593 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1933,3 +1933,44 @@ with su and ssh respectively.")
 representation with images in HTML.  It supports setting different themes for
 emoticons coming from different providers.")
     (license (list license:gpl2+ license:lgpl2.1+ license:cc-by-sa4.0))))
+
+(define-public kglobalaccel
+  (package
+    (name "kglobalaccel")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "123v0ld1q88hbm3d0mqgq6lcivfkqh7pbz4hb4n76ab5v43qc15c"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kcrash" ,kcrash)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("libxcb" ,libxcb)
+       ("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)
+       ("xcb-util-keysyms" ,xcb-util-keysyms)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Global desktop keyboard shortcuts")
+    (description "KGlobalAccel allows you to have global accelerators that are
+independent of the focused window.  Unlike regular shortcuts, the application's
+window does not need focus for them to be activated.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 16/31] gnu: Add kiconthemes.

[David Craven]

* gnu/packages/kde-frameworks.scm (kiconthemes): New variable.
---
 gnu/packages/kde-frameworks.scm | 47 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index f3fa593..cfa513c 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1974,3 +1974,50 @@ emoticons coming from different providers.")
 independent of the focused window.  Unlike regular shortcuts, the application's
 window does not need focus for them to be activated.")
     (license license:lgpl2.1+)))
+
+(define-public kiconthemes
+  (package
+    (name "kiconthemes")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1k5zig2n6wzfyv6pc8dpas2862mxjyxxza00m31myrfw5i1a1h6m"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("shared-mime-info" ,shared-mime-info)))
+    (inputs
+     `(("karchive" ,karchive)
+       ("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("ki18n" ,ki18n)
+       ("kitemviews" ,kitemviews)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("qtbase" ,qtbase)
+       ("qtsvg" ,qtsvg)))
+    (arguments
+     `(#:tests? #f ; FIXME: Test failure
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda* (#:key inputs #:allow-other-keys)
+             (setenv "XDG_DATA_DIRS"
+                     (string-append (assoc-ref inputs "shared-mime-info")
+                                    "/share"))
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen"))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Icon GUI utilities")
+    (description "This library contains classes to improve the handling of icons
+in applications using the KDE Frameworks.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 17/31] gnu: Add kinit.

[David Craven]

* gnu/packages/kde-frameworks.scm (kinit): New variable.
---
 gnu/packages/kde-frameworks.scm | 43 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index cfa513c..cb18319 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2021,3 +2021,46 @@ window does not need focus for them to be activated.")
     (description "This library contains classes to improve the handling of icons
 in applications using the KDE Frameworks.")
     (license license:lgpl2.1+)))
+
+(define-public kinit
+  (package
+    (name "kinit")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1i7l6gid5hrrfglw1c461gpjg51dwz7cl4lx7ll8vz2ha8mz4d3n"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("solid" ,solid)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Library to speed up start of applications on KDE workspaces")
+    (description "Kdeinit is a process launcher similar to init used for booting
+UNIX.  It launches processes by forking and then loading a dynamic library which
+contains a 'kdemain(...)' function.  Using kdeinit to launch KDE applications
+makes starting KDE applications faster and reduces memory consumption.")
+    (license (list license:lgpl2.0+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 18/31] gnu: Add kio.

[David Craven]

* gnu/packages/kde-frameworks.scm (kio): New variable.
---
 gnu/packages/kde-frameworks.scm | 73 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index cb18319..b51fe2e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -25,6 +25,7 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages acl)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages attr)
   #:use-module (gnu packages boost)
@@ -2064,3 +2065,75 @@ UNIX.  It launches processes by forking and then loading a dynamic library which
 contains a 'kdemain(...)' function.  Using kdeinit to launch KDE applications
 makes starting KDE applications faster and reduces memory consumption.")
     (license (list license:lgpl2.0+ license:lgpl2.1+))))
+
+(define-public kio
+  (package
+    (name "kio")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0zncj9yf8zaylazlwvirylpk9vki3j889b1x2s0aav54vvj7vdi5"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kbookmarks" ,kbookmarks)
+       ("kconfig" ,kconfig)
+       ("kcompletion" ,kcompletion)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kitemviews" ,kitemviews)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kxmlgui" ,kxmlgui)
+       ("solid" ,solid)))
+    (native-inputs
+     `(("dbus" ,dbus)
+       ("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("acl" ,acl)
+       ("karchive" ,karchive)
+       ("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kdoctools" ,kdoctools)
+       ("kiconthemes" ,kiconthemes)
+       ("ki18n" ,ki18n)
+       ("knotifications" ,knotifications)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwallet" ,kwallet)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("libxml2" ,libxml2)
+       ("libxslt" ,libxslt)
+       ("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)
+       ("sonnet" ,sonnet)))
+    (arguments
+     `(#:tests? #f ; FIXME: 41/50 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "XDG_RUNTIME_DIR" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+             (setenv "QT_QPA_PLATFORM" "offscreen"))))))
+    ;;(replace 'check
+    ;;  (lambda _
+    ;;    (setenv "DBUS_FATAL_WARNINGS" "0")
+    ;;    (zero? (system* "dbus-launch" "ctest" ".")))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Network transparent access to files and data")
+    (description "This framework implements a lot of file management functions.
+It supports accessing files locally as well as via HTTP and FTP out of the box
+and can be extended by plugins to support other protocols as well.  There is a
+variety of plugins available, e.g. to support access via SSH.  The framework can
+also be used to bridge a native protocol to a file-based interface.  This makes
+the data accessible in all applications using the KDE file dialog or any other
+KIO enabled infrastructure.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 19/31] gnu: Add knewstuff.

[David Craven]

* gnu/packages/kde-frameworks.scm (knewstuff): New variable.
---
 gnu/packages/kde-frameworks.scm | 55 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index b51fe2e..05403ed 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2137,3 +2137,58 @@ also be used to bridge a native protocol to a file-based interface.  This makes
 the data accessible in all applications using the KDE file dialog or any other
 KIO enabled infrastructure.")
     (license license:lgpl2.1+)))
+
+(define-public knewstuff
+  (package
+    (name "knewstuff")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0xdv3wh3100vzsx8p2zihy1dvh0wzfmrjkjq71v8igwz5d291zsj"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("attica" ,attica)
+       ("kservice" ,kservice)
+       ("kxmlgui" ,kxmlgui)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("karchive" ,karchive)
+       ("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kjobwidgets" ,kjobwidgets)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("qtbase" ,qtbase)
+       ("solid" ,solid)
+       ("sonnet" ,sonnet)))
+    (arguments
+     `(#:tests? #f ; FIXME: 1/3 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _ ; XDG_DATA_DIRS isn't set
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+             (setenv "QT_QPA_PLATFORM" "offscreen"))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Framework for downloading and sharing additional application data")
+    (description "The KNewStuff library implements collaborative data sharing
+for applications.  It uses libattica to support the Open Collaboration Services
+specification.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 20/31] gnu: Add knotifyconfig.

[David Craven]

* gnu/packages/kde-frameworks.scm (knotifyconfig): New variable.
---
 gnu/packages/kde-frameworks.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 05403ed..82fda93 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2192,3 +2192,44 @@ KIO enabled infrastructure.")
 for applications.  It uses libattica to support the Open Collaboration Services
 specification.")
     (license license:lgpl2.1+)))
+
+(define-public knotifyconfig
+  (package
+    (name "knotifyconfig")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1dij841fnqia4p44x2wnpdvl8cn3nkj833y0fah50fmipjc8r70b"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("knotifications" ,knotifications)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("phonon" ,phonon)
+       ("qtbase" ,qtbase)
+       ("solid" ,solid)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Configuration dialog for desktop notifications")
+    (description "KNotifyConfig provides a configuration dialog for desktop
+notifications which can be embedded in your application.")
+    (license (list license:lgpl2.0+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 21/31] gnu: Add kparts.

[David Craven]

* gnu/packages/kde-frameworks.scm (kparts): New variable.
---
 gnu/packages/kde-frameworks.scm | 50 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 82fda93..6b450cb 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2233,3 +2233,53 @@ specification.")
     (description "KNotifyConfig provides a configuration dialog for desktop
 notifications which can be embedded in your application.")
     (license (list license:lgpl2.0+ license:lgpl2.1+))))
+
+(define-public kparts
+  (package
+    (name "kparts")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0z7qr93aq02i7g7cxgypx2rzlnsvbsx9cjblb0ijmad1nb8w3mix"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kio" ,kio)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kxmlgui" ,kxmlgui)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("qtbase" ,qtbase)
+       ("solid" ,solid)
+       ("sonnet" ,sonnet)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Plugin framework for user interface components")
+    (description "This library implements the framework for KDE parts, which are
+widgets with a user-interface defined in terms of actions.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 22/31] gnu: Add kpeople.

[David Craven]

* gnu/packages/kde-frameworks.scm (kpeople): New variable.
---
 gnu/packages/kde-frameworks.scm | 42 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6b450cb..0e3d9c9 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2283,3 +2283,45 @@ notifications which can be embedded in your application.")
     (description "This library implements the framework for KDE parts, which are
 widgets with a user-interface defined in terms of actions.")
     (license license:lgpl2.1+)))
+
+(define-public kpeople
+  (package
+    (name "kpeople")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0iknzkj23y927xh24kw5sjxyirhy6pkmfcmmgwzd78rba8a54qp2"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))
+    (arguments
+     `(#:tests? #f ; FIXME: 1/3 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen"))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Provides access to all contacts and aggregates them by person")
+    (description "KPeople offers unified access to our contacts from different
+sources, grouping them by person while still exposing all the data.  KPeople
+also provides facilities to integrate the data provided in user interfaces by
+providing QML and Qt Widgets components.  The sources are plugin-based, allowing
+to easily extend the contacts collection.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 23/31] gnu: Add krunner.

[David Craven]

* gnu/packages/kde-frameworks.scm (krunner): New variable.
---
 gnu/packages/kde-frameworks.scm | 54 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 0e3d9c9..38a2f80 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2325,3 +2325,57 @@ also provides facilities to integrate the data provided in user interfaces by
 providing QML and Qt Widgets components.  The sources are plugin-based, allowing
 to easily extend the contacts collection.")
     (license license:lgpl2.1+)))
+
+(define-public krunner
+  (package
+    (name "krunner")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0ff87ijjd47jxf6zw2ggqgngnbyx1rj59wdfgy5wbi3acws6bafl"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("plasma-framework" ,plasma-framework)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kpackage" ,kpackage)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("solid" ,solid)
+       ("threadweaver" ,threadweaver)))
+    (arguments
+     `(#:tests? #f ; FIXME: 1/1 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen"))))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Framework for Plasma runners")
+    (description "The Plasma workspace provides an application called KRunner
+which, among other things, allows one to type into a text area which causes
+various actions and information that match the text appear as the text is being
+typed.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 24/31] gnu: Add kservice.

[David Craven]

* gnu/packages/kde-frameworks.scm (kservice): New variable.
---
 gnu/packages/kde-frameworks.scm | 42 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 38a2f80..57a9638 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2379,3 +2379,45 @@ which, among other things, allows one to type into a text area which causes
 various actions and information that match the text appear as the text is being
 typed.")
     (license license:lgpl2.1+)))
+
+(define-public kservice
+  (package
+    (name "kservice")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0w0nsg64d6xhgijr2vh0j5p544qi0q55jpqa9v9mv956zrrdssdk"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kcrash" ,kcrash)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kdoctools" ,kdoctools)
+       ("ki18n" ,ki18n)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f ; FIXME: 8/10 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Plugin framework for desktop services")
+    (description "KService provides a plugin framework for handling desktop
+services.  Services can be applications or libraries.  They can be bound to MIME
+types or handled by application specific code.")
+    (license (list license:gpl2+ license:gpl3+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 25/31] gnu: Add ktexteditor.

[David Craven]

* gnu/packages/kde-frameworks.scm (ktexteditor): New variable.
---
 gnu/packages/kde-frameworks.scm | 67 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 57a9638..d90e9de 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -45,6 +45,7 @@
   #:use-module (gnu packages polkit)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg))
@@ -2421,3 +2422,69 @@ typed.")
 services.  Services can be applications or libraries.  They can be bound to MIME
 types or handled by application specific code.")
     (license (list license:gpl2+ license:gpl3+ license:lgpl2.1+))))
+
+(define-public ktexteditor
+  (package
+    (name "ktexteditor")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1ykj1kvm7k1vxb1w235d5hp2swwdqjyp2y4c3pxbvkn999h9x5q5"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kparts" ,kparts)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("karchive" ,karchive)
+       ("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kguiaddons" ,kguiaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("libgit2" ,libgit2)
+       ("perl" ,perl)
+       ("qtbase" ,qtbase)
+       ("qtscript" ,qtscript)
+       ("qtxmlpatterns" ,qtxmlpatterns)
+       ("solid" ,solid)
+       ("sonnet" ,sonnet)))
+    (arguments
+     `(#:tests? #f ; FIXME: 2/54 tests fail: Cannot find fontdirectory qtbase/lib/font
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'setup
+           (lambda* (#:key inputs #:allow-other-keys)
+             (setenv "XDG_DATA_DIRS" ; FIXME build phase doesn't find parts.desktop
+                     (string-append (assoc-ref inputs "kparts") "/share"))
+             #t))
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             (setenv "CTEST_OUTPUT_ON_FAILURE")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Full text editor component")
+    (description "KTextEditor provides a powerful text editor component that you
+can embed in your application, either as a KPart or using the KF5::TextEditor
+library.")
+    (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 26/31] gnu: Add ktextwidgets.

[David Craven]

* gnu/packages/kde-frameworks.scm (ktextwidgets): New variable.
---
 gnu/packages/kde-frameworks.scm | 44 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d90e9de..56e854b 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2488,3 +2488,47 @@ types or handled by application specific code.")
 can embed in your application, either as a KPart or using the KF5::TextEditor
 library.")
     (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))
+
+(define-public ktextwidgets
+  (package
+    (name "ktextwidgets")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1q10xav2gkii6s3m31c9xvxf1988l7k2lpib6pyhgsidflmwjm02"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("ki18n" ,ki18n)
+       ("sonnet" ,sonnet)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Text editing widgets")
+    (description "KTextWidgets provides widgets for displaying and editing text.
+It supports rich text as well as plain text.")
+    (license (list license:lgpl2.0+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 27/31] gnu: Add kwallet.

[David Craven]

* gnu/packages/kde-frameworks.scm (kwallet): New variable.
---
 gnu/packages/kde-frameworks.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 56e854b..2d09380 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2532,3 +2532,44 @@ library.")
     (description "KTextWidgets provides widgets for displaying and editing text.
 It supports rich text as well as plain text.")
     (license (list license:lgpl2.0+ license:lgpl2.1+))))
+
+(define-public kwallet
+  (package
+    (name "kwallet")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0zad5h4vsvcl2xv3vxsjwh42b71xbp6x6rj8cvmw8szr2rzz9gsx"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("gpgmepp" ,gpgmepp)
+       ("kauth" ,kauth)
+       ("kcodecs" ,kcodecs)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kdoctools" ,kdoctools)
+       ("kiconthemes" ,kiconthemes)
+       ("ki18n" ,ki18n)
+       ("knotifications" ,knotifications)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("libgcrypt" ,libgcrypt)
+       ("phonon" ,phonon)
+       ("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Safe desktop-wide storage for passwords")
+    (description "This framework contains an interface to KWallet, a safe
+desktop-wide storage for passwords and the kwalletd daemon used to safely store
+the passwords on KDE work spaces.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 28/31] gnu: Add kxmlgui.

[David Craven]

* gnu/packages/kde-frameworks.scm (kxmlgui): New variable.
---
 gnu/packages/kde-frameworks.scm | 51 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 2d09380..a890170 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2573,3 +2573,54 @@ It supports rich text as well as plain text.")
 desktop-wide storage for passwords and the kwalletd daemon used to safely store
 the passwords on KDE work spaces.")
     (license license:lgpl2.1+)))
+
+(define-public kxmlgui
+  (package
+    (name "kxmlgui")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1qhixldhhcbklmrpjh67440h1rrzqy70h57hw6ialjdsr3pl6ihp"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("attica" ,attica)
+       ("kauth", kauth)
+       ("kcodecs" ,kcodecs)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kglobalaccel" ,kglobalaccel)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("ktextwidgets" ,ktextwidgets)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("qtbase" ,qtbase)
+       ("sonnet" ,sonnet)))
+    (arguments
+     `(#:tests? #f ; FIXME: 1/5 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Framework for managing menu and toolbar actions")
+    (description "KXMLGUI provides a framework for managing menu and toolbar
+actions in an abstract way.  The actions are configured through a XML description
+and hooks in the application code.  The framework supports merging of multiple
+descriptions for integrating actions from plugins.")
+    (license (list license:gpl2+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 29/31] gnu: Add kxmlrpcclient.

[David Craven]

* gnu/packages/kde-frameworks.scm (kxmlrpcclient): New variable.
---
 gnu/packages/kde-frameworks.scm | 42 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a890170..f3125f5 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2624,3 +2624,45 @@ actions in an abstract way.  The actions are configured through a XML descriptio
 and hooks in the application code.  The framework supports merging of multiple
 descriptions for integrating actions from plugins.")
     (license (list license:gpl2+ license:lgpl2.1+))))
+
+(define-public kxmlrpcclient
+  (package
+    (name "kxmlrpcclient")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "06ap6ipzqimz1rfrcr7z8zc7idy7sg4a97dws7h52i34ms7jqnc8"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kio" ,kio)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kitemviews" ,kitemviews)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kservice" ,kservice)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("qtbase" ,qtbase)
+       ("solid" ,solid)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "XML-RPC client")
+    (description "This library contains simple XML-RPC Client support.  It is a
+complete client and is easy to use.  Only one interface is exposed,
+kxmlrpcclient/client.h and from that interface, you only need to use 3 methods:
+setUrl, setUserAgent and call.")
+    (license (list license:bsd-3 license:lgpl2.1+))))
-- 
2.9.0

[PATCH 30/31] gnu: Add plasma-framework.

[David Craven]

* gnu/packages/kde-frameworks.scm (plasma-framework): New variable.
---
 gnu/packages/kde-frameworks.scm | 65 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index f3125f5..2deb039 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2666,3 +2666,68 @@ complete client and is easy to use.  Only one interface is exposed,
 kxmlrpcclient/client.h and from that interface, you only need to use 3 methods:
 setUrl, setUserAgent and call.")
     (license (list license:bsd-3 license:lgpl2.1+))))
+
+(define-public plasma-framework
+  (package
+    (name "plasma-framework")
+    (version "5.24.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/frameworks/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0981vm00541dzihlr1fsax05biwp2ddpwjrmvnfysx5jagdc65cb"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("kpackage" ,kpackage)
+       ("kservice" ,kservice)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kactivities" ,kactivities)
+       ("karchive" ,karchive)
+       ("kauth" ,kauth)
+       ("kbookmarks" ,kbookmarks)
+       ("kcodecs" ,kcodecs)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kdbusaddons" ,kdbusaddons)
+       ("kdeclarative" ,kdeclarative)
+       ("kdoctools" ,kdoctools)
+       ("kglobalaccel" ,kglobalaccel)
+       ("kguiaddons" ,kguiaddons)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemviews" ,kitemviews)
+       ("kio" ,kio)
+       ("ki18n" ,ki18n)
+       ("kjobwidgets" ,kjobwidgets)
+       ("knotificantions" ,knotifications)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("phonon" ,phonon)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("qtsvg" ,qtsvg)
+       ("qtx11extras" ,qtx11extras)
+       ("solid" ,solid)))
+    (arguments
+     `(#:tests? #f ; FIXME: 13/14 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'check-setup
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Libraries, components and tools of Plasma workspaces")
+    (description "The plasma framework provides QML components, libplasma and
+script engines.")
+    (license (list license:gpl2+ license:lgpl2.1+))))
-- 
2.9.0

[PATCH 31/31] gnu: Add kpmcore.

[David Craven]

* gnu/packages/kde-frameworks.scm (kpmcore): New variable.
---
 gnu/packages/kde-frameworks.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 2deb039..c9ae4c5 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -33,6 +33,7 @@
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages databases)
+  #:use-module (gnu packages disk)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
@@ -142,6 +143,38 @@ common build settings used in software produced by the KDE community.")
     (description "C++ bindings/wrapper for gpgme.")
     (license license:lgpl2.1+)))
 
+(define-public kpmcore
+  (package
+    (name "kpmcore")
+    (version "2.2.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/kpmcore"
+                            "/" version "/src/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1blila6ncqbmzhycx3szrbkxc000pzh62956mw5ihxvhrqpncg2p"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("kconfigwidgets" ,kconfigwidgets)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("ki18n" ,ki18n)
+       ("kservice" ,kservice)
+       ("libatasmart" ,libatasmart)
+       ("parted" ,parted)
+       ("qtbase" ,qtbase)
+       ("util-linux" ,util-linux)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Library for managing partitions")
+    (description "Library for managing partitions.")
+    (license license:gpl3+)))
+
 
 ;; Tier 1
 ;;
-- 
2.9.0

Re: [PATCH 01/31] gnu: qtbase: Add native search paths.

[Ricardo Wurmus]

David Craven <david@craven.ch> writes:

> * gnu/packages/qt.scm (qtbase)[native-search-paths]:
> Add QML2_IMPORT_PATH.
> Add QT_PLUGIN_PATH.
> Add XDG_DATA_DIRS.
> Add XDG_CONFIG_DIRS.

This looks good to me.  Thank you!

Will this result in mass rebuilds?  If so this should be pushed to
core-updates.

~~ Ricardo

Re: [PATCH 02/31] gnu: qt: Import licenses using #:prefix license:.

[Ricardo Wurmus]

David Craven <david@craven.ch> writes:

> * gnu/packages/qt.scm
> (qt)[license]: Use license:.
> (qt-4)[license]: Use license:.
> (qtbase)[license]: Use license:.
> (python-sip)[license]: Use license:.
> (python-pyqt)[license]: Use license:.
> (qtkeychain)[license]: Use license:.

The patch looks good to me.  The commit message can be simplified as
such:

    gnu: Add prefix to license imports in (gnu packages qt).
    
    * gnu/packages/qt.scm: Import (guix licenses) with prefix
      "license:".

This is how we did this kind of thing in the past.

~~ Ricardo

Re: [PATCH 03/31] build: Add wrap-qt-program.

[Ricardo Wurmus]

David Craven <david@craven.ch> writes:

> * guix/build/qt-utils.scm (wrap-qt-program): New file.

Please also mention the change to MODULES in the Makefile.am.  Other
than that it looks good to me.

~~ Ricardo

> ---
>  Makefile.am             |  1 +
>  guix/build/qt-utils.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+)
>  create mode 100644 guix/build/qt-utils.scm
>
> diff --git a/Makefile.am b/Makefile.am
> index 8bae85e..165dfe9 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -107,6 +107,7 @@ MODULES =					\
>    guix/build/emacs-utils.scm			\
>    guix/build/graft.scm				\
>    guix/build/bournish.scm			\
> +  guix/build/qt-utils.scm			\
>    guix/search-paths.scm				\
>    guix/packages.scm				\
>    guix/import/utils.scm				\
> diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm
> new file mode 100644
> index 0000000..48a3267
> --- /dev/null
> +++ b/guix/build/qt-utils.scm
> @@ -0,0 +1,40 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 David Craven <david@craven.ch>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (guix build qt-utils)
> +  #:use-module (guix build utils)
> +  #:export (wrap-qt-program))
> +
> +(define (wrap-qt-program out program)
> +  (define (suffix env-var path)
> +    (let ((env-val (getenv env-var)))
> +      (if env-val (string-append env-val ":" path) path)))
> +
> +  (let ((qml-path        (suffix "QML2_IMPORT_PATH"
> +                                 (string-append out "/qml")))
> +        (plugin-path     (suffix "QT_PLUGIN_PATH"
> +                                 (string-append out "/plugins")))
> +        (xdg-data-path   (suffix "XDG_DATA_DIRS"
> +                                 (string-append out "/share")))
> +        (xdg-config-path (suffix "XDG_CONFIG_DIRS"
> +                                 (string-append out "/etc/xdg"))))
> +    (wrap-program (string-append out "/bin/" program)
> +      `("QML2_IMPORT_PATH" = (,qml-path))
> +      `("QT_PLUGIN_PATH" = (,plugin-path))
> +      `("XDG_DATA_DIRS" = (,xdg-data-path))
> +      `("XDG_CONFIG_DIRS" = (,xdg-config-path)))))

Re: [PATCH 04/31] gnu: Add baloo.

[Ricardo Wurmus]

David Craven <david@craven.ch> writes:

> * gnu/packages/kde-frameworks.scm (baloo): New variable.

[…]

> +    (license (list license:gpl2+ license:lgpl2.1+))))

Please add a comment above that explains what this list means, e.g. to
what file which of the two licenses apply.

Other than that it’s perfect.  Thank you!

~~ Ricardo

Re: [PATCH 05/31] gnu: Add kactivities.

[Ricardo Wurmus]

David Craven <david@craven.ch> writes:

> * gnu/packages/kde-frameworks.scm (kactivities): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 56 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index ff93e62..e81c5f8 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -29,6 +29,7 @@
>    #:use-module (gnu packages attr)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages bison)
> +  #:use-module (gnu packages boost)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages databases)
>    #:use-module (gnu packages docbook)
> @@ -1524,3 +1525,58 @@ gallons).")
>      (description "Baloo provides file searching and indexing.  It does so by
>  maintaining an index of the contents of your files.")
>      (license (list license:gpl2+ license:lgpl2.1+))))
> +
> +(define-public kactivities
> +  (package
> +    (name "kactivities")
> +    (version "5.24.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://kde/stable/frameworks/"
> +                           (version-major+minor version) "/"
> +                           name "-" version ".tar.xz"))
> +       (sha256
> +        (base32
> +         "0s8g43zk6h35bq1am1nnhj0qvmhd6kz42gs8l7ybga0367jghzhf"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)))
> +    (inputs
> +     `(("boost" ,boost)
> +       ("kauth" ,kauth)
> +       ("kbookmarks" ,kbookmarks)
> +       ("kcodecs" ,kcodecs)
> +       ("kcompletion" ,kcompletion)
> +       ("kconfig" ,kconfig)
> +       ("kconfigwidgets" ,kconfigwidgets)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kio" ,kio)
> +       ("kitemviews" ,kitemviews)
> +       ("kjobwidgets" ,kjobwidgets)
> +       ("kservice" ,kservice)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kwindowsystem" ,kwindowsystem)
> +       ("kxmlgui" ,kxmlgui)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)
> +       ("solid" ,solid)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "Core components for the KDE Activity concept")
> +    (description "When a user is interacting with a computer, there are three
> +main areas of contextual information that may affect the behaviour of the
> +system: who the user is, where they are, and what they are doing.
> +
> +Activities deal with the last one.  An activity might be \"developing a KDE
> +application\", \"studying 19th century art\", \"composing music\" or \"watching
> +funny videos\".  Each of these activites may involve multiple applications, and
> +a single application may be used in multiple activities (for example, most
> +activities are likely to involve using a web browser, but different activities
> +will probably involve different websites).
> +
> +KActivities provides the infrastructure needed to manage a user's activites,
> +allowing them to switch between tasks, and for applications to update their
> +state to match the user's current activity.  This includes a daemon, a library
> +for interacting with that daemon, and plugins for integration with other
> +frameworks.")

This description is a little too long for my tastes.  Do you think you
could shorten it some?

> +    (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))

As before, please add a comment whenever there’s a list of licenses.
Other than that it’s good.  Thank you!

~~ Ricardo

Re: [PATCH 06/31] gnu: Add kactivities-stats.

[Ricardo Wurmus]

David Craven <david@craven.ch> writes:

> * gnu/packages/kde-frameworks.scm (kactivities-stats): New variable.
>
> Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
> ---
>  gnu/packages/kde-frameworks.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index e81c5f8..f7799bd 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -1580,3 +1580,37 @@ state to match the user's current activity.  This includes a daemon, a library
>  for interacting with that daemon, and plugins for integration with other
>  frameworks.")
>      (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))
> +
> +;; NOTE: This package is listed as a tier 2 package even dough it requires
> +;;       kactivities - a tier 3 package.

s/dough/though/
s/ -/,/

What does this mean?  Is the tier classification an upstream thing?

> +(define-public kactivities-stats
> +  (package
> +    (name "kactivities-stats")
> +    (version "5.24.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://kde/stable/frameworks/"
> +                           (version-major+minor version) "/"
> +                           name "-" version ".tar.xz"))
> +       (sha256
> +        (base32
> +         "1z3xvpifxbd05b2xaxxyiypcpid7jgjb1qpwiyjj1gnfp4rjmzpc"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)))
> +    (inputs
> +     `(("boost" ,boost)
> +       ("kactivities" ,kactivities)
> +       ("kconfig" ,kconfig)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "Access usage statistics collected by the activity manager")
> +    (description "The KActivitiesStats library provides a querying mechanism for
> +the data that the activitiy manager collects - which documents hae
> been opened

hae –> have

> +by which applications, and what documents have been linked to which activity.
> +The activity manager also keeps the score for each document which gets higher
> +when a particular document has been often accessed or kept open for longer
> +periods of time.  This score is also available through the querying mechanism.")
> +    (license (list license:lgpl2.0+ license:lgpl2.1+ license:lgpl3+))))

Please add a comment above the “license” field.

~~ Ricardo

Re: [PATCH 06/31] gnu: Add kactivities-stats.

[David Craven]

> What does this mean?  Is the tier classification an upstream thing?

Yes it is [0]. IMO the kactivities-stats package is missclassified.

[0] https://api.kde.org/frameworks/index.html

Re: [PATCH 01/31] gnu: qtbase: Add native search paths.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Sat, Aug 27, 2016 at 08:21:55AM +0200, Ricardo Wurmus wrote:
> 
> David Craven <david@craven.ch> writes:
> 
> > * gnu/packages/qt.scm (qtbase)[native-search-paths]:
> > Add QML2_IMPORT_PATH.
> > Add QT_PLUGIN_PATH.
> > Add XDG_DATA_DIRS.
> > Add XDG_CONFIG_DIRS.
> 
> This looks good to me.  Thank you!
> 
> Will this result in mass rebuilds?  If so this should be pushed to
> core-updates.
> 
> ~~ Ricardo
> 

qtbase is "parent" to ~100 packages, 15-20 of which are more qt modules,
and a bunch are lower kde tiers. My number is inflated, but for me `guix
refresh -l qtbase' says 62 packages with 101 dependants, so its almost
entirely leaf packages at this point. I'd say its fine to push to
master.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 05/31] gnu: Add kactivities.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 4015 bytes --]

On Fri, Aug 26, 2016 at 11:52:34PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (kactivities): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 56 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
> 
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index ff93e62..e81c5f8 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -29,6 +29,7 @@
>    #:use-module (gnu packages attr)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages bison)
> +  #:use-module (gnu packages boost)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages databases)
>    #:use-module (gnu packages docbook)
> @@ -1524,3 +1525,58 @@ gallons).")
>      (description "Baloo provides file searching and indexing.  It does so by
>  maintaining an index of the contents of your files.")
>      (license (list license:gpl2+ license:lgpl2.1+))))
> +
> +(define-public kactivities
> +  (package
> +    (name "kactivities")
> +    (version "5.24.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://kde/stable/frameworks/"
> +                           (version-major+minor version) "/"
> +                           name "-" version ".tar.xz"))
> +       (sha256
> +        (base32
> +         "0s8g43zk6h35bq1am1nnhj0qvmhd6kz42gs8l7ybga0367jghzhf"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)))
> +    (inputs
> +     `(("boost" ,boost)
> +       ("kauth" ,kauth)
> +       ("kbookmarks" ,kbookmarks)
> +       ("kcodecs" ,kcodecs)
> +       ("kcompletion" ,kcompletion)
> +       ("kconfig" ,kconfig)
> +       ("kconfigwidgets" ,kconfigwidgets)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kio" ,kio)
> +       ("kitemviews" ,kitemviews)
> +       ("kjobwidgets" ,kjobwidgets)
> +       ("kservice" ,kservice)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kwindowsystem" ,kwindowsystem)
> +       ("kxmlgui" ,kxmlgui)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)
> +       ("solid" ,solid)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "Core components for the KDE Activity concept")
> +    (description "When a user is interacting with a computer, there are three
> +main areas of contextual information that may affect the behaviour of the
> +system: who the user is, where they are, and what they are doing.
> +
> +Activities deal with the last one.  An activity might be \"developing a KDE
> +application\", \"studying 19th century art\", \"composing music\" or \"watching
> +funny videos\".  Each of these activites may involve multiple applications, and
> +a single application may be used in multiple activities (for example, most
> +activities are likely to involve using a web browser, but different activities
> +will probably involve different websites).
> +
> +KActivities provides the infrastructure needed to manage a user's activites,
> +allowing them to switch between tasks, and for applications to update their
> +state to match the user's current activity.  This includes a daemon, a library
> +for interacting with that daemon, and plugins for integration with other
> +frameworks.")
> +    (license (list license:gpl2+ license:lgpl2.0+ license:lgpl2.1+))))
> -- 
> 2.9.0
> 

I didn't look at the list too much, but it looks like it depends on a
lot of the packages that are also part of this patch set. IMO it should
be moved to the end of the patch set, but in any case make sure not to
push this one before all of the packages it depends on are pushed.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 05/31] gnu: Add kactivities.

[David Craven]

> I didn't look at the list too much, but it looks like it depends on a
> lot of the packages that are also part of this patch set. IMO it should
> be moved to the end of the patch set, but in any case make sure not to
> push this one before all of the packages it depends on are pushed.

There are a lot of package interdependencies in this patchset. The
packages are sorted alphabetically within their tiers. Reordering the
commits to build individually is a lot of work, I think it's best to
commit them all at once... The packages are already getting stale
(since 5.25.0 is out). I think it would be good to consider this an
initial import and fix issues as we go. (I'll fix the things already
mentioned of course)

Re: [PATCH 01/31] gnu: qtbase: Add native search paths.

[David Craven]

> Will this result in mass rebuilds?  If so this should be pushed to
> core-updates.

I too think that it's below the core updates threshold...

Re: [PATCH 00/31] KDE Tier 3 Packages

[Hartmut Goebel]

[-- Attachment #1.1: Type: text/plain, Size: 615 bytes --]

Am 26.08.2016 um 23:52 schrieb David Craven:
> kio, kservice, kxmlgui, kemoticons, kiconthemes, plasma-frameworks,
> krunner, ktexteditor and knewstuff have tests disabled

Thanks for this great work!

-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP, ISO 27001 Lead Implementer
Information Security Management, Security Governance, Secure Software
Development

Goebel Consult, Landshut
http://www.goebel-consult.de

Blog:
http://www.goebel-consult.de/blog/warum-sie-nicht-perl-programmiern-sollten
Kolumne: http://www.cissp-gefluester.de/2010-08-scheingefechte-um-rim


[-- Attachment #1.2: Type: text/html, Size: 1751 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2430 bytes --]

Re: [PATCH 04/31] gnu: Add baloo.

[David Craven]

If the project is dual licensed or tripple licensed do I have to add a
comment to each package? Or can we assume that that's the default?

Re: [PATCH 04/31] gnu: Add baloo.

[David Craven]

Thanks! Added the comments and pushed.

Re: [PATCH 00/31] KDE Tier 3 Packages

[Ludovic Courtès]

Hartmut Goebel <h.goebel@goebel-consult.de> skribis:

> Am 26.08.2016 um 23:52 schrieb David Craven:
>> kio, kservice, kxmlgui, kemoticons, kiconthemes, plasma-frameworks,
>> krunner, ktexteditor and knewstuff have tests disabled
>
> Thanks for this great work!

+1  I’m impressed by the sheer number of KDE packages that have landed
recently!

Ludo’.