From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: Addition to gnu-build-system: make test. Date: Sun, 28 Aug 2016 12:05:47 +0300 Message-ID: <20160828090544.GE26988@macbook42.flashner.co.il> References: <87inunse1q.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7uYPyRQQ5N0D02nI" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdw2g-0000Uc-9T for guix-devel@gnu.org; Sun, 28 Aug 2016 05:06:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdw2d-0002nH-52 for guix-devel@gnu.org; Sun, 28 Aug 2016 05:06:14 -0400 Received: from flashner.co.il ([178.62.234.194]:58528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdw2c-0002mI-UK for guix-devel@gnu.org; Sun, 28 Aug 2016 05:06:11 -0400 Content-Disposition: inline In-Reply-To: <87inunse1q.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --7uYPyRQQ5N0D02nI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 26, 2016 at 04:14:25PM +0000, ng0 wrote: >=20 > 2016-08-26 15:16 recently when I pointed out to someone and they > added a make check which just calls the original make test, I was > wondering if our gnu build system should try for make test and make > check.. this seems to be very common test instead of check > 2016-08-26 15:19 ng0: Or maybe try one if the other fails? > 2016-08-26 15:19 yes.. very often I had to replace check with just > test > 2016-08-26 15:21 It might be worth bringing up on the > guix-devel mailing list to see what others think. > 2016-08-26 15:21 yes.. I will do so later >=20 > What do others think? How can we extend gnu-build-system so that make > test can be used but make check is not ignored? > --=20 > ng0 > For non-prism friendly talk find me on http://www.psyced.org >=20 I was curious how many times we use test-target: $ grep test-target gnu/packages/*scm | wc -l 87 $ grep test-target gnu/packages/*scm | grep \"test\" | wc -l 52 $ grep test-target gnu/packages/*scm | grep \"tests\" | wc -l 8 I guess the real question is, will running an extra `make test' after `make check' break anything? Also, I'm sure some of the makefiles have one as an alias of the other, we don't want to run the tests twice. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --7uYPyRQQ5N0D02nI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXwqlBAAoJEPTB05F+rO6TQL0QAIXbCJ0Dyf+cxDCV0hXbAz4G 3qXL38a/emcceKUHzDeG3hJ99+n2PzRJUTW9/c3BjcAeTm4XV64QJ6Dsc4gtZGA2 /nJK2u01MVrDkVivUfFVfktx5Zkw48jLCiLamd9o0Z1ergla2Jcr85mDSXqE9iAd VU2XrJAr4wgZZlpgg31HPMfThMVj42FdgUuM+lO8LAYgf0MbX2E6fq0Y2gA4LzhA H4A27+b7cJWtY/KWM9OpQ7mM78E+QCT+zsvWLJfbYg2z4xIvX+pPflgEtXBKpcZ5 E+JbH3ii3xU20zam2eYyVeVcPt87Lh10VF2aLpANis4o156J1qIuhpI6PO16CqpL 9rIoTW/7uXf9qNNHQHMchPAoRMxSBGNf9c4JAqhbxwH0U32vZmSIGOZfDry5nsQO 0COsqCoWT96+3TDnaEpnSNq7mcjRuYAhAOA8EJsAtWadoggQo3Tp7WGDVetQ9R/n sgHrQsPpRW/RtBVXEGyG4VggrbCB/NbKA5Omw1yFYk+FdH5D26BLglg4gSzkAqbS 2C5C5CMwFy8xXfKzqSt+lNlwzBGVVzlIJTo2KibFhdras+eTV1ztVFVMSFN5II6f uRVpOn097cH4vJU2NSVojHkBiqeJf30euhjk1tbFv0GUw0wTs1opiiH/Hp9qhPYd jYYBMb2lsgv9Y1zWYpVT =VU2T -----END PGP SIGNATURE----- --7uYPyRQQ5N0D02nI--