From: Eric Bavier <ericbavier@openmailbox.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] gnu: Add steghide.
Date: Tue, 23 Aug 2016 17:19:49 -0500 [thread overview]
Message-ID: <20160823171949.645525f2@openmailbox.org> (raw)
In-Reply-To: <20160823201611.GB22647@jasmine>
On Tue, 23 Aug 2016 16:16:11 -0400
Leo Famulari <leo@famulari.name> wrote:
> On Tue, Aug 23, 2016 at 01:15:10AM -0500, Eric Bavier wrote:
> > * gnu/packages/image.scm (steghide): New variable.
> > * gnu/packages/patches/steghide-fixes.patch: New patch.
> > * gnu/local.mk (dist_patch_DATA): Add it.
>
> > + (arguments
> > + `(#:make-flags '("CXXFLAGS=-fpermissive"))) ;required for MHashPP.cc
>
> My understanding is that '-fpermissive' downgrades some compiler errors
> to warnings. Is that correct?
Correct. Specifically, this is to avoid:
MHashPP.cc:123:38: error: invalid conversion from ‘uint8_t* {aka unsigned char*}’ to ‘char*’ [-fpermissive]
which I'm not comfortable developing a better fix for.
>
> > diff --git a/gnu/packages/patches/steghide-fixes.patch b/gnu/packages/patches/steghide-fixes.patch
>
> I don't understand what this patch does (I don't know any C++). Can you
> add some comments explaining it? Should we try to get the upstream
> maintainers to apply it?
This patch fixes an "undefined ULONG_MAX" error and "specializing
member ‘...’ requires ‘template<>’ syntax" errors.
Upstream appears to currently be in limbo, but I just sent the patch to
the mailing list.
`~Eric
next prev parent reply other threads:[~2016-08-23 22:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:15 [PATCH 1/4] gnu: Add mlocate Eric Bavier
2016-08-23 6:15 ` [PATCH 2/4] gnu: Add steghide Eric Bavier
2016-08-23 20:16 ` Leo Famulari
2016-08-23 22:19 ` Eric Bavier [this message]
2016-08-23 23:53 ` Leo Famulari
2016-08-23 6:15 ` [PATCH 3/4] gnu: Add Swish-e Eric Bavier
2016-08-23 6:27 ` Leo Famulari
2016-08-23 6:49 ` Eric Bavier
2016-08-23 20:46 ` Leo Famulari
2016-08-23 22:34 ` Eric Bavier
2016-08-23 6:15 ` [PATCH 4/4] gnu: Add Tomb Eric Bavier
2016-08-23 20:50 ` Leo Famulari
2016-08-23 22:41 ` Eric Bavier
2016-08-23 23:50 ` Leo Famulari
2016-08-23 20:12 ` [PATCH 1/4] gnu: Add mlocate Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823171949.645525f2@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).