From mboxrd@z Thu Jan  1 00:00:00 1970
From: gno <gnopap@gmail.com>
Subject: Re: [PATCH 1/7] gnu: lua: Build with support for dynamic libraries.
Date: Tue, 23 Aug 2016 02:02:40 +0200
Message-ID: <20160823020240.3304b5a4@gmail.com>
References: <20160822193918.27397-1-rekado@elephly.net>
	<20160822193918.27397-2-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gnopap@gmail.com>) id 1bbxIx-0003TN-AS
	for guix-devel@gnu.org; Mon, 22 Aug 2016 18:02:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gnopap@gmail.com>) id 1bbxIs-0006FX-7S
	for guix-devel@gnu.org; Mon, 22 Aug 2016 18:02:50 -0400
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gnopap@gmail.com>) id 1bbxIr-0006FS-Vr
	for guix-devel@gnu.org; Mon, 22 Aug 2016 18:02:46 -0400
Received: by mail-wm0-x244.google.com with SMTP id i5so15401906wmg.2
	for <guix-devel@gnu.org>; Mon, 22 Aug 2016 15:02:45 -0700 (PDT)
In-Reply-To: <20160822193918.27397-2-rekado@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: rekado@elephly.net, guix-devel@gnu.org

On Mon, 22 Aug 2016 21:39:12 +0200
Ricardo Wurmus <rekado@elephly.net> wrote:

> * gnu/packages/lua.scm (lua)[arguments]: Use regular build phase and
> add make-flags.
> ---
>  gnu/packages/lua.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
> index b4b5dee..52606f4 100644
> --- a/gnu/packages/lua.scm
> +++ b/gnu/packages/lua.scm
> @@ -4,6 +4,7 @@
>  ;;; Copyright =C2=A9 2014 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright =C2=A9 2014 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright =C2=A9 2016 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright =C2=A9 2016 Ricardo Wurmus <rekado@elephly.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,14 +45,15 @@
>      (inputs `(("readline" ,readline)))
>      (arguments
>       '(#:modules ((guix build gnu-build-system)
> -                    (guix build utils)
> -                    (srfi srfi-1))
> +                  (guix build utils)
> +                  (srfi srfi-1))
>         #:test-target "test"
> +       #:make-flags
> +       '("CFLAGS=3D-fPIC -DLUA_DL_DLOPEN -DLUA_USE_POSIX"
> +         "linux")
>         #:phases
>         (modify-phases %standard-phases
>           (delete 'configure)
> -         (replace 'build
> -           (lambda _ (zero? (system* "make" "CFLAGS=3D-fPIC"
> "linux")))) (replace 'install
>             (lambda* (#:key outputs #:allow-other-keys)
>               (let ((out (assoc-ref outputs "out")))


This doesn't work for me - lua-lgi still complains about lua not being
able to dynamically load. But this does work:

(replace 'build
  (lambda _ (zero? (system* "make"
     "LDFLAGS=3D-ldl" "CFLAGS=3D-fPIC -DLUA_USE_DLOPEN" "linux"))))

I tried adding LDFLAGS in #make-flags to no avail.