From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 0/7] Add Prosody
Date: Mon, 22 Aug 2016 16:03:27 -0400
Message-ID: <20160822200327.GC25668@jasmine>
References: <20160822193918.27397-1-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bbvRe-0001Tt-3f
	for guix-devel@gnu.org; Mon, 22 Aug 2016 16:03:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bbvRZ-0005BW-U2
	for guix-devel@gnu.org; Mon, 22 Aug 2016 16:03:41 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56528)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bbvRY-00057l-OG
	for guix-devel@gnu.org; Mon, 22 Aug 2016 16:03:37 -0400
Content-Disposition: inline
In-Reply-To: <20160822193918.27397-1-rekado@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

On Mon, Aug 22, 2016 at 09:39:11PM +0200, Ricardo Wurmus wrote:
> Hi Guix,
> 
> this patch series adds a package for the XMPP server Prosody.
> 
> The first patch is needed to allow Lua to load dynamic libraries via dlopen.
> 
> I'm not sure about the naming.  Prosody needs Lua 5.1, so I didn't even
> attempt to build the Lua packages for any later version.  The variable names
> all have a "lua5.1-" prefix, but the packages themselves don't; should they?

I'm not sure either; I think this is fine.

I found the commit messages a little confusing, especially the luasec
commit. It adds "luasec", but there is no package name or variable
called "luasec". I know that the upstream package name is "LuaSec". A
very minor quibble...

> 
> ~~ Ricardo
> 
> Ricardo Wurmus (7):
>   gnu: lua: Build with support for dynamic libraries.
>   gnu: lua: Use "license:" prefix.
>   gnu: Add lua5.1-expat.
>   gnu: Add lua5.1-socket.
>   gnu: Add lua5.1-filesystem.
>   gnu: Add luasec.
>   gnu: Add prosody.
> 
>  gnu/packages/lua.scm       | 168 ++++++++++++++++++++++++++++++++++++++++++---
>  gnu/packages/messaging.scm |  78 ++++++++++++++++++++-
>  2 files changed, 236 insertions(+), 10 deletions(-)
> 
> -- 
> 2.9.2
> 
> 
>