From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.
Date: Fri, 19 Aug 2016 17:46:38 -0400
Message-ID: <20160819214638.em6gtk7bv3ea4l3n@jasmine>
References: <20160816212809.21436-1-dannym@scratchpost.org>
	<20160816214145.GA29029@jasmine> <87lgzvqlio.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46478)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1barcv-0003H6-2K
	for guix-devel@gnu.org; Fri, 19 Aug 2016 17:46:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1barcq-000757-NJ
	for guix-devel@gnu.org; Fri, 19 Aug 2016 17:46:55 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34469)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1barcp-00074v-DO
	for guix-devel@gnu.org; Fri, 19 Aug 2016 17:46:52 -0400
Content-Disposition: inline
In-Reply-To: <87lgzvqlio.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

On Wed, Aug 17, 2016 at 09:48:47PM +0300, Alex Kost wrote:
> Leo Famulari (2016-08-17 00:41 +0300) wrote:
> 
> > On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote:
> >> gnu: Add python-lirc, python2-lirc.
> >> 
> >> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
> >
> > Thanks, applied as 231313f76!
> 
> Ahem, you both are fast: I was commenting on the first patch, and
> suddenly found that the third revision is already pushed :-)
> Anyway, some comments:

I pushed fixes for the indentation and the misleading file-name.

> > +    (description "@code{lirc} is a Python module which provides LIRC bindings.")
> 
> I don't think the description should begin with "@code{lirc}" as it is
> not LIRC itself but a python library for LIRC.

Not knowing what to replace this with, I left it alone.