From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add tintin.
Date: Fri, 19 Aug 2016 15:32:48 -0400
Message-ID: <20160819193248.GA18259@jasmine>
References: <87r39z81zo.fsf@we.make.ritual.n0.is>
	<8760rbot2y.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bapXS-0004A1-1i
	for guix-devel@gnu.org; Fri, 19 Aug 2016 15:33:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bapXO-0006QG-R1
	for guix-devel@gnu.org; Fri, 19 Aug 2016 15:33:09 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bapXN-0006Nd-Ho
	for guix-devel@gnu.org; Fri, 19 Aug 2016 15:33:06 -0400
Content-Disposition: inline
In-Reply-To: <8760rbot2y.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org

On Mon, Aug 08, 2016 at 09:21:09PM +0000, ng0 wrote:
> Updated patch.
> 
> * gnu/packages/games.scm (tintin): New variable.

Thanks!

> +              (uri (string-append "https://sourceforge.net/projects/tintin"
> +                                  "/files/TinTin++ Source Code/" version
> +                                  "/tintin" "-" version ".tar.gz"))

This URL does not work for me. Maybe you already had the tarball in your
/gnu/store? Also, it should use our SourceForge mirrors.

> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; The source is in tt/src.
> +         (add-before 'configure 'chdir-to-tt-src
> +           (lambda _
> +             (chdir "src"))))))

I would call this phase 'chdir'.

> +    (home-page "http://tintin.sourceforge.net/")

HTTPS, if possible.

Otherwise, looks good so far!