From: Leo Famulari <leo@famulari.name>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add tintin.
Date: Fri, 19 Aug 2016 15:32:48 -0400 [thread overview]
Message-ID: <20160819193248.GA18259@jasmine> (raw)
In-Reply-To: <8760rbot2y.fsf@we.make.ritual.n0.is>
On Mon, Aug 08, 2016 at 09:21:09PM +0000, ng0 wrote:
> Updated patch.
>
> * gnu/packages/games.scm (tintin): New variable.
Thanks!
> + (uri (string-append "https://sourceforge.net/projects/tintin"
> + "/files/TinTin++ Source Code/" version
> + "/tintin" "-" version ".tar.gz"))
This URL does not work for me. Maybe you already had the tarball in your
/gnu/store? Also, it should use our SourceForge mirrors.
> + #:phases
> + (modify-phases %standard-phases
> + ;; The source is in tt/src.
> + (add-before 'configure 'chdir-to-tt-src
> + (lambda _
> + (chdir "src"))))))
I would call this phase 'chdir'.
> + (home-page "http://tintin.sourceforge.net/")
HTTPS, if possible.
Otherwise, looks good so far!
next prev parent reply other threads:[~2016-08-19 19:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 20:00 [PATCH] Add tintin ng0
2016-08-08 20:12 ` ng0
2016-08-08 21:13 ` ng0
2016-08-08 21:21 ` ng0
2016-08-19 9:01 ` ng0
2016-08-19 9:21 ` David Craven
2016-08-19 9:38 ` ng0
2016-08-19 9:48 ` David Craven
2016-08-19 10:30 ` ng0
2016-08-19 11:25 ` David Craven
2016-08-19 11:50 ` Marius Bakke
2016-08-19 12:38 ` David Craven
2016-08-19 17:59 ` David Craven
2016-08-19 18:46 ` Marius Bakke
2016-08-19 19:15 ` Leo Famulari
2016-08-20 16:38 ` Alex Vong
2016-08-20 17:18 ` David Craven
2016-08-23 17:05 ` David Craven
2016-08-23 22:31 ` ng0
2016-08-23 23:00 ` David Craven
2016-08-24 8:35 ` Question about emacs and guix (was: Re: [PATCH] Add tintin) Alex Kost
2016-08-19 19:32 ` Leo Famulari [this message]
2016-08-19 20:40 ` [PATCH] Add tintin ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819193248.GA18259@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).