From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add re2.
Date: Thu, 18 Aug 2016 16:37:45 -0400 [thread overview]
Message-ID: <20160818203745.GC2393@jasmine> (raw)
In-Reply-To: <87r39nzntl.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
On Wed, Aug 17, 2016 at 11:34:14AM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
>
> > On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote:
> >>
> >> I wasn't sure where to put this, so went with its own file. It does not
> >> fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could
> >> be renamed to regex.scm or similar.
> >
> > The patch looks good, but please put it in regex.scm! But, I don't want
> > to move all the regex packages into this new regex module. Perhaps tre,
> > since it appears to have no users in our tree.
>
> Moved to regex.scm. Thanks!
Thanks, pushed as dc253bf0a5!
prev parent reply other threads:[~2016-08-18 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 13:05 [PATCH] gnu: Add re2 Marius Bakke
2016-08-16 17:59 ` Leo Famulari
2016-08-17 10:34 ` Marius Bakke
2016-08-17 15:18 ` Marius Bakke
2016-08-18 20:43 ` Leo Famulari
2016-08-19 7:35 ` Alex Kost
2016-08-19 22:49 ` Leo Famulari
2016-08-19 11:37 ` Marius Bakke
2016-08-19 12:33 ` Marius Bakke
2016-09-12 13:38 ` Alex Kost
2016-09-12 14:09 ` Marius Bakke
2016-09-13 7:44 ` Alex Kost
2016-08-18 20:37 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818203745.GC2393@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).