unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 07/24] gnu: compression: Add snappy.
Date: Wed, 17 Aug 2016 21:25:41 -0400	[thread overview]
Message-ID: <20160818012541.GA31426@jasmine> (raw)
In-Reply-To: <CAL1_immViabBTrr=e2DCYJQq+iV28mbVbdT5J5JHhEP+6u9M1A@mail.gmail.com>

On Wed, Aug 17, 2016 at 09:20:42PM +0200, David Craven wrote:
> Oh, that's embarrassing. I must have forgotten to change the hash and
> guix cached the tarball. Is that possible?

If the hash is matched in the store, the URL is not used, so you won't
see an incorrect URL fail to match the hash.

This is a common cause of buggy patches.

I wonder, are there any drawbacks of making the linter check that the
URL provides the data named by the hash?

  parent reply	other threads:[~2016-08-18  1:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17  8:30 [PATCH 07/24] gnu: compression: Add snappy David Craven
2016-08-17 19:02 ` Alex Kost
2016-08-17 19:20   ` David Craven
2016-08-17 19:27     ` David Craven
2016-08-18  7:21       ` Alex Kost
2016-08-18 12:41         ` David Craven
2016-08-18  1:25     ` Leo Famulari [this message]
2016-08-27 23:12       ` ‘guix lint’ URL checks Ludovic Courtès
2016-08-30 18:28         ` Leo Famulari
  -- strict thread matches above, loose matches on Subject: below --
2016-08-16 18:39 [PATCH 01/24] gnu: qt: Add qtquickcontrols David Craven
2016-08-16 18:39 ` [PATCH 07/24] gnu: compression: Add snappy David Craven
2016-08-16 19:45   ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160818012541.GA31426@jasmine \
    --to=leo@famulari.name \
    --cc=alezost@gmail.com \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).