From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/1] gnu: cracklib: Fix CVE-2016-6318.
Date: Wed, 17 Aug 2016 00:44:29 -0400
Message-ID: <20160817044429.qawlaeuly3hiwcod@jasmine>
References: <cover.1471401726.git.leo@famulari.name>
	<f93c796c4ec7b170a43e24b49730494ade59c4a8.1471401726.git.leo@famulari.name>
	<20160816232911.08c0835f@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZsia-0000Ob-RC
	for guix-devel@gnu.org; Wed, 17 Aug 2016 00:44:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZsiW-0001hs-LZ
	for guix-devel@gnu.org; Wed, 17 Aug 2016 00:44:43 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZsiV-0001hb-9H
	for guix-devel@gnu.org; Wed, 17 Aug 2016 00:44:40 -0400
Content-Disposition: inline
In-Reply-To: <20160816232911.08c0835f@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org

On Tue, Aug 16, 2016 at 11:29:11PM -0500, Eric Bavier wrote:
> On Tue, 16 Aug 2016 22:49:55 -0400
> Leo Famulari <leo@famulari.name> wrote:
> 
> > * gnu/packages/patches/cracklib-CVE-2016-6318.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Add it.
> > * gnu/packages/password-utils.scm (cracklib)[source]: Use the patch.
> > ---
> >  gnu/local.mk                                      |  1 +
> >  gnu/packages/password-utils.scm                   |  2 +
> >  gnu/packages/patches/cracklib-CVE-2016-6318.patch | 95 +++++++++++++++++++++++
> >  3 files changed, 98 insertions(+)
> >  create mode 100644 gnu/packages/patches/cracklib-CVE-2016-6318.patch
> 
> LGTM! Thanks for getting the patch so quick.

Thanks for the fast review! Pushed as 53dcbbec07c

> From the bug report it looks like we could get some real benefit from
> the hardening project thread you revived.

Yes, it does look like that!