From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v2] gnu: python: Add python-lirc.
Date: Tue, 16 Aug 2016 16:56:08 -0400 [thread overview]
Message-ID: <20160816205608.GB25753@jasmine> (raw)
In-Reply-To: <20160816202115.22554-1-dannym@scratchpost.org>
On Tue, Aug 16, 2016 at 10:21:15PM +0200, Danny Milosavljevic wrote:
> gnu: python: Add python-lirc.
>
> * gnu/packages/python.scm (python-lirc, python2-lirc): New variables.
Can you put it in the lirc module?
> +(define-public python-lirc
> + (let ((commit "4091fe918f3eed2513dad008828565cace408d2f"))
> + (package
> + (name "python-lirc")
> + (version (string-append "1.2.1-" (string-take commit 7)))
Please add a package revision counter as shown in the manual section
7.6.3 Version Numbers.
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers
LGTM with these changes.
By the way, I looked at the Git log and so I know that you have been
working on this software upstream. That's cool :) But, in general, when
sending patches, please give an explanation of why we should build from
a Git commit instead of the latest release tag. Because we are always
going to ask and it slows down the review process.
prev parent reply other threads:[~2016-08-16 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 20:21 [PATCH v2] gnu: python: Add python-lirc Danny Milosavljevic
2016-08-16 20:56 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816205608.GB25753@jasmine \
--to=leo@famulari.name \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).