unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-reportlab.
Date: Mon, 15 Aug 2016 20:36:31 -0400	[thread overview]
Message-ID: <20160816003631.GB16946@jasmine> (raw)
In-Reply-To: <87bn0ugmhv.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>

On Mon, Aug 15, 2016 at 03:01:00PM +0100, Marius Bakke wrote:
> 
> > From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
> > From: Marius Bakke <mbakke@fastmail.com>
> > Date: Sun, 14 Aug 2016 16:47:33 +0100
> > Subject: [PATCH] gnu: Add python-reportlab.
> >
> > * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
> >   variables.
> > ---
> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> 
> Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?

Looks good. I think pdf.scm is better. Can you send another patch?

> +     ;; Prevent creation of the egg. Without this flag, various artifacts
> +     ;; from the build inputs end up in the final python3 output. It also
> +     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
> +     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))

Feel free to add something to that discussion. We are starting a new
"core-updates" cycle, so it's a good time to begin implementing changes
to core components such as build systems.

  reply	other threads:[~2016-08-16  0:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 12:32 [PATCH] gnu: Add python-reportlab Marius Bakke
2016-08-15 14:01 ` Marius Bakke
2016-08-16  0:36   ` Leo Famulari [this message]
2016-08-16 10:57     ` Marius Bakke
2016-08-16 14:10       ` Marius Bakke
2016-08-16 18:37         ` Leo Famulari
2016-08-16 18:36       ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160816003631.GB16946@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).