From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: python: add pyserial.
Date: Mon, 15 Aug 2016 20:29:40 -0400
Message-ID: <20160816002940.GA16946@jasmine>
References: <20160815122501.2433-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZSGO-0004XP-Jo
	for guix-devel@gnu.org; Mon, 15 Aug 2016 20:29:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZSGJ-00086R-NT
	for guix-devel@gnu.org; Mon, 15 Aug 2016 20:29:52 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55438)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bZSGH-00083d-LP
	for guix-devel@gnu.org; Mon, 15 Aug 2016 20:29:47 -0400
Content-Disposition: inline
In-Reply-To: <20160815122501.2433-1-dannym@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Mon, Aug 15, 2016 at 02:25:01PM +0200, Danny Milosavljevic wrote:
> 
> * gnu/packages/python.scm (python-pyserial, python-pyserial2): New variables.

Thank for this package!

> +      (uri (string-append
> +             "https://pypi.python.org/packages/"
> +             "3c/d8/a9fa247ca60b02b3bebbd61766b4f321393b57b13c53b18f6f62cf172c08/"
> +             "pyserial-" version ".tar.gz"))

It's much shorter to use pypi-uri.

> +  (inputs
> +    `(("python-setuptools" ,python-setuptools)))

Was this left in from some previous version of the package? If so, it
should be removed, and you will need to add a (properties ...) field to
make the python2-variant system work for python2-pyserial. See the
package definition of python-pythondialog for an example.

> +  (license license:bsd-3)))

The "license:" prefix should be removed. The package can't be built with
it.

Can you send an updated patch?