From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python: add pyserial.
Date: Mon, 15 Aug 2016 20:29:40 -0400 [thread overview]
Message-ID: <20160816002940.GA16946@jasmine> (raw)
In-Reply-To: <20160815122501.2433-1-dannym@scratchpost.org>
On Mon, Aug 15, 2016 at 02:25:01PM +0200, Danny Milosavljevic wrote:
>
> * gnu/packages/python.scm (python-pyserial, python-pyserial2): New variables.
Thank for this package!
> + (uri (string-append
> + "https://pypi.python.org/packages/"
> + "3c/d8/a9fa247ca60b02b3bebbd61766b4f321393b57b13c53b18f6f62cf172c08/"
> + "pyserial-" version ".tar.gz"))
It's much shorter to use pypi-uri.
> + (inputs
> + `(("python-setuptools" ,python-setuptools)))
Was this left in from some previous version of the package? If so, it
should be removed, and you will need to add a (properties ...) field to
make the python2-variant system work for python2-pyserial. See the
package definition of python-pythondialog for an example.
> + (license license:bsd-3)))
The "license:" prefix should be removed. The package can't be built with
it.
Can you send an updated patch?
next prev parent reply other threads:[~2016-08-16 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 12:25 [PATCH] gnu: python: add pyserial Danny Milosavljevic
2016-08-16 0:29 ` Leo Famulari [this message]
2016-08-16 1:40 ` [PATCH v2] gnu: python: Add pyserial Danny Milosavljevic
2016-08-16 17:19 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816002940.GA16946@jasmine \
--to=leo@famulari.name \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).