From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add capnproto. Date: Sun, 14 Aug 2016 13:17:56 -0400 Message-ID: <20160814171756.GA27717@jasmine> References: <87ziog1p4r.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYz34-0001v5-Cn for guix-devel@gnu.org; Sun, 14 Aug 2016 13:18:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYz31-0004sj-4i for guix-devel@gnu.org; Sun, 14 Aug 2016 13:18:10 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYz2z-0004rP-VK for guix-devel@gnu.org; Sun, 14 Aug 2016 13:18:07 -0400 Content-Disposition: inline In-Reply-To: <87ziog1p4r.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org On Sat, Aug 13, 2016 at 07:48:36PM +0100, Marius Bakke wrote: > Note that it bundles googletest; I tried unbundling but it proved > difficult. gtest will no longer be used from the 0.6 release so I did > not think a comment was necessary. I am cc-ing Lukas with my reply, since he added our googletest package. Maybe he has some insight. > * gnu/packages/capnproto.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. How about putting it in serialization.scm? There is protobuf.scm, but that predates the serialization module. > + (snippet > + ;; Workaround for test that tries to resolve port name from > + ;; /etc/services, which is not present in build environment. > + '(substitute* "src/kj/async-io-test.c++" ((":http") ":80"))))) Origin snippets affect the result of `guix build --source`, and I think their use should be limited to fixing critical bugs or software freedom problems. This is working around a peculiarity of our build system, so I think we should do it in a build phase, with modify-phases. Can you send an updated patch? Otherwise it looks good. Let's wait a couple days to see if anyone has any advice about googletest.