From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 11/13] gnu: kde-frameworks: Add kpty.
Date: Sat, 13 Aug 2016 21:58:17 -0400
Message-ID: <20160814015817.GE17421@jasmine>
References: <20160813121931.20071-1-david@craven.ch>
	<20160813121931.20071-12-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYkh4-00031F-9w
	for guix-devel@gnu.org; Sat, 13 Aug 2016 21:58:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYkh1-0001v8-5I
	for guix-devel@gnu.org; Sat, 13 Aug 2016 21:58:30 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:39360)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYkgz-0001tl-VH
	for guix-devel@gnu.org; Sat, 13 Aug 2016 21:58:27 -0400
Content-Disposition: inline
In-Reply-To: <20160813121931.20071-12-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Aug 13, 2016 at 02:19:29PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (kpty): New variable.

> +    (arguments
> +     `(#:tests? #f ; FIXME: 1/1 tests fail.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-tests
> +         (lambda _
> +           (setenv "CTEST_OUTPUT_ON_FAILURE" "1")

Can you add a comment explaining why we set this variable? I'm guessing
it enables verbose output of failed tests?