unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Dylan Jeffers <sapientech@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-pypump
Date: Sat, 13 Aug 2016 19:07:14 -0400	[thread overview]
Message-ID: <20160813230714.GA22289@jasmine> (raw)
In-Reply-To: <20160813123242.6162b166@openmailbox.org>

On Sat, Aug 13, 2016 at 12:32:42PM -0700, Dylan Jeffers wrote:
> Thanks for getting back. Here is the series!

Cool, you showed me something new. I didn't know you could put the whole
series in a single attachment, apply it with `git am`, and have the
patch ordering handled automatically. Very nice :)

> Subject: [PATCH 1/2] gnu: Add python-requests-oauthlib
> 
> * gnu/packages/python.scm (python-requests-oauthlib,
> * python2-requests-oauthlib): New variables.

Somewhere in the re-creation of the patch series, this line was
forgotten:

+  #:use-module (gnu packages openstack)

I put it back in on my local branch.

> * gnu/packages/python.scm (python-pypump, python2-pypump): New
> * variables.

How about putting this in gnu/packages/pumpio.scm? Seems appropriate to
me :)

> +(define-public python-pypump
> +  (package
> +    (name "python-pypump")
> +    (version "0.6")

The latest upstream version 0.7. Is there a reason not to use the latest
version in this case?

https://pypi.python.org/pypi/PyPump/

  reply	other threads:[~2016-08-13 23:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-13  1:31 [PATCH] gnu: Add python-pypump Dylan Jeffers
2016-08-13 12:57 ` Leo Famulari
2016-08-13 19:32   ` Dylan Jeffers
2016-08-13 23:07     ` Leo Famulari [this message]
2016-08-14 23:07       ` Dylan Jeffers
2016-08-15 18:41         ` Leo Famulari
2016-08-15 22:17           ` Dylan Jeffers
2016-08-19 22:17             ` Leo Famulari
2016-09-05  9:21               ` Efraim Flashner
2016-08-15 22:29           ` Danny Milosavljevic
2016-08-15 22:41             ` Leo Famulari
2016-08-16 18:02             ` Leo Famulari
  -- strict thread matches above, loose matches on Subject: below --
2017-01-09 10:03 [PATCH 0/9] Add more qtmodules Efraim Flashner
2017-01-09 10:03 ` [PATCH] gnu: Add python-pypump Efraim Flashner
2017-01-09 11:03   ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160813230714.GA22289@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=sapientech@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).