From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 1/5] gnu: gtk+: Add "bin" output. Date: Sat, 13 Aug 2016 21:51:07 -0500 Message-ID: <20160813215107.70e34fb5@openmailbox.org> References: <20160806104616.13089-1-iyzsong@gmail.com> <20160814022153.GC28609@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYlWA-0004Ip-Dh for guix-devel@gnu.org; Sat, 13 Aug 2016 22:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYlW6-0002Gc-7r for guix-devel@gnu.org; Sat, 13 Aug 2016 22:51:17 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:59004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYlW6-0002GO-1V for guix-devel@gnu.org; Sat, 13 Aug 2016 22:51:14 -0400 In-Reply-To: <20160814022153.GC28609@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= On Sat, 13 Aug 2016 22:21:53 -0400 Leo Famulari wrote: > On Sat, Aug 06, 2016 at 06:46:12PM +0800, =E5=AE=8B=E6=96=87=E6=AD=A6 wro= te: > > * gnu/packages/gtk.scm (gtk+)[outputs]: New field. > > --- > > gnu/packages/gtk.scm | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > > index 21365b9..5c42053 100644 > > --- a/gnu/packages/gtk.scm > > +++ b/gnu/packages/gtk.scm > > @@ -624,6 +624,7 @@ application suites.") > > (base32 > > "157nh9gg0p2avw765hrnkvr8lsh2w811397yxgjv6q5j4fzz6d1q")) > > (patches (search-patches "gtk3-respect-GUIX_GTK3_PATH.patc= h")))) > > + (outputs '("out" "bin" "doc")) > > (propagated-inputs > > `(("at-spi2-atk" ,at-spi2-atk) > > ("atk" ,atk) =20 >=20 > What effect does this have? >=20 > Does Guix know to put something into the 'bin' output? Yes, the gnu-build-system will automatically pass '--bindir' to 'configure' if a "bin" output is present. However, should these outputs not instead be added to the 'gtk+-2' package that 'gtk+' inherits from? `~Eric