unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-stem.
Date: Fri, 12 Aug 2016 13:56:42 -0400	[thread overview]
Message-ID: <20160812175642.GA10275@jasmine> (raw)
In-Reply-To: <87eg5vtgpw.fsf@we.make.ritual.n0.is>

On Thu, Aug 11, 2016 at 04:26:03PM +0000, ng0 wrote:
> From d6a5487d361eb667448871c42c96d9007a264214 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Thu, 11 Aug 2016 13:42:22 +0000
> Subject: [PATCH] gnu: Add python-stem.
> 
> * gnu/packages/python.scm (python-stem): New variable.
> * gnu/packages/python.scm (python2-stem): New variable.

Thank you for these patches!

Setuptools was not used, so I removed it.

I changed 'alist-replace' to 'modify-phases'.

I added some dependencies that were missing. The tests passed without
them, but they did print some warnings.

I shortened the synopsis to satisfy `guix lint`.

I also squashed the two patches into one. That is our convention when
adding Python 2 and 3 versions of packages.

I pushed the result as b227f0be89.

  reply	other threads:[~2016-08-12 17:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 14:11 [PATCH] gnu: Add python-stem ng0
2016-08-11 16:12 ` ng0
2016-08-11 16:26 ` ng0
2016-08-12 17:56   ` Leo Famulari [this message]
2016-08-12 18:52     ` ng0
2016-08-12 22:47       ` Leo Famulari
2016-08-13  7:02         ` ng0
2016-08-13 12:57           ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160812175642.GA10275@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=ng0@we.make.ritual.n0.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).