From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH v5 04/17] gnu: Add perl-net-dns-resolver-programmable. Date: Mon, 8 Aug 2016 23:08:20 +0200 Message-ID: <20160808230820.5ec368de@scratchpost.org> References: <20160728213833.22057-1-dannym@scratchpost.org> <20160728213833.22057-5-dannym@scratchpost.org> <20160808194115.GA18650@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWrmj-0007Go-Ia for guix-devel@gnu.org; Mon, 08 Aug 2016 17:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWrme-0006dO-5P for guix-devel@gnu.org; Mon, 08 Aug 2016 17:08:33 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:55837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWrmd-0006c6-Uo for guix-devel@gnu.org; Mon, 08 Aug 2016 17:08:28 -0400 In-Reply-To: <20160808194115.GA18650@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Hi Leo, > Can you send a comment explaining why we have to apply this patch? Its > URL does not enable me to "go back" to the relevant discussion and learn > the context or identity of the author. Mail-SPF uses a programmable (mock) DNS server to run its tests. That's what Net-DNS-Resolver-Programmable is supposed to do. Unfortunately it doesn't work without the patch. It said: > t/00.04-class-server.t test fails: [...] ok 19 - Server "A" dns_lookup() answer RR type Unknown error on DNS 'A' lookup of 'example.com' (EDNSError) at /home/test/fedora/perl-Mail-SPF/Mail-SPF-v2.9.0/blib/lib/Mail/SPF/Server.pm line 573. # Looks like you planned 23 tests but ran 19. # Looks like your test exited with 255 just after 19. That's because it was using an undocumented internal method of Net::DNS which is not exposed anymore. The patch makes the call of the undefined method contigent upon it existing. That way, the DNS resolver will actually work. See also .