From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 06/12] gnu: python: Add python-pymongo.
Date: Mon, 8 Aug 2016 16:36:02 -0400
Message-ID: <20160808203602.GA21736@jasmine>
References: <20160805183730.19049-2-david@craven.ch>
	<20160805183730.19049-6-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWrHR-0003Ui-29
	for guix-devel@gnu.org; Mon, 08 Aug 2016 16:36:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWrHM-0007n6-Qp
	for guix-devel@gnu.org; Mon, 08 Aug 2016 16:36:11 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59283)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWrHL-0007mM-HD
	for guix-devel@gnu.org; Mon, 08 Aug 2016 16:36:08 -0400
Content-Disposition: inline
In-Reply-To: <20160805183730.19049-6-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Fri, Aug 05, 2016 at 08:37:24PM +0200, David Craven wrote:
> * gnu/packages/python.scm (python-pymongo): New package.
>   (python2-pymongo): New package.

s/package/variable

> +    (inputs
> +     `(("python-certifi" ,python-certifi)
> +       ("python-setuptools" ,python-setuptools)))

I notice several of these patches include setuptools as an input to the
Python 3 variant of the package.

While some Python 3 packages require setuptools, most don't, whereas
most Python 2 packages do require setuptools.

We have a "python2-variant" system that we use when the Python 2 version
of some package requires a different set of inputs from the Python 3
version that it is based on. There is a good example in python-lockfile
/ python2-lockfile.

It adds a few lines of code but if we use it consistently, it will
drastically reduce the number of packages that depend on
python-setuptools.

Can you check this patch series to see if the Python 3 variants require
setuptools?