From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add p7zip. Date: Mon, 8 Aug 2016 15:58:35 -0400 Message-ID: <20160808195835.GF18650@jasmine> References: <87a8gwxa9c.fsf@openmailbox.org> <87y44f4plm.fsf@mdc-berlin.de> <20ae08af155acdc7edd02b68afb9e66d@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWqhN-0003n0-Cx for guix-devel@gnu.org; Mon, 08 Aug 2016 15:58:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWqhL-0007yk-Gy for guix-devel@gnu.org; Mon, 08 Aug 2016 15:58:56 -0400 Content-Disposition: inline In-Reply-To: <20ae08af155acdc7edd02b68afb9e66d@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org, Guix-devel On Tue, Aug 02, 2016 at 01:38:17PM -0500, Eric Bavier wrote: > On 2016-08-02 02:06, Ricardo Wurmus wrote: > > Hi Kei, > > > > > This patch should install p7zip correctly on every architecture > > > supported by Guix. Ideally, this should be tested it on each arch for > > > the sake of completeness and safety. I've got x86_64 covered so far. > > > :-) > > > > thank you for this patch! > > > > I see that you took care of removing non-free parts in a patch and a > > build phase. Since “guix build -S p7zip” doesn’t run the build phase > > users would still end up with a source archive containing the non-free > > parts. The best way is thus to remove things in a snippet. > > > > In “shogun” from the “machine-learning” module we remove supporting code > > for non-free features in a snippet by cutting out anything between some > > ifdef markers, but looking at the patch I see that it wouldn’t be > > feasible for p7zip. > > Also note that it is not completely desirable for nonfree code to be removed > with a patch, and is one of the reasons Guix supports snippets in the first > place. Is there a reason to not use a patch in this case? Or can we proceed with packaging p7zip, using a patch to remove non-free parts?