From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v5 14/17] gnu: Add perl-crypt-openssl-bignum.
Date: Mon, 8 Aug 2016 15:54:19 -0400
Message-ID: <20160808195419.GD18650@jasmine>
References: <20160728213833.22057-1-dannym@scratchpost.org>
	<20160728213833.22057-15-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWqd8-0001fE-Nm
	for guix-devel@gnu.org; Mon, 08 Aug 2016 15:54:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWqd4-0006ny-Ll
	for guix-devel@gnu.org; Mon, 08 Aug 2016 15:54:33 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44741)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWqd3-0006l9-FQ
	for guix-devel@gnu.org; Mon, 08 Aug 2016 15:54:30 -0400
Content-Disposition: inline
In-Reply-To: <20160728213833.22057-15-dannym@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Thu, Jul 28, 2016 at 11:38:30PM +0200, Danny Milosavljevic wrote:
> 
> gnu: Add perl-crypt-openssl-bignum.
> 
> * gnu/packages/tls.scm (perl-crypt-openssl-bignum, perl-crypt-openssl-arguments): New variables.
> ---
>  gnu/packages/tls.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 

> diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
> index d992c51..fba130b 100644
> --- a/gnu/packages/tls.scm
> +++ b/gnu/packages/tls.scm
> @@ -556,3 +556,39 @@ servers or clients for more complicated applications.")
>      "RSA encoding and decoding, using the openSSL libraries")
>    (description "Crypt::OpenSSL::RSA does RSA encoding and decoding (using the OpenSSL libraries).")
>    (license (package-license perl))))
> +
> +(define perl-crypt-arguments
> +   `(#:phases (modify-phases %standard-phases
> +      (add-before 'configure 'patch-Makefile.PL
> +        (lambda* (#:key inputs #:allow-other-keys)
> +          (substitute* "Makefile.PL"
> +            (("'LIBS'.*=>.*") (string-append "'LIBS' => ['-L"
> +                                             (assoc-ref inputs "openssl")
> +                                             "/lib -lcrypto'],")))
> +          #t)))))

I see this variable is also used in perl-crypt-openssl-random. I don't
have a very strong sense of Scheme style yet, but so far I've seen
things like this duplicated between package definitions. I think it's
better to reduce the proliferation of non-package variables in
gnu/packages...  what do you think?

I can amend the patches if you agree.