From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v5 14/17] gnu: Add perl-crypt-openssl-bignum.
Date: Mon, 8 Aug 2016 15:54:19 -0400 [thread overview]
Message-ID: <20160808195419.GD18650@jasmine> (raw)
In-Reply-To: <20160728213833.22057-15-dannym@scratchpost.org>
On Thu, Jul 28, 2016 at 11:38:30PM +0200, Danny Milosavljevic wrote:
>
> gnu: Add perl-crypt-openssl-bignum.
>
> * gnu/packages/tls.scm (perl-crypt-openssl-bignum, perl-crypt-openssl-arguments): New variables.
> ---
> gnu/packages/tls.scm | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
> index d992c51..fba130b 100644
> --- a/gnu/packages/tls.scm
> +++ b/gnu/packages/tls.scm
> @@ -556,3 +556,39 @@ servers or clients for more complicated applications.")
> "RSA encoding and decoding, using the openSSL libraries")
> (description "Crypt::OpenSSL::RSA does RSA encoding and decoding (using the OpenSSL libraries).")
> (license (package-license perl))))
> +
> +(define perl-crypt-arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'patch-Makefile.PL
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "Makefile.PL"
> + (("'LIBS'.*=>.*") (string-append "'LIBS' => ['-L"
> + (assoc-ref inputs "openssl")
> + "/lib -lcrypto'],")))
> + #t)))))
I see this variable is also used in perl-crypt-openssl-random. I don't
have a very strong sense of Scheme style yet, but so far I've seen
things like this duplicated between package definitions. I think it's
better to reduce the proliferation of non-package variables in
gnu/packages... what do you think?
I can amend the patches if you agree.
next prev parent reply other threads:[~2016-08-08 19:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 21:38 [PATCH v5 00/17] Add missing dependencies of Spamassassin Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 01/17] gnu: Add perl-db-file Danny Milosavljevic
2016-07-31 11:39 ` Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 02/17] gnu: Add perl-net-dns Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 03/17] gnu: Add perl-socket6 Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 04/17] gnu: Add perl-net-dns-resolver-programmable Danny Milosavljevic
2016-08-08 19:41 ` Leo Famulari
2016-08-08 21:08 ` Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 05/17] gnu: Add perl-netaddr-ip Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 06/17] gnu: Add perl-net-patricia Danny Milosavljevic
2016-08-08 19:44 ` Leo Famulari
2016-08-08 21:09 ` Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 07/17] gnu: Add perl-file-find-object Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 08/17] gnu: Add perl-file-find-object-rule Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 09/17] gnu: Add perl-test-trailingspace Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 10/17] gnu: Add perl-encode-detect Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 11/17] gnu: Add perl-net-cidr-lite Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 12/17] gnu: Add perl-geo-ip Danny Milosavljevic
2016-08-08 19:46 ` Leo Famulari
2016-08-08 22:50 ` Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 13/17] gnu: Add perl-crypt-openssl-rsa Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 14/17] gnu: Add perl-crypt-openssl-bignum Danny Milosavljevic
2016-08-08 19:54 ` Leo Famulari [this message]
2016-08-08 21:18 ` Danny Milosavljevic
2016-08-09 1:06 ` Leo Famulari
2016-07-28 21:38 ` [PATCH v5 15/17] gnu: Add perl-mail-spf Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 16/17] gnu: Add perl-io-socket-inet6 Danny Milosavljevic
2016-07-28 21:38 ` [PATCH v5 17/17] gnu: Add perl-crypt-openssl-random Danny Milosavljevic
2016-08-08 19:54 ` [PATCH v5 00/17] Add missing dependencies of Spamassassin Leo Famulari
2016-08-09 2:38 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808195419.GD18650@jasmine \
--to=leo@famulari.name \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).