From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: bash-completion: Update to 2.3.
Date: Fri, 5 Aug 2016 20:53:46 +0200
Message-ID: <20160805185346.GA1227@solar>
References: <20160803085311.24325-1-sleep_walker@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bVkFq-0007SV-Ir
	for guix-devel@gnu.org; Fri, 05 Aug 2016 14:53:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bVkFl-0003ux-IH
	for guix-devel@gnu.org; Fri, 05 Aug 2016 14:53:57 -0400
Received: from mailrelay6.public.one.com ([91.198.169.200]:10480)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bVkFk-0003tX-V1
	for guix-devel@gnu.org; Fri, 05 Aug 2016 14:53:53 -0400
Content-Disposition: inline
In-Reply-To: <20160803085311.24325-1-sleep_walker@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org

Hello,

On Wed, Aug 03, 2016 at 10:53:11AM +0200, Tomáš Čech wrote:
> * gnu/packages/bash.scm(bash-completion): Update to 2.3, add autoreconf
>   phase, change origin to Github.
> * gnu/packages/patches/bash-completion-directories.patch: Rework - same
>   purpose, different code.

just the quick standard comment: Please do the switch from alist-...
to modify-phases in a separate first commit; it makes it easier to see
the real diff of your real commit.

The autoreconf phase is strange. Why is it suddenly needed? If there is no
way around it, you should at least add a comment.

Andreas