From: Andreas Enge <andreas@enge.fr>
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: bash-completion: Update to 2.3.
Date: Fri, 5 Aug 2016 20:53:46 +0200 [thread overview]
Message-ID: <20160805185346.GA1227@solar> (raw)
In-Reply-To: <20160803085311.24325-1-sleep_walker@gnu.org>
Hello,
On Wed, Aug 03, 2016 at 10:53:11AM +0200, Tomáš Čech wrote:
> * gnu/packages/bash.scm(bash-completion): Update to 2.3, add autoreconf
> phase, change origin to Github.
> * gnu/packages/patches/bash-completion-directories.patch: Rework - same
> purpose, different code.
just the quick standard comment: Please do the switch from alist-...
to modify-phases in a separate first commit; it makes it easier to see
the real diff of your real commit.
The autoreconf phase is strange. Why is it suddenly needed? If there is no
way around it, you should at least add a comment.
Andreas
next prev parent reply other threads:[~2016-08-05 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 8:53 [PATCH] gnu: bash-completion: Update to 2.3 Tomáš Čech
2016-08-05 18:53 ` Andreas Enge [this message]
2016-08-07 3:06 ` Leo Famulari
2016-08-07 8:06 ` Tomáš Čech
2016-08-07 10:07 ` [PATCHv2 1/2] gnu: bash-completion: Modify to modify-phases Tomáš Čech
2016-08-07 10:07 ` [PATCHv2 2/2] gnu: bash-completion: Update to 2.3. Update the patch Tomáš Čech
2016-08-08 21:14 ` Leo Famulari
2016-08-09 9:05 ` Tomáš Čech
2016-08-08 21:10 ` [PATCHv2 1/2] gnu: bash-completion: Modify to modify-phases Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805185346.GA1227@solar \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=sleep_walker@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).