From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: tuxguitar: Update to 1.3.2.
Date: Thu, 4 Aug 2016 10:43:41 +0200
Message-ID: <20160804084341.GA1715@solar>
References: <20160803164503.10103-1-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bVEFr-0007re-1I
	for guix-devel@gnu.org; Thu, 04 Aug 2016 04:43:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bVEFm-0000hT-2S
	for guix-devel@gnu.org; Thu, 04 Aug 2016 04:43:50 -0400
Received: from mailrelay7.public.one.com ([91.198.169.215]:14983)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bVEFl-0000hE-Ko
	for guix-devel@gnu.org; Thu, 04 Aug 2016 04:43:45 -0400
Content-Disposition: inline
In-Reply-To: <20160803164503.10103-1-rekado@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Hello,

On Wed, Aug 03, 2016 at 06:45:03PM +0200, Ricardo Wurmus wrote:
> * gnu/packages/music.scm (tuxguitar): Update to 1.3.2.
> [arguments]: Use ant-build-system and rearrange build phases.
> [native-inputs]: Remove field.

looks good!

> +         (add-after 'unpack 'enter-dir-and-set-flags
> +           (lambda _ (chdir "TuxGuitar-lib") #t))

The name of the phase seems to be inherited from a previous edition where
flags were set.

> +               ;; create wrapper
> +               (call-with-output-file (string-append bin "/tuxguitar")
> +                 (lambda (port)
> +                   (let ((classpath (string-join (append (find-files lib "\\.jar$")
> +                                                         (find-files swt "\\.jar$"))
> +                                                 ":")))
> +                     (format
> +                      port
> +                      (string-append "#!/bin/sh\n"
> +                                     (which "java")
> +                                     " -cp " classpath
> +                                     " -Dtuxguitar.home.path=" out
> +                                     " -Dtuxguitar.share.path=" out "/share"
> +                                     " -Dswt.library.path=" swt "/lib"
> +                                     " org.herac.tuxguitar.app.TGMainSingleton"
> +                                     " \"$1\" \"$2\"")))))
> +               (chmod (string-append bin "/tuxguitar") #o555)
> +               #t))))))

This one I do not fully understand; my first impression was that it used
the file names from the build directory for the classpath variable. But this
is working since they are relative file names? And the "-D" parameters make
that they are searched for in the correct directories? Should these be
replaced by absolute file names (which might end up being too long)?

Andreas