From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.
Date: Tue, 2 Aug 2016 14:15:52 +0200
Message-ID: <20160802121552.GA26550@solar>
References: <20160801181342.16203-1-david@craven.ch>
	<20160801181342.16203-9-david@craven.ch>
	<20160801195700.GD6728@solar>
	<CAL1_imkVf_BKQ1-rdNnzZDAZ46LZyNBB9dg32E1iViySe4rNYA@mail.gmail.com>
	<20160801211739.GA6958@solar>
	<CAL1_im=TRrOifGKjyVhipksVabcz5iGegDpPvEq-e1wS6gzJFw@mail.gmail.com>
	<CAL1_im=0x1=4hVHT_WxGxCpBsV+tk=1hKhd2pHgJzS8BDD3JZw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bUYc7-0007Hc-2L
	for guix-devel@gnu.org; Tue, 02 Aug 2016 08:16:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bUYc1-0004ax-TK
	for guix-devel@gnu.org; Tue, 02 Aug 2016 08:16:01 -0400
Received: from mailrelay2.public.one.com ([91.198.169.125]:49448)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bUYc1-0004ad-Ba
	for guix-devel@gnu.org; Tue, 02 Aug 2016 08:15:57 -0400
Content-Disposition: inline
In-Reply-To: <CAL1_im=0x1=4hVHT_WxGxCpBsV+tk=1hKhd2pHgJzS8BDD3JZw@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>

On Tue, Aug 02, 2016 at 01:57:25PM +0200, David Craven wrote:
> What do you want me to do? not that I make things worse... This is
> what I pushed.
> 
>     gnu: kde-frameworks: Remove kde-frameworks-version.
>     * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
>       (kwindowsystem)[version]: Replace kde-frameworks-version with
> version string.
>       (oxygen-icons)[version]: Replace kde-frameworks-version with
> version string.
> -    (version kde-frameworks-version)
> +    (version "5.24.0")

Oh well... The absolutely correct fix would be to revert this commit and to
replace it by two separate ones. But honestly, I would just do nothing :-)
This is work in progress anyway, nobody can currently use the packages,
so they have just been silently updated.

Andreas

PS: I will commit my qtbase fix tomorrow after the release unless there are
    comments.