unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.
Date: Tue, 2 Aug 2016 14:15:52 +0200	[thread overview]
Message-ID: <20160802121552.GA26550@solar> (raw)
In-Reply-To: <CAL1_im=0x1=4hVHT_WxGxCpBsV+tk=1hKhd2pHgJzS8BDD3JZw@mail.gmail.com>

On Tue, Aug 02, 2016 at 01:57:25PM +0200, David Craven wrote:
> What do you want me to do? not that I make things worse... This is
> what I pushed.
> 
>     gnu: kde-frameworks: Remove kde-frameworks-version.
>     * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
>       (kwindowsystem)[version]: Replace kde-frameworks-version with
> version string.
>       (oxygen-icons)[version]: Replace kde-frameworks-version with
> version string.
> -    (version kde-frameworks-version)
> +    (version "5.24.0")

Oh well... The absolutely correct fix would be to revert this commit and to
replace it by two separate ones. But honestly, I would just do nothing :-)
This is work in progress anyway, nobody can currently use the packages,
so they have just been silently updated.

Andreas

PS: I will commit my qtbase fix tomorrow after the release unless there are
    comments.

  reply	other threads:[~2016-08-02 12:16 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 18:13 [PATCH 00/31] KDE Framework Tier1 Packages David Craven
2016-08-01 18:13 ` [PATCH 01/31] gnu: network-manager: Propagate GLIB David Craven
2016-08-01 19:48   ` Andreas Enge
2016-08-01 19:56     ` David Craven
2016-08-01 21:16       ` Andreas Enge
2016-08-01 18:13 ` [PATCH 02/31] download: Add KDE mirrors David Craven
2016-08-01 19:54   ` Andreas Enge
2016-08-02  9:55     ` Ludovic Courtès
2016-08-02 10:08       ` David Craven
2016-08-02 15:47         ` Leo Famulari
2016-08-02 15:52           ` David Craven
2016-08-02 16:27             ` Leo Famulari
2016-08-02 16:40               ` David Craven
2016-08-02 16:54                 ` David Craven
2016-08-01 18:13 ` [PATCH 03/31] gnu-maintenance: Add KDE updater David Craven
2016-08-02 10:02   ` Ludovic Courtès
2016-08-02 10:41     ` Andreas Enge
2016-08-02 12:42       ` Ludovic Courtès
2016-08-01 18:13 ` [PATCH 04/31] lint: 'inputs-should-be-native' checks for extra-cmake-modules and qttools David Craven
2016-08-01 21:22   ` Ludovic Courtès
2016-08-01 18:13 ` [PATCH 05/31] gnu: extra-cmake-modules: Update to 5.24.0 David Craven
2016-08-01 20:19   ` Andreas Enge
2016-08-01 18:13 ` [PATCH 06/31] gnu: kwindowsystem: " David Craven
2016-08-01 21:10   ` Andreas Enge
2016-08-01 22:17     ` Andreas Enge
2016-08-01 22:21       ` David Craven
2016-08-01 22:28         ` David Craven
2016-08-01 22:51           ` David Craven
2016-08-02 17:36             ` David Craven
2016-08-02 21:31               ` Ludovic Courtès
2016-08-03 14:08                 ` David Craven
2016-08-05 14:36                   ` David Craven
2016-08-05 18:21                     ` Andreas Enge
2016-08-05 18:23                     ` Andreas Enge
2016-08-05 19:38                   ` Andreas Enge
2016-08-05 19:51                     ` David Craven
2016-08-01 18:13 ` [PATCH 07/31] gnu: oxygen-icons: " David Craven
2016-08-01 18:13 ` [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version David Craven
2016-08-01 19:57   ` Andreas Enge
2016-08-01 20:00     ` David Craven
2016-08-01 21:17       ` Andreas Enge
2016-08-02 11:55         ` David Craven
2016-08-02 11:57           ` David Craven
2016-08-02 12:15             ` Andreas Enge [this message]
2016-08-02 12:44             ` Ludovic Courtès
2016-08-02 12:50               ` David Craven
2016-08-01 19:58   ` Andreas Enge
2016-08-02 12:33   ` Ludovic Courtès
2016-08-01 18:13 ` [PATCH 09/31] gnu: kde-frameworks: Add attica David Craven
2016-08-01 18:13 ` [PATCH 10/31] gnu: kde-frameworks: Add bluez-qt David Craven
2016-08-01 18:13 ` [PATCH 11/31] gnu: kde-frameworks: Add breeze-icons David Craven
2016-08-01 18:13 ` [PATCH 12/31] gnu: kde-frameworks: Add kapidox David Craven
2016-08-01 18:13 ` [PATCH 13/31] gnu: kde-frameworks: Add karchive David Craven
2016-08-01 18:13 ` [PATCH 14/31] gnu: kde-frameworks: Add kcodecs David Craven
2016-08-01 18:13 ` [PATCH 15/31] gnu: kde-frameworks: Add kconfig David Craven
2016-08-01 18:13 ` [PATCH 16/31] gnu: kde-frameworks: Add kcoreaddons David Craven
2016-08-01 18:13 ` [PATCH 17/31] gnu: kde-frameworks: Add kdbusaddons David Craven
2016-08-01 18:13 ` [PATCH 18/31] gnu: kde-frameworks: Add kdnssd David Craven
2016-08-01 18:13 ` [PATCH 19/31] gnu: kde-frameworks: Add kguiaddons David Craven
2016-08-01 18:13 ` [PATCH 20/31] gnu: kde-frameworks: Add ki18n David Craven
2016-08-01 18:13 ` [PATCH 21/31] gnu: kde-frameworks: Add kidletime David Craven
2016-08-01 18:13 ` [PATCH 22/31] gnu: kde-frameworks: Add kitemmodels David Craven
2016-08-01 18:13 ` [PATCH 23/31] gnu: kde-frameworks: Add kitemviews David Craven
2016-08-01 18:13 ` [PATCH 24/31] gnu: kde-frameworks: Add kplotting David Craven
2016-08-01 18:13 ` [PATCH 25/31] gnu: kde-frameworks: Add kwayland David Craven
2016-08-01 18:13 ` [PATCH 26/31] gnu: kde-frameworks: Add kwidgetsaddons David Craven
2016-08-01 18:13 ` [PATCH 27/31] gnu: kde-frameworks: Add modemmanager-qt David Craven
2016-08-01 18:13 ` [PATCH 28/31] gnu: kde-frameworks: Add networkmanager-qt David Craven
2016-08-01 18:13 ` [PATCH 29/31] gnu: kde-frameworks: Add solid David Craven
2016-08-01 18:13 ` [PATCH 30/31] gnu: kde-frameworks: Add sonnet David Craven
2016-08-01 18:13 ` [PATCH 31/31] gnu: kde-frameworks: Add threadweaver David Craven
2016-08-01 19:44 ` [PATCH 00/31] KDE Framework Tier1 Packages Andreas Enge
2016-08-01 21:21 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802121552.GA26550@solar \
    --to=andreas@enge.fr \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).