[PATCH 00/31] KDE Framework Tier1 Packages

[PATCH 00/31] KDE Framework Tier1 Packages

[David Craven]

* ki18n: qtdeclarative isn't found.
* kidletime: qtx11extras isn't found.
* kwidgetsaddons: qttools isn't found.
* kwindowsystem: qtx11extras isn't found.

Then there are multiple test failures affecting the following packages:
* extra-cmake-modules: All tests pass, but install fails after running tests.
* bluez-qt: Tests freeze.
* kconfig: 28/34 tests fail.
* kcoreaddons: 4/23 tests fail.
* kdbusaddons: Tests freeze.
* kguiaddons: Tests fail only when run by guix.
* kitemmodels: 10/10 tests fail.
* kitemviews: 1/1 tests fail.
* kplotting: 4/4 tests fail.
* kwayland: Tests freeze.
* modemmanager-qt: 10/10 tests fail.
* networkmanager-qt: 3/3 tests fail.

David Craven (7):
  gnu: network-manager: Propagate GLIB.
  download: Add KDE mirrors.
  gnu-maintenance: Add KDE updater.
  lint: 'inputs-should-be-native' checks for extra-cmake-modules and
    qttools.
  gnu: kwindowsystem: Update to 5.24.0.
  gnu: oxygen-icons: Update to 5.24.0.
  gnu: kde-frameworks: Remove kde-frameworks-version.

Hartmut Goebel (24):
  gnu: extra-cmake-modules: Update to 5.24.0.
  gnu: kde-frameworks: Add attica.
  gnu: kde-frameworks: Add bluez-qt.
  gnu: kde-frameworks: Add breeze-icons.
  gnu: kde-frameworks: Add kapidox.
  gnu: kde-frameworks: Add karchive.
  gnu: kde-frameworks: Add kcodecs.
  gnu: kde-frameworks: Add kconfig.
  gnu: kde-frameworks: Add kcoreaddons.
  gnu: kde-frameworks: Add kdbusaddons.
  gnu: kde-frameworks: Add kdnssd.
  gnu: kde-frameworks: Add kguiaddons.
  gnu: kde-frameworks: Add ki18n.
  gnu: kde-frameworks: Add kidletime.
  gnu: kde-frameworks: Add kitemmodels.
  gnu: kde-frameworks: Add kitemviews.
  gnu: kde-frameworks: Add kplotting.
  gnu: kde-frameworks: Add kwayland.
  gnu: kde-frameworks: Add kwidgetsaddons.
  gnu: kde-frameworks: Add modemmanager-qt.
  gnu: kde-frameworks: Add networkmanager-qt.
  gnu: kde-frameworks: Add solid.
  gnu: kde-frameworks: Add sonnet.
  gnu: kde-frameworks: Add threadweaver.

 doc/guix.texi                   |   2 +
 gnu/packages/gnome.scm          |   2 +
 gnu/packages/kde-frameworks.scm | 807 ++++++++++++++++++++++++++++++++++++++--
 guix/download.scm               |  47 ++-
 guix/gnu-maintenance.scm        |  35 ++
 guix/scripts/lint.scm           |   8 +-
 guix/scripts/refresh.scm        |   6 +-
 7 files changed, 881 insertions(+), 26 deletions(-)

--
2.9.0

[PATCH 01/31] gnu: network-manager: Propagate GLIB.

[David Craven]

* gnu/packages/gnome.scm (network-manager)[propagated-inputs]: Add glib.
---
 gnu/packages/gnome.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 445e94a..2038f8f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4423,6 +4423,8 @@ users.")
                              "rundir=/tmp"
                              "statedir=/tmp"
                              "install")))))))
+    (propagated-inputs
+     `(("glib" ,glib)))
     (native-inputs
      `(("glib:bin" ,glib "bin") ; for gdbus-codegen
        ("gobject-introspection" ,gobject-introspection)
-- 
2.9.0

[PATCH 02/31] download: Add KDE mirrors.

[David Craven]

* guix/download.scm (%mirrors)[kde]: Add kde mirrors.
---
 guix/download.scm | 47 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/guix/download.scm b/guix/download.scm
index 73c0e89..fa6fa45 100644
--- a/guix/download.scm
+++ b/guix/download.scm
@@ -224,7 +224,52 @@
        "http://ftp.de.debian.org/debian/"
        "http://ftp.fr.debian.org/debian/"
        "http://ftp.debian.org/debian/"
-       "http://archive.debian.org/debian/"))))
+       "http://archive.debian.org/debian/")
+      (kde
+       ;; Mirrors from http://files.kde.org/extra/mirrors.html
+       ;; Europe
+       "http://mirror.easyname.at/kde"
+       "http://mirror.karneval.cz/pub/kde"
+       "http://ftp.fi.muni.cz/pub/kde/"
+       "http://mirror.oss.maxcdn.com/kde/"
+       "http://ftp5.gwdg.de/pub/linux/kde/"
+       "http://ftp-stud.fht-esslingen.de/Mirrors/ftp.kde.org/pub/kde/"
+       "http://mirror.klaus-uwe.me/kde/ftp/"
+       "http://kde.beta.mirror.ga/"
+       "http://kde.alpha.mirror.ga/"
+       "http://mirror.netcologne.de/kde"
+       "http://vesta.informatik.rwth-aachen.de/ftp/pub/mirror/kde/"
+       "http://ftp.rz.uni-wuerzburg.de/pub/unix/kde/"
+       "http://mirrors.dotsrc.org/kde/"
+       "http://ftp.funet.fi/pub/mirrors/ftp.kde.org/pub/kde/"
+       "http://kde-mirror.freenux.org/"
+       "http://mirrors.ircam.fr/pub/KDE/"
+       "http://www-ftp.lip6.fr/pub/X11/kde/"
+       "http://fr2.rpmfind.net/linux/KDE/"
+       "http://kde.mirror.anlx.net/"
+       "http://www.mirrorservice.org/sites/ftp.kde.org/pub/kde/"
+       "http://ftp.heanet.ie/mirrors/ftp.kde.org/"
+       "http://ftp.nluug.nl/pub/windowing/kde/"
+       "http://ftp.surfnet.nl/windowing/kde/"
+       "http://ftp.icm.edu.pl/pub/unix/kde/"
+       "http://ftp.pbone.net/pub/kde/"
+       "http://piotrkosoft.net/pub/mirrors/ftp.kde.org/"
+       "http://mirrors.fe.up.pt/pub/kde/"
+       "http://ftp.iasi.roedu.net/pub/mirrors/ftp.kde.org/"
+       "http://ftp.acc.umu.se/mirror/kde.org/ftp/"
+       "http://kde.ip-connect.vn.ua/"
+       ;; North America
+       "http://mirror.its.dal.ca/kde/"
+       "http://mirror.csclub.uwaterloo.ca/kde/"
+       "http://mirror.cc.columbia.edu/pub/software/kde/"
+       "http://mirrors-usa.go-parts.com/kde"
+       "http://kde.mirrors.hoobly.com/"
+       "http://ftp.ussg.iu.edu/kde/"
+       "http://mirrors.mit.edu/kde/"
+       "http://kde.mirrors.tds.net/pub/kde/"
+       ;; Oceania
+       "http://ftp.kddlabs.co.jp/pub/X11/kde/"
+       "http://kde.mirror.uber.com.au/"))))
 
 (define %mirror-file
   ;; Copy of the list of mirrors to a file.  This allows us to keep a single
-- 
2.9.0

[PATCH 03/31] gnu-maintenance: Add KDE updater.

[David Craven]

* guix/gnu-maintenance.scm (kde-package?, latest-kde-release): New private
  functions.
  (%kde-updater): New public variable.
* guix/scripts/refresh.scm (list-updaters): Add %kde-updater.
* doc/guix.texi (Invoking guix refresh): Mention the new updater.
---
 doc/guix.texi            |  2 ++
 guix/gnu-maintenance.scm | 35 +++++++++++++++++++++++++++++++++++
 guix/scripts/refresh.scm |  6 +++++-
 3 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 786fe55..d029b3f 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -4985,6 +4985,8 @@ list of updaters).  Currently, @var{updater} may be one of:
 the updater for GNU packages;
 @item gnome
 the updater for GNOME packages;
+@item kde
+the updater for KDE packages;
 @item xorg
 the updater for X.org packages;
 @item elpa
diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 0dd08bf..20f0802 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -59,6 +59,7 @@
 
             %gnu-updater
             %gnome-updater
+            %kde-updater
             %xorg-updater))
 
 ;;; Commentary:
@@ -500,6 +501,33 @@ elpa.gnu.org, and all the GNOME packages."
                        ;; checksums.
                        #:file->signature (const #f))))
 
+(define (kde-package? package)
+  "Return true if PACKAGE is a KDE package, developed by KDE.org."
+  (define kde-uri?
+    (match-lambda
+      ((? string? uri)
+       (string-prefix? "mirror://kde/" uri))
+      (_
+       #f)))
+
+  (match (package-source package)
+    ((? origin? origin)
+     (match (origin-uri origin)
+      ((? kde-uri?) #t)
+      (_             #f)))
+    (_ #f)))
+
+(define (latest-kde-release package)
+  "Return the latest release of PACKAGE, the name of an KDE.org package."
+  (let ((uri (string->uri (origin-uri (package-source package)))))
+    (false-if-ftp-error
+     (latest-ftp-release
+      (package-name package)
+      #:server "mirrors.mit.edu"
+      #:directory
+      (string-append "/kde" (dirname (dirname (uri-path uri))))
+      #:file->signature (const #f)))))
+
 (define (xorg-package? package)
   "Return true if PACKAGE is an X.org package, developed by X.org."
   (define xorg-uri?
@@ -540,6 +568,13 @@ elpa.gnu.org, and all the GNOME packages."
    (pred gnome-package?)
    (latest latest-gnome-release)))
 
+(define %kde-updater
+  (upstream-updater
+    (name 'kde)
+    (description "Updater for KDE packages")
+    (pred kde-package?)
+    (latest latest-kde-release)))
+
 (define %xorg-updater
   (upstream-updater
    (name 'xorg)
diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 209f0d8..b00ac98 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -32,7 +32,10 @@
   #:use-module (guix scripts graph)
   #:use-module (guix monads)
   #:use-module ((guix gnu-maintenance)
-                #:select (%gnu-updater %gnome-updater %xorg-updater))
+                #:select (%gnu-updater
+                          %gnome-updater
+                          %kde-updater
+                          %xorg-updater))
   #:use-module (guix import elpa)
   #:use-module (guix import cran)
   #:use-module (guix import hackage)
@@ -195,6 +198,7 @@ unavailable optional dependencies such as Guile-JSON."
   ;; List of "updaters" used by default.  They are consulted in this order.
   (list-updaters %gnu-updater
                  %gnome-updater
+                 %kde-updater
                  %xorg-updater
                  %elpa-updater
                  %cran-updater
-- 
2.9.0

[PATCH 04/31] lint: 'inputs-should-be-native' checks for extra-cmake-modules and qttools.

[David Craven]

* guix/scripts/lint.scm (check-inputs-should-be-native): Warn when
extra-cmake-modules or qttools isn't a native-input.
---
 guix/scripts/lint.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 8aab1fe..51191e7 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -205,7 +205,13 @@ by two spaces; possible infraction~p at ~{~a~^, ~}")
   ;; native inputs.
   (let ((linted package)
         (inputs (package-inputs package))
-        (native-inputs '("pkg-config" "glib:bin" "intltool" "itstool")))
+        (native-inputs
+          '("pkg-config"
+            "extra-cmake-modules"
+            "glib:bin"
+            "intltool"
+            "itstool"
+            "qttools")))
     (match inputs
       (((labels packages . outputs) ...)
        (for-each (lambda (package output)
-- 
2.9.0

[PATCH 05/31] gnu: extra-cmake-modules: Update to 5.24.0.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm: Update to 5.24.0.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 74fbac2..39e2292 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -32,21 +32,29 @@
 (define-public extra-cmake-modules
   (package
     (name "extra-cmake-modules")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)
-        (uri (string-append "http://download.kde.org/stable/frameworks/"
+        (uri (string-append "mirror://kde/stable/frameworks/"
                             (version-major+minor version) "/"
                             name "-" version ".tar.xz"))
         (sha256
          (base32
-          "1kbc5fkcbz9vkg0jpz10vsfgwajlrsmbl0vrbls5qvrdgbgrwlm3"))))
-    ;; The package looks for Qt5LinguistTools provided by Qt, but apparently
-    ;; compiles without it; it might be needed for building the
-    ;; documentation, which requires the additional Sphinx package.
-    ;; To save space, we do not add these inputs.
+          "01m12ml529pwr2sal951r5z6yb1rwbpid1y4k14nlk3xqgmdakwa"))))
     (build-system cmake-build-system)
+    (native-inputs
+     `(("qtbase" ,qtbase)))    ; For tests (needs qmake)
+    (arguments `(#:tests? #f)) ; FIXME: All tests pass, but install fails after
+                               ; running tests.
+    ;; optional dependencies - to save space, we do not add these inputs.
+    ;; Sphinx > 1.2:
+    ;;   Required to build Extra CMake Modules documentation in Qt Help format.
+    ;; Qt5LinguistTools , Qt5 linguist tools. , <http://www.qt.io/>
+    ;;   Required to run tests for the ECMPoQmTools module.
+    ;; Qt5Core
+    ;;   Required to run tests for the ECMQtDeclareLoggingCategory module,
+    ;;   and for some tests of the KDEInstallDirs module.
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "CMake module files for common software used by KDE")
     (description "The Extra CMake Modules package, or ECM, adds to the
-- 
2.9.0

[PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

* gnu/packages/kde-frameworks.scm: Update to 5.24.0.
---
 gnu/packages/kde-frameworks.scm | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 39e2292..7b9bcba 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -63,26 +63,28 @@ common build settings used in software produced by the KDE community.")
     (license license:bsd-3)))
 
 (define-public kwindowsystem
+;;; TODO qtx11extras isn't found
   (package
     (name "kwindowsystem")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)
-        (uri (string-append "http://download.kde.org/stable/frameworks/"
+        (uri (string-append "mirror://kde/stable/frameworks/"
                             (version-major+minor version) "/"
                             name "-" version ".tar.xz"))
         (sha256
          (base32
-          "13lfwpw5a4in0mp5y8d15jg6xhhrka2qmw73wrdzcvj22n6ldzzi"))))
+          "0w5ym8msl80v3q65253pdpj9f1fmb658rnndlbkrgpmm1rv1n6dz"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("pkg-config" ,pkg-config)
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
        ("xorg-server" ,xorg-server))) ; for the tests
     (inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("libxrender" ,libxrender)
-       ("qt" ,qt)
+     `(("libxrender" ,libxrender)
+       ("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)
        ("xcb-utils-keysyms" ,xcb-util-keysyms)))
     (arguments
      `(#:tests? #f)) ; FIXME: The first seven tests fail with "Exception".
-- 
2.9.0

[PATCH 07/31] gnu: oxygen-icons: Update to 5.24.0.

[David Craven]

* gnu/packages/kde-frameworks.scm (oxygen-icons): Update to 5.24.0.
---
 gnu/packages/kde-frameworks.scm | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 7b9bcba..12d9f16 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -105,22 +105,21 @@ lower level classes for interaction with the X Windowing System.")
 (define-public oxygen-icons
   (package
     (name "oxygen-icons")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)
-        (uri (string-append "http://download.kde.org/stable/frameworks/"
+        (uri (string-append "mirror://kde/stable/frameworks/"
                             (version-major+minor version) "/"
-                            name "5-"version ".tar.xz"))
+                            name "5" "-" version ".tar.xz"))
         (sha256
          (base32
-          "00qh1h3xx392hh73zdlknc1j9i2sck9ys74a9ffkf6an4rl0hws5"))))
+          "1c7spjbzk04725vv0ly7vmyvwa96mfa5ki2pm146ld4888a896wm"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("pkg-config" ,pkg-config)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Oxygen provides the standard icon theme for the KDE desktop")
     (description "Oxygen icon theme for the KDE desktop")
-- 
2.9.0

[PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[David Craven]

* gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
---
 gnu/packages/kde-frameworks.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 12d9f16..db20690 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -27,8 +27,6 @@
   #:use-module (gnu packages qt)
   #:use-module (gnu packages xorg))
 
-(define kde-frameworks-version "5.21.0")
-
 (define-public extra-cmake-modules
   (package
     (name "extra-cmake-modules")
-- 
2.9.0

[PATCH 09/31] gnu: kde-frameworks: Add attica.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (attica): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index db20690..06ef9b2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1,6 +1,8 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2016 David Craven <david@craven.ch>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -60,6 +62,43 @@ modules provided by CMake to find common software.  In addition, it provides
 common build settings used in software produced by the KDE community.")
     (license license:bsd-3)))
 
+;; Tier 1
+;;
+;; Tier 1 frameworks depend only on Qt (and possibly a small number of other
+;; third-party libraries), so can easily be used by an Qt-based project.
+
+(define-public attica
+  (package
+    (name "attica")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0d368gmds7m7k5pnn625wqsij38cvxk1gkm4zv24phnk9f67v7cw"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Open Collaboration Service client library")
+    (description "Attica is a Qt library that implements the Open
+Collaboration Services API version 1.6.
+
+It grants easy access to the services such as querying information about
+persons and contents.  The library is used in KNewStuff3 as content provider.
+In order to integrate with KDE's Plasma Desktop, a platform plugin exists in
+kdebase.
+
+The REST API is defined here:
+http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
+    (license (list license:lgpl2.1+ license:lgpl3+))))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 10/31] gnu: kde-frameworks: Add bluez-qt.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (bluez-qt): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 06ef9b2..77501cc 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -99,6 +99,34 @@ The REST API is defined here:
 http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
     (license (list license:lgpl2.1+ license:lgpl3+))))
 
+(define-public bluez-qt
+  (package
+    (name "bluez-qt")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0gy0m7lcwwklf021l5i3v7j0cl7qz7cgvzrwpj87ix3kyw5xs80z"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:configure-flags
+        '("-DINSTALL_UDEV_RULE:BOOL=OFF")
+       #:tests? #f)) ; FIXME tests freeze.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "QML wrapper for bluez")
+    (description " bluez-qt is a Qt-style library for accessing the bluez
+Bluetooth stack.  It is used by the KDE Bluetooth stack, BlueDevil.")
+    (license (list license:lgpl2.1+ license:lgpl3+))))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 11/31] gnu: kde-frameworks: Add breeze-icons.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (breeze-icons): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 77501cc..23332cb 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -127,6 +127,33 @@ http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
 Bluetooth stack.  It is used by the KDE Bluetooth stack, BlueDevil.")
     (license (list license:lgpl2.1+ license:lgpl3+))))
 
+(define-public breeze-icons
+  (package
+    (name "breeze-icons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1dh7bijx99sdb3vn6394wmm5cq0fvvmz8h17sx4hakmbga849cx2"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Default KDE Plasma 5 icon theme")
+    (description "Breeze provides a freedesktop.org compatible icon theme.
+It is the default icon theme for the KDE Plasma 5 desktop.")
+    ;; The license file mentions lgpl3+. The license files in the source
+    ;; directories are lgpl3, while the top directory contains the lgpl2.1.
+    ;; text.
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 12/31] gnu: kde-frameworks: Add kapidox.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kapidox): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 44 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 23332cb..0a970be 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -26,6 +26,7 @@
   #:use-module (guix packages)
   #:use-module (guix utils)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages xorg))
 
@@ -154,6 +155,49 @@ It is the default icon theme for the KDE Plasma 5 desktop.")
     ;; text.
     (license license:lgpl3+)))
 
+(define-public kapidox
+  (package
+    (name "kapidox")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "19a7alvn71nxflsyi7y3hghx1iw04qqc77qy54mcxcpkiyvpsggf"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f)) ; has no test target
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (propagated-inputs
+     ;; kapidox is a python programm
+     ;; TODO: check if doxygen has to be installed, the readme does not
+     ;; mention it. The openSuse .rpm lists doxygen, graphviz, graphviz-gd,
+     ;; and python-xml.
+     `(("python" ,python)
+       ("python-jinja2" ,python-jinja2)
+       ("python-pyyaml" ,python-pyyaml)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Doxygen Tools")
+
+    (description "This framework contains scripts and data for building API
+documentation (dox) in a standard format and style for KDE.
+
+For the actual documentation extraction and formatting the Doxygen tool is
+used, but this framework provides a wrapper script to make generating the
+documentation more convenient (including reading settings from the target
+framework or other module) and a standard template for the generated
+documentation.")
+    ;; Most parts are bsd-2, but incuded jquery is expat
+    ;; This list is taken from http://packaging.neon.kde.org/cgit/
+    (license (list license:bsd-2 license:expat))))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 13/31] gnu: kde-frameworks: Add karchive.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (karchive): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 0a970be..9bb780e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -25,6 +25,7 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
@@ -198,6 +199,40 @@ documentation.")
     ;; This list is taken from http://packaging.neon.kde.org/cgit/
     (license (list license:bsd-2 license:expat))))
 
+(define-public karchive
+  (package
+    (name "karchive")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1n5nfhrfvqnrdjgjjy7arqik4fya5bp3dvxa16mlhqr19azkavzq"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("bzip2" ,bzip2)
+       ("qtbase" ,qtbase)
+       ("xz" ,xz)
+       ("zlib" ,zlib)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Qt 5 addon providing access to numerous types of archives")
+    (description "KArchive provides classes for easy reading, creation and
+manipulation of 'archive' formats like ZIP and TAR.
+
+It also provides transparent compression and decompression of data, like the
+GZip format, via a subclass of QIODevice.")
+    ;; The included licenses is are gpl2 and lgpl2.1, but the sources are
+    ;; under a variety of licenses.
+    ;; This list is taken from http://packaging.neon.kde.org/cgit/
+    (license (list license:lgpl2.1 license:lgpl2.1+
+                   license:lgpl3+ license:bsd-2))))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 14/31] gnu: kde-frameworks: Add kcodecs.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kcodecs): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 9bb780e..7ecee1d 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -233,6 +233,41 @@ GZip format, via a subclass of QIODevice.")
     (license (list license:lgpl2.1 license:lgpl2.1+
                    license:lgpl3+ license:bsd-2))))
 
+(define-public kcodecs
+  (package
+    (name "kcodecs")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1qpzjh3qc2zz80j2bmlinipbispms14k9bmqw8v61zhi6in9z14c"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "String encoding and manipulating library")
+    (description "KCodecs provide a collection of methods to manipulate
+strings using various encodings.
+
+It can automatically determine the charset of a string, translate XML
+entities, validate email addresses, and find encodings by name in a more
+tolerant way than QTextCodec (useful e.g. for data coming from the
+Internet).")
+    ;; The included licenses is are gpl2 and lgpl2.1, but the sources are
+    ;; under a variety of licenses.
+    ;; This list is taken from http://packaging.neon.kde.org/cgit/
+    (license (list license:gpl2 license:gpl2+ license:bsd-2
+                   license:lgpl2.1 license:lgpl2.1+ license:expat
+                   license:lgpl3+ license:mpl1.1))))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 15/31] gnu: kde-frameworks: Add kconfig.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kconfig): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 53 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 7ecee1d..1a9c514 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -268,6 +268,59 @@ Internet).")
                    license:lgpl2.1 license:lgpl2.1+ license:expat
                    license:lgpl3+ license:mpl1.1))))
 
+(define-public kconfig
+  (package
+    (name "kconfig")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1dc2i6icyigw1j6qxgdza6j2g8afh390qmxsa2a54mwl84fkfmxv"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)
+       ("xorg-server" ,xorg-server))) ; for the tests
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: 28/34 tests fail.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Kconfiguration settings framework for Qt")
+    (description "KConfig provides an advanced configuration system.
+It is made of two parts: KConfigCore and KConfigGui.
+
+KConfigCore provides access to the configuration files themselves.
+It features:
+
+@itemize
+@item Code generation: describe your configuration in an XML file, and use
+`kconfig_compiler to generate classes that read and write configuration
+entries.
+
+@item Cascading configuration files (global settings overridden by local
+settings).
+
+@item Optional shell expansion support (see docs/options.md).
+
+@item The ability to lock down configuration options (see docs/options.md).
+@end itemize
+
+KConfigGui provides a way to hook widgets to the configuration so that they
+are automatically initialized from the configuration and automatically
+propagate their changes to their respective configuration files.")
+    ;; The included licenses is are gpl2 and lgpl2.1, but the sources are
+    ;; under a variety of licenses.
+    ;; This list is taken from http://packaging.neon.kde.org/cgit/
+    (license (list license:lgpl2.1 license:lgpl2.1+ license:expat
+                   license:lgpl3+ license:gpl1 ; licende:mit-olif
+                   license:bsd-2 license:bsd-3))))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 16/31] gnu: kde-frameworks: Add kcoreaddons.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kcoreaddons): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 1a9c514..4a2447a 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -321,6 +321,39 @@ propagate their changes to their respective configuration files.")
                    license:lgpl3+ license:gpl1 ; licende:mit-olif
                    license:bsd-2 license:bsd-3))))
 
+(define-public kcoreaddons
+  (package
+    (name "kcoreaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "06sx7by3nvaridnavj5p0bxv4nh47n708jlacfw8ydaikmd9i03h"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)
+       ("xorg-server" ,xorg-server))) ; for the tests
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: 4/23 tests fail.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Qt addon library with a collection of non-GUI utilities")
+    (description "KCoreAddons provides classes built on top of QtCore to
+perform various tasks such as manipulating mime types, autosaving files,
+creating backup files, generating random sequences, performing text
+manipulations such as macro replacement, accessing user information and
+many more.")
+    ;; Some source files mention lgpl2.0+, but the included license is
+    ;; the lgpl2.1. Some source files are under non-copyleft licenses.
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 17/31] gnu: kde-frameworks: Add kdbusaddons.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kdbusaddons): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 4a2447a..cd76556 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -354,6 +354,36 @@ many more.")
     ;; the lgpl2.1. Some source files are under non-copyleft licenses.
     (license license:lgpl2.1+)))
 
+(define-public kdbusaddons
+  (package
+    (name "kdbusaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "183nxqrhz4qk4qfp1w4an0scp2dvfqcaqbpg4cgbgk0z590q0pkk"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: Tests freeze.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Convenience classes for DBus")
+    (description "KDBusAddons provides convenience classes on top of QtDBus,
+as well as an API to create KDED modules.")
+    ;; Some source files mention lgpl2.0+, but the included license is
+    ;; the lgpl2.1. Some source files are under non-copyleft licenses.
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 18/31] gnu: kde-frameworks: Add kdnssd.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kdnssd): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index cd76556..3208864 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -384,6 +384,33 @@ as well as an API to create KDED modules.")
     ;; the lgpl2.1. Some source files are under non-copyleft licenses.
     (license license:lgpl2.1+)))
 
+(define-public kdnssd
+  (package
+    (name "kdnssd")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "01b650g031apxc3vd2m91g2fxqk9l8ap67z6rafniphfwy8i0d5m"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Network service discovery using Zeroconf")
+    (description "KDNSSD is a library for handling the DNS-based Service
+Discovery Protocol (DNS-SD), the layer of Zeroconf that allows network services,
+such as printers, to be discovered without any user intervention or centralized
+infrastructure.")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 19/31] gnu: kde-frameworks: Add kguiaddons.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kguiaddons): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 3208864..fa5fbee 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -411,6 +411,32 @@ such as printers, to be discovered without any user intervention or centralized
 infrastructure.")
     (license license:lgpl3+)))
 
+(define-public kguiaddons
+  (package
+    (name "kguiaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0ig96ah20ybg5rwpswj9va2klvkh2q4amwxmgy3z4niwfsm2g3ic"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: Tests fail when run by guix.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Utilities for graphical user interfaces")
+    (description "The KDE GUI addons provide utilities for graphical user
+interfaces in the areas of colors, fonts, text, images, keyboard input.")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 20/31] gnu: kde-frameworks: Add ki18n.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (ki18n): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index fa5fbee..66cedd5 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -26,6 +26,7 @@
   #:use-module (guix packages)
   #:use-module (guix utils)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages gettext)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
@@ -437,6 +438,43 @@ infrastructure.")
 interfaces in the areas of colors, fonts, text, images, keyboard input.")
     (license license:lgpl3+)))
 
+(define-public ki18n
+;;; TODO: qtdeclarative isn't found
+  (package
+    (name "ki18n")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0cw24spmwsqa3ppkw03cm6yjd3sfll0dbbk2ya76fd4nw9hb00dv"))))
+    (build-system cmake-build-system)
+    (propagated-inputs
+     `(("python" ,python)))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("gettext" ,gnu-gettext)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("qtscript" ,qtscript)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Gettext-based UI text internationalization")
+    (description "KI18n provides functionality for internationalizing user
+interface text in applications, based on the GNU Gettext translation system.  It
+wraps the standard Gettext functionality, so that the programmers and translators
+can use the familiar Gettext tools and workflows.
+
+KI18n provides additional functionality as well, for both programmers and
+translators, which can help to achieve a higher overall quality of source and
+translated text.  This includes argument capturing, customizable markup, and
+translation scripting.")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 21/31] gnu: kde-frameworks: Add kidletime.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kidletime): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 66cedd5..c6a24ba 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -475,6 +475,34 @@ translated text.  This includes argument capturing, customizable markup, and
 translation scripting.")
     (license license:lgpl3+)))
 
+(define-public kidletime
+;;; TODO: qtx11extras isn't found
+  (package
+    (name "kidletime")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "09jsj0pj27h93nr8v46savs6b93h8frydinfr7wlijkvpsl02jb4"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Reporting of idle time of user and system")
+    (description "KIdleTime is a singleton reporting information on idle time.
+It is useful not only for finding out about the current idle time of the PC,
+but also for getting notified upon idle time events, such as custom timeouts,
+or user activity.")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 22/31] gnu: kde-frameworks: Add kitemmodels.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kitemmodels): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 52 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c6a24ba..5ef36a6 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -503,6 +503,58 @@ but also for getting notified upon idle time events, such as custom timeouts,
 or user activity.")
     (license license:lgpl3+)))
 
+(define-public kitemmodels
+  (package
+    (name "kitemmodels")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1s1p4nw1pqdzbdwvjnka17p9avf00wadr437p4f96md1lvh3sh69"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: 10/10 tests fail.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Set of item models extending the Qt model-view framework")
+    (description "KItemModels provides the following models:
+
+@itemize
+@item KBreadcrumbSelectionModel - Selects the parents of selected items to
+create breadcrumbs.
+
+@item KCheckableProxyModel - Adds a checkable capability to a source model.
+
+@item KConcatenateRowsProxyModel - Concatenates rows from multiple source models.
+
+@item KDescendantsProxyModel - Proxy Model for restructuring a Tree into a list.
+
+@item KExtraColumnsProxyModel - Adds columns after existing columns.
+
+@item KLinkItemSelectionModel - Share a selection in multiple views which do
+not have the same source model.
+
+@item KModelIndexProxyMapper - Mapping of indexes and selections through proxy
+models.
+
+@item KRearrangeColumnsProxyModel - Can reorder and hide columns from the source
+model.
+
+@item KRecursiveFilterProxyModel - Recursive filtering of models.
+
+@item KSelectionProxyModel - A Proxy Model which presents a subset of its source
+model to observers
+@end itemize")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 23/31] gnu: kde-frameworks: Add kitemviews.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kitemviews): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 5ef36a6..1ec098c 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -555,6 +555,34 @@ model to observers
 @end itemize")
     (license license:lgpl3+)))
 
+(define-public kitemviews
+  (package
+    (name "kitemviews")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0y3fx9hk1x27arrmwfzq783a44cs7p8dpmhxrwzh0di4mwa8jafw"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: 1/1 tests fail.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Set of item views extending the Qt model-view framework")
+    (description "KItemViews includes a set of views, which can be used with
+item models.  It includes views for categorizing lists and to add search filters
+to flat and hierarchical lists.")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 24/31] gnu: kde-frameworks: Add kplotting.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kplotting): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 1ec098c..ef1ebe2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -583,6 +583,35 @@ item models.  It includes views for categorizing lists and to add search filters
 to flat and hierarchical lists.")
     (license license:lgpl3+)))
 
+(define-public kplotting
+  (package
+    (name "kplotting")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0gpypq9kh4b5s6dc7py3m117k3nbxczsfkxgxd9zxvr35kig7ya2"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: 4/4 tests fail.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Data plotting library")
+    (description "KPlotWidget is a QWidget-derived class that provides a virtual
+base class for easy data-plotting.  The idea behind KPlotWidget is that you only
+have to specify information in \"data units\", the natural units of the
+data being plotted.  KPlotWidget automatically converts everything to screen
+pixel units.")
+    (license license:lgpl3+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 25/31] gnu: kde-frameworks: Add kwayland.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kwayland): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index ef1ebe2..2666232 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -612,6 +612,38 @@ data being plotted.  KPlotWidget automatically converts everything to screen
 pixel units.")
     (license license:lgpl3+)))
 
+(define-public kwayland
+  (package
+    (name "kwayland")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1h5anbqrxcl1s8kx1l53vcsfr8ifamcjqd47dk8a7lwr1ga6myq2"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("wayland" ,wayland)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: tests freeze.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Qt-style API to interact with the wayland client and server")
+    (description "As the names suggest they implement a Client respectively a
+Server API for the Wayland protocol.  The API is Qt-styled removing the needs to
+interact with a for a Qt developer uncomfortable low-level C-API.  For example
+the callback mechanism from the Wayland API is replaced by signals, data types
+are adjusted to be what a Qt developer expects - two arguments of int are
+represented by a QPoint or a QSize.")
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 26/31] gnu: kde-frameworks: Add kwidgetsaddons.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (kwidgetsaddons): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 2666232..99e086e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -644,6 +644,34 @@ are adjusted to be what a Qt developer expects - two arguments of int are
 represented by a QPoint or a QSize.")
     (license license:lgpl2.1+)))
 
+(define-public kwidgetsaddons
+;; TODO: qttools isn't found
+  (package
+    (name "kwidgetsaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1kppx0ppfhnb6q6sijs2dffyar86wkkx8miqavsjsgw1l2wiymcx"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Large set of desktop widgets")
+    (description "Provided are action classes that can be added to toolbars or
+menus, a wide range of widgets for selecting characters, fonts, colors, actions,
+dates and times, or MIME types, as well as platform-aware dialogs for
+configuration pages, message boxes, and password requests.")
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
 ;;; TODO qtx11extras isn't found
   (package
-- 
2.9.0

[PATCH 27/31] gnu: kde-frameworks: Add modemmanager-qt.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (modemmanager-qt): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 99e086e..7aa4d74 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -26,6 +26,7 @@
   #:use-module (guix packages)
   #:use-module (guix utils)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -712,6 +713,36 @@ lower level classes for interaction with the X Windowing System.")
     ;; the lgpl2.1. Some source files are under non-copyleft licenses.
     (license license:lgpl2.1+)))
 
+(define-public modemmanager-qt
+  (package
+    (name "modemmanager-qt")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "0khz5bf84xxa8aqpzwb6x839xx6dbiadwqhyj7cvgha65fh2xinh"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("modem-manager", modem-manager)
+       ("qtbase" ,qtbase)))
+    (arguments
+     `(#:tests? #f)) ; FIXME: 10/10 tests fail.
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Qt wrapper for ModemManager DBus API")
+    (description "ModemManagerQt provides access to all ModemManager features
+exposed on DBus.  It allows you to manage modem devices and access to
+information available for your modem devices, like signal, location and
+messages.")
+    (license license:lgpl2.1+)))
+
 (define-public oxygen-icons
   (package
     (name "oxygen-icons")
-- 
2.9.0

[PATCH 28/31] gnu: kde-frameworks: Add networkmanager-qt.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks (networkmanager-qt): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 7aa4d74..da7cb3c 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -28,6 +28,7 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
@@ -743,6 +744,36 @@ information available for your modem devices, like signal, location and
 messages.")
     (license license:lgpl2.1+)))
 
+(define-public networkmanager-qt
+  (package
+    (name "networkmanager-qt")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "11wy0ds0hqbba900ggkcxjfqc9n65xlzc3h1zv9433nn5d75v6fy"))))
+     (build-system cmake-build-system)
+     (native-inputs
+      `(("extra-cmake-modules" ,extra-cmake-modules)
+        ("pkg-config" ,pkg-config)))
+     (inputs
+      `(("network-manager", network-manager)
+        ("qtbase" ,qtbase)))
+     (arguments
+      `(#:tests? #f)) ; FIXME 3/3 tests fail.
+     (home-page "https://community.kde.org/Frameworks")
+     (synopsis "Qt wrapper for NetworkManager DBus API")
+     (description "NetworkManagerQt provides access to all NetworkManager
+features exposed on DBus. It allows you to manage your connections and control
+your network devices and also provides a library for parsing connection settings
+which are used in DBus communication.")
+     (license license:lgpl2.1+)))
+
 (define-public oxygen-icons
   (package
     (name "oxygen-icons")
-- 
2.9.0

[PATCH 29/31] gnu: kde-frameworks: Add solid.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (solid): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index da7cb3c..a023a37 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -25,10 +25,12 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages linux)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
@@ -796,3 +798,31 @@ which are used in DBus communication.")
     (synopsis "Oxygen provides the standard icon theme for the KDE desktop")
     (description "Oxygen icon theme for the KDE desktop")
     (license license:lgpl3+)))
+
+(define-public solid
+  (package
+    (name "solid")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "00wvsxcnvhdx7ijzpcz5wny2ypkxr1drdpr4yvawgpwa678l1107"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("bison" ,bison)
+       ("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("udev" ,eudev)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Desktop hardware abstraction")
+    (description "Solid is a device integration framework.  It provides a way of
+querying and interacting with hardware independently of the underlying operating
+system.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 30/31] gnu: kde-frameworks: Add sonnet.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (sonnet): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a023a37..4e5c2f4 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -826,3 +826,29 @@ which are used in DBus communication.")
 querying and interacting with hardware independently of the underlying operating
 system.")
     (license license:lgpl2.1+)))
+
+(define-public sonnet
+  (package
+    (name "sonnet")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "152xz7fb1iwhb5w1n4xqvc648iaxi0inrl4kavxcsir61das1xyl"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Multi-language spell checker")
+    (description "Sonnet is a plugin-based spell checking library for Qt-based
+applications.  It supports several different plugins, including HSpell, Enchant,
+ASpell and HUNSPELL.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

[PATCH 31/31] gnu: kde-frameworks: Add threadweaver.

[David Craven]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>

* gnu/packages/kde-frameworks.scm (threadweaver): New variable.

Co-authored-by: David Craven <david@craven.ch>
---
 gnu/packages/kde-frameworks.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 4e5c2f4..96edd71 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -852,3 +852,27 @@ system.")
 applications.  It supports several different plugins, including HSpell, Enchant,
 ASpell and HUNSPELL.")
     (license license:lgpl2.1+)))
+
+(define-public threadweaver
+  (package
+    (name "threadweaver")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "02g60zr9cc4bg1p90giich4n0qvqaiakz0y94qrnyj9f7fg0yksl"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Helper for multithreaded programming")
+    (description "ThreadWeaver is a helper for multithreaded programming.  It
+uses a job-based interface to queue tasks and execute them in an efficient way.")
+    (license license:lgpl2.1+)))
-- 
2.9.0

Re: [PATCH 00/31] KDE Framework Tier1 Packages

[Andreas Enge]

Hello, David!

Thanks for all this work! I must admit that this big number of patches is
a bit intimidating to review. Maybe we should concentrate on the first
few patches to get the basics right, and accelerate later. Anyway, I am
looking forward to more KDE!

On Mon, Aug 01, 2016 at 08:13:11PM +0200, David Craven wrote:
> * ki18n: qtdeclarative isn't found.
> * kidletime: qtx11extras isn't found.
> * kwidgetsaddons: qttools isn't found.
> * kwindowsystem: qtx11extras isn't found.

This is in line with the problems you had with your other Qt based package.
I wonder if it indicates a problem with our Qt package? Or is it a recurring
error in the packages requiring Qt? In both cases, it would be good to under-
stand what is happening.

I will have a look at the first few patches and comment individually.

Andreas

Re: [PATCH 01/31] gnu: network-manager: Propagate GLIB.

[Andreas Enge]

On Mon, Aug 01, 2016 at 08:13:12PM +0200, David Craven wrote:
> * gnu/packages/gnome.scm (network-manager)[propagated-inputs]: Add glib.
> +    (propagated-inputs
> +     `(("glib" ,glib)))

This requires a little comment at the end of the line.

I wonder if it is really needed. network-manager provides several libraries.
Looking into the pkgconfig subdirectory, there is the following:
-r--r--r-- 2 root guixbuild 389  1. Jan 1970  libnm-glib.pc
-r--r--r-- 2 root guixbuild 375  1. Jan 1970  libnm-glib-vpn.pc
-r--r--r-- 2 root guixbuild 361  1. Jan 1970  libnm.pc
-r--r--r-- 2 root guixbuild 370  1. Jan 1970  libnm-util.pc
-r--r--r-- 2 root guixbuild 414  1. Jan 1970  NetworkManager.pc
libnm-glib.pc, libnm-glib-vpn.pc and libnm-util.pc require glib, the others
do not. So it seems entirely possible to use network-manager without pulling
glib into a profile.

What do the specialists think?

Andreas

Re: [PATCH 02/31] download: Add KDE mirrors.

[Andreas Enge]

On Mon, Aug 01, 2016 at 08:13:13PM +0200, David Craven wrote:
> * guix/download.scm (%mirrors)[kde]: Add kde mirrors.

This is a good idea! I tried it out and it worked. I think you can push
this already now.

But I think the "[kde]" should not appear in the commit message?
It would be good if someone more knowledgeable could comment.

Andreas

Re: [PATCH 01/31] gnu: network-manager: Propagate GLIB.

[David Craven]

> libnm-glib.pc, libnm-glib-vpn.pc and libnm-util.pc require glib, the others
> do not. So it seems entirely possible to use network-manager without pulling
> glib into a profile.

libnm requires glib too.

pkg-config libnm --libs
-L/gnu/store/m3py3rk71ihlfgvj2kss7054hwfqwkpq-glib-2.48.0/lib
-L/nix/store/apa8hagf5bnsw0fyb0i9a3b59z6h8ppb-network-manager-1.0.12/lib
-lnm -lgio-2.0 -lgobject-2.0 -lglib-2.0

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[Andreas Enge]

On Mon, Aug 01, 2016 at 08:13:19PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.

Should we not keep it? From what I understand, all of KDE, or at least
the framework, seems to move in unison. So keeping a unique global variable
would making the update a bit easier.

On the other hand, one would still need to update the hashes by hand. So
maybe having the updater you propose in another patch will actually be
a better solution.

Comments?

I will not have a look at the updater and the linter (which looks like a
good idea), since I have no expertise in this area.

Andreas

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[Andreas Enge]

On Mon, Aug 01, 2016 at 08:13:19PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.

PS: If you delete the variable, I would do this first and replace its use
by the current value in the two (?) packages using it so far, and after that
update the packages to their latest versions.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[David Craven]

I thought it would be easier to update, since we prefer each update to
be a commit. If we change the version for all packages at the same
time we could have breakage until they are all updated. With the
auto-updater this doesn't require any manual labor at all.

Re: [PATCH 05/31] gnu: extra-cmake-modules: Update to 5.24.0.

[Andreas Enge]

On Mon, Aug 01, 2016 at 08:13:16PM +0200, David Craven wrote:
> From: Hartmut Goebel <h.goebel@crazy-compilers.com>
> * gnu/packages/kde-frameworks.scm: Update to 5.24.0.
> Co-authored-by: David Craven <david@craven.ch>

Now that you have taken over the project (and will probably end up modifying
the commits), and since you will do the final commits, I would do things the
other way round: Put yourself is the author, and add a "Co-authored-by" line
for Hartmut.

> -        (uri (string-append "http://download.kde.org/stable/frameworks/"
> +        (uri (string-append "mirror://kde/stable/frameworks/"
>                              (version-major+minor version) "/"
>                              name "-" version ".tar.xz"))

All modifications should either be done in separate patches, or at least be
mentioned in the commit log. Here the changing of the URL is not necessary
for the update, but probably does not warrant a separate commit (unless you
want to do it together with the introduction of the KDE mirrors, when you
could at the same time update the existing KDE packages). So you could add
a line:
[source]: Use mirror.

> +    (native-inputs
> +     `(("qtbase" ,qtbase)))    ; For tests (needs qmake)

This would also need to be mentioned in the commit message.

> +    (arguments `(#:tests? #f)) ; FIXME: All tests pass, but install fails after
> +                               ; running tests.

And hopefully, there should be a line:
[arguments]: Enable tests.
!

For the record, here is the output of the install phase:
starting phase `install'
/gnu/store/sac1fmc84cvqnrh577flhpb6arkyr922-cmake-3.3.2/bin/cmake -H/tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/extra-cmake-modules-5.24.0 -B/tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build --check-build-system CMakeFiles/Makefile.cmake 0
/gnu/store/sac1fmc84cvqnrh577flhpb6arkyr922-cmake-3.3.2/bin/cmake -E cmake_progress_start /tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build/CMakeFiles /tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build/CMakeFiles/progress.marks
make -f CMakeFiles/Makefile2 all
make[1]: Entering directory '/tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build'
make -f tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/build.make tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/depend
make[2]: Entering directory '/tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build'
tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/build.make:52: CMakeFiles/dummy.dir/depend.make: No such file or directory
tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/build.make:55: CMakeFiles/dummy.dir/progress.make: No such file or directory
tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/build.make:58: CMakeFiles/dummy.dir/flags.make: No such file or directory
make[2]: *** No rule to make target 'CMakeFiles/dummy.dir/flags.make'.  Stop.
make[2]: Leaving directory '/tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build'
CMakeFiles/Makefile2:208: recipe for target 'tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/all' failed
make[1]: *** [tests/ECMToolchainAndroidTest/CMakeFiles/dummy.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-extra-cmake-modules-5.24.0.drv-0/build'
Makefile:163: recipe for target 'all' failed
make: *** [all] Error 2

To me, this looks as if the tests created additional subdirectories, which
are now traversed during the install phase. One possible solution could be
to exchange the two phases.

I often take inspiration from Arch or Gentoo. In Arch:
   https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/extra-cmake-modules
There is a "-DBUILD_TESTING=OFF" flag, so apparently they do not test.

In Gentoo, I found this:
   https://gitweb.gentoo.org/proj/kde.git/commit/?id=f60141c0242b72efd3e80712e2c4cd024f1cffa8
The words "broken test" are suspicious.

In Linux From Scratch, for an older version of the package:
   http://www.linuxfromscratch.org/blfs/view/7.9/kde/extra-cmake-modules.html
"This package does not come with a test suite."

Andreas
 

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[Andreas Enge]

On Mon, Aug 01, 2016 at 08:13:17PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm: Update to 5.24.0.

Here also, mention all changes:

> -        (uri (string-append "http://download.kde.org/stable/frameworks/"
> +        (uri (string-append "mirror://kde/stable/frameworks/"

This.

>      (native-inputs
> -     `(("pkg-config" ,pkg-config)
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)
>         ("xorg-server" ,xorg-server))) ; for the tests
>      (inputs
> -     `(("extra-cmake-modules" ,extra-cmake-modules)

The move of extra-cmake-modules.

> -       ("qt" ,qt)
> +       ("qtbase" ,qtbase)
> +       ("qtx11extras" ,qtx11extras)

And the switch from the monolithic to the modular Qt.

For qtx11extras that is not found, here is the error message:

CMake Error at /gnu/store/6d3qjij1k7z2sjlsq9c0b8ql53xgn34v-qtbase-5.6.1-1/lib/cmake/Qt5/Qt5Config.cmake:26 (find_package):
  Could not find a package configuration file provided by "Qt5X11Extras" with
  any of the following names:

    Qt5X11ExtrasConfig.cmake
    qt5x11extras-config.cmake

  Add the installation prefix of "Qt5X11Extras" to CMAKE_PREFIX_PATH or set
  "Qt5X11Extras_DIR" to a directory containing one of the above files.  If
  "Qt5X11Extras" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:54 (find_package)
-- Configuring incomplete, errors occurred!
See also "/tmp/guix-build-kwindowsystem-5.24.0.drv-0/build/CMakeFiles/CMakeOutput.log".
phase `configure' failed after 4.4 seconds

One can go into /tmp/guix-build-kwindowsystem-5.24.0.drv-0 and look at the
file environment-variables. It does contain
export CMAKE_PREFIX_PATH="...:/gnu/store/3a5v3gh59hif13w7jqk8lhp5kvwbwk2i-qtx11extras-5.6.1-1/:..."

This is the installation prefix, and it is added to CMAKE_PREFIX_PATH as
required. Strange!

Inside, in the directory lib/cmake/Qt5X11Extras/, there are
Qt5X11ExtrasConfig.cmake and Qt5X11ExtrasConfigVersion.cmake.

It should be possible to define the environment variable Qt5X11Extras_DIR,
but it would be good to understand the problem...

According to the cmake documentation:
   https://cmake.org/cmake/help/v3.0/command/find_package.html
the Qt5X11ExtrasConfig.cmake file is searched for in the following directories
(the "(U)" stands for "Unix"):
<prefix>/(lib/<arch>|lib|share)/cmake/<name>*/          (U)
<prefix>/(lib/<arch>|lib|share)/<name>*/                (U)
<prefix>/(lib/<arch>|lib|share)/<name>*/(cmake|CMake)/  (U)

In our case, the file is actually in
<prefix>/lib/cmake/<name>/, which should be fine.

The exact failing line 54 of CMakeLists.txt is:
   find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED X11Extras)
This actually does not correspond to the regular expression for find_package
in the cmake documentation...
I think it actually looks for Qt5Config.cmake, which it finds in qtbase, see
the line in the above error message:
CMake Error at /gnu/store/6d3qjij1k7z2sjlsq9c0b8ql53xgn34v-qtbase-5.6.1-1/lib/cmake/Qt5/Qt5Config.cmake:26 (find_package):
  Could not find a package configuration file provided by "Qt5X11Extras" with
Lines 25 following of Qt5Config.cmake look like this:
foreach(module ${Qt5_FIND_COMPONENTS})
    find_package(Qt5${module}
        ${_Qt5_FIND_PARTS_QUIET}
        ${_Qt5_FIND_PARTS_REQUIRED}
        PATHS "${_qt5_install_prefix}" NO_DEFAULT_PATH
    )
So it looks like "find_package" is called with the argument "Qt5X11Extras",
but also with the suspicious additional parameters
   PATHS "${_qt5_install_prefix}" NO_DEFAULT_PATH
Since we install qt5x11extras to a different directory from qt5base,
the thing following the PATHS keyword is probably wrong.

See the cmake documentation:
"The set of installation prefixes is constructed using the following steps. If NO_DEFAULT_PATH is specified all NO_* options are enabled.
    Search paths specified in cmake-specific cache variables. These are intended to be used on the command line with a -DVAR=value. This can be skipped if NO_CMAKE_PATH is passed:
    CMAKE_PREFIX_PATH
    CMAKE_FRAMEWORK_PATH
    CMAKE_APPBUNDLE_PATH"

So I would say the error message is totally misleading; the NO_DEFAULT_PATH
keyword explicitly disables the CMAKE_PREFIX_PATH.

Unfortunately the store is read-only (in former times, I sometimes modified
store items by hand; now I do not dare overwrite the special file system
flags any more...), otherwise I would have tried to modify the file by hand...

Sorry for the long message, which follows my own path in trying to debug
this mess. To quickly summarise it:
I think we need to modify the qtbase package to drop the
NO_DEFAULT_PATH from Qt5Config.cmake.

Ceterum censeo that cmake should not be used, but this is not our choice;
autotools based projects usually do not create these problems...

Andreas

Re: [PATCH 01/31] gnu: network-manager: Propagate GLIB.

[Andreas Enge]

On Mon, Aug 01, 2016 at 09:56:44PM +0200, David Craven wrote:
> libnm requires glib too.
> pkg-config libnm --libs
> -L/gnu/store/m3py3rk71ihlfgvj2kss7054hwfqwkpq-glib-2.48.0/lib
> -L/nix/store/apa8hagf5bnsw0fyb0i9a3b59z6h8ppb-network-manager-1.0.12/lib
> -lnm -lgio-2.0 -lgobject-2.0 -lglib-2.0

Okay. Should be fine to propagate then.

Andreas

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[Andreas Enge]

On Mon, Aug 01, 2016 at 10:00:34PM +0200, David Craven wrote:
> I thought it would be easier to update, since we prefer each update to
> be a commit. If we change the version for all packages at the same
> time we could have breakage until they are all updated. With the
> auto-updater this doesn't require any manual labor at all.

Well, I am fine with auto-updating also. I think in this case both are
valid, since one will probably update everything at the same time for KDE.

Andreas

Re: [PATCH 00/31] KDE Framework Tier1 Packages

[Ludovic Courtès]

Woow, impressed by the Herculean work that you and Hartmut made!

Ludo’.

Re: [PATCH 04/31] lint: 'inputs-should-be-native' checks for extra-cmake-modules and qttools.

[Ludovic Courtès]

David Craven <david@craven.ch> skribis:

> * guix/scripts/lint.scm (check-inputs-should-be-native): Warn when
> extra-cmake-modules or qttools isn't a native-input.

LGTM!

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 2142 bytes --]

Hello!

On Mon, Aug 01, 2016 at 11:10:34PM +0200, Andreas Enge wrote:
> Sorry for the long message, which follows my own path in trying to debug
> this mess. To quickly summarise it:
> I think we need to modify the qtbase package to drop the
> NO_DEFAULT_PATH from Qt5Config.cmake.

I think that the attached patch solves the problem. Now the kwindowsystem
package fails as follows:
-- Found XCB: /gnu/store/jsy847sch7lnxjppkn1s1as22dbx74fx-libxcb-1.11/lib/libxcb.so;/gnu/store/3f6ysnalwhc73hj68c2vy9nc5zq8f3vr-xcb-util-keysyms-0.4.0/lib/libxcb-keysyms.so (found version "1.11") found components:  XCB KEYSYMS 
CMake Error at /gnu/store/kmbklh40857lxqvb8xvp6x9yvlfava79-extra-cmake-modules-5.24.0/share/ECM/modules/ECMPoQmTools.cmake:131 (find_package):
  Could not find a package configuration file provided by "Qt5LinguistTools"
  with any of the following names:

    Qt5LinguistToolsConfig.cmake
    qt5linguisttools-config.cmake

  Add the installation prefix of "Qt5LinguistTools" to CMAKE_PREFIX_PATH or
  set "Qt5LinguistTools_DIR" to a directory containing one of the above
  files.  If "Qt5LinguistTools" provides a separate development package or
  SDK, be sure it has been installed.
Call Stack (most recent call first):
  /gnu/store/kmbklh40857lxqvb8xvp6x9yvlfava79-extra-cmake-modules-5.24.0/share/ECM/modules/ECMPoQmTools.cmake:207 (ecm_process_po_files_as_qm)
  CMakeLists.txt:64 (ecm_install_po_files_as_qm)

Otherwise said, it goes beyond the line where it failed previously. I am just
surprised it does not print anything about Qt5X11Extras. In any case, the
CMakeCache.txt file in the build directory now contains the following lines:
   //The directory containing a CMake configuration file for Qt5X11Extras.
   Qt5X11Extras_DIR:PATH=/gnu/store/wlzvy1427jx3fjm9yj1yr4vv9fi065hc-qtx11extras-5.6.1-1/lib/cmake/Qt5X11Extras

I think that before continuing work on KDE, it may be a good idea to package
the missing Qt modules. (Well, I think we just need qttools here; which
makes me think that we might also want to add them as native inputs to
cmake-extra-modules before enabling tests, if we manage to do this.)

Andreas


[-- Attachment #2: 0001-gnu-qtbase-Modify-.cmake-files-to-enable-modules-in-.patch --]
[-- Type: text/plain, Size: 1468 bytes --]

From 2a4591e2eed1f0f5d88fe0a944cc7d294f5f37ab Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Mon, 1 Aug 2016 23:54:43 +0200
Subject: [PATCH] gnu: qtbase: Modify .cmake files to enable modules in
 different packages.

* gnu/packages/qt.scm (qtbase)[arguments]: In the configure phase, modify
.cmake and .cmake.in files so that find_package honors CMAKE_PREFIX_PATH.
---
 gnu/packages/qt.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index f246550..d1701c6 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -393,6 +393,13 @@ developers using C++ or QML, a CSS & JavaScript like language.")
                  (("/bin/pwd") (which "pwd")))
                (substitute* "src/corelib/global/global.pri"
                  (("/bin/ls") (which "ls")))
+               ;; The configuration files for other Qt5 packages are searched
+               ;; through a call to "find_package" in Qt5Config.cmake, which
+               ;; disables the use of CMAKE_PREFIX_PATH via the parameter
+               ;; "NO_DEFAULT_PATH". Re-enable it so that the different
+               ;; components can be installed in different places.
+               (substitute* (find-files "." ".*\\.cmake")
+                 (("NO_DEFAULT_PATH") ""))
                ;; do not pass "--enable-fast-install", which makes the
                ;; configure process fail
                (zero? (system*
-- 
2.9.1

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

Wow that was fast! qttools is packaged and provides Qt5LinguistToolsConfig.cmake

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

> Fast? I do not know. Several hours of work altogether...

Well I spent a while on it and didn't get anywhere...

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

> I think that before continuing work on KDE, it may be a good idea to package
> the missing Qt modules.

That's probably a good idea. I identified the missing qt modules:

qttranslations
qtwebview
qtserialbus
qtquickcontrols2
qtgraphicaleffects
qtenginio
qtdoc
qtcanvas3d
qtactiveqt
qt3d
qtandroidextras
qtmacextras
qtwinextras

I think we can finish KDF Tier 1 modules first, so that there aren't
too many building sites. But I have two weeks that I can work on this
full time, so we should probably be able to get it all done till then
=)

I'd also like to get the sddm display manager working, need to do some
debugging there too.

Re: [PATCH 02/31] download: Add KDE mirrors.

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Mon, Aug 01, 2016 at 08:13:13PM +0200, David Craven wrote:
>> * guix/download.scm (%mirrors)[kde]: Add kde mirrors.
>
> This is a good idea! I tried it out and it worked. I think you can push
> this already now.
>
> But I think the "[kde]" should not appear in the commit message?
> It would be good if someone more knowledgeable could comment.

It’s fine, but honestly it doesn’t matter much.  :-)

Please push, David!

Thanks,
Ludo’.

Re: [PATCH 03/31] gnu-maintenance: Add KDE updater.

[Ludovic Courtès]

David Craven <david@craven.ch> skribis:

> * guix/gnu-maintenance.scm (kde-package?, latest-kde-release): New private
>   functions.
>   (%kde-updater): New public variable.
> * guix/scripts/refresh.scm (list-updaters): Add %kde-updater.
> * doc/guix.texi (Invoking guix refresh): Mention the new updater.

Awesome!  Please add a copyright line for yourself in
gnu-maintenance.scm and push.

Eventually we’ll move the Xorg and KDE updaters outside of
gnu-maintenance, since they have little to do with GNU.

Thank you!

Ludo’.

Re: [PATCH 02/31] download: Add KDE mirrors.

[David Craven]

Does the ordering of the mirrors matter?

I had them all in in the order listed on the kde website, but that
ended up causing really slow downloads from africa... =)

Re: [PATCH 03/31] gnu-maintenance: Add KDE updater.

[Andreas Enge]

On Tue, Aug 02, 2016 at 12:02:36PM +0200, Ludovic Courtès wrote:
> Eventually we’ll move the Xorg and KDE updaters outside of
> gnu-maintenance, since they have little to do with GNU.

Or rename the file? It sounds like a good idea to have all updaters in
the same place.

Andreas

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[David Craven]

> PS: If you delete the variable, I would do this first and replace its use
by the current value in the two (?) packages using it so far, and after that
update the packages to their latest versions.

I pushed the first 5 commits until and including this one here.

Ups I just realized I made a mistake on this commit.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[David Craven]

> Ups I just realized I made a mistake on this commit.

What do you want me to do? not that I make things worse... This is
what I pushed.

commit d26e2b9f306a1170d46f7c860c81840d9d600161
Author: David Craven <david@craven.ch>
Date:   Mon Aug 1 16:39:00 2016 +0200

    gnu: kde-frameworks: Remove kde-frameworks-version.

    * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
      (kwindowsystem)[version]: Replace kde-frameworks-version with
version string.
      (oxygen-icons)[version]: Replace kde-frameworks-version with
version string.

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 74fbac2..b60d85d 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -27,8 +27,6 @@
   #:use-module (gnu packages qt)
   #:use-module (gnu packages xorg))

-(define kde-frameworks-version "5.21.0")
-
 (define-public extra-cmake-modules
   (package
     (name "extra-cmake-modules")
@@ -57,7 +55,7 @@ common build settings used in software produced by
the KDE community.")
 (define-public kwindowsystem
   (package
     (name "kwindowsystem")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)
@@ -95,7 +93,7 @@ lower level classes for interaction with the X
Windowing System.")
 (define-public oxygen-icons
   (package
     (name "oxygen-icons")
-    (version kde-frameworks-version)
+    (version "5.24.0")
     (source
       (origin
         (method url-fetch)

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[Andreas Enge]

On Tue, Aug 02, 2016 at 01:57:25PM +0200, David Craven wrote:
> What do you want me to do? not that I make things worse... This is
> what I pushed.
> 
>     gnu: kde-frameworks: Remove kde-frameworks-version.
>     * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
>       (kwindowsystem)[version]: Replace kde-frameworks-version with
> version string.
>       (oxygen-icons)[version]: Replace kde-frameworks-version with
> version string.
> -    (version kde-frameworks-version)
> +    (version "5.24.0")

Oh well... The absolutely correct fix would be to revert this commit and to
replace it by two separate ones. But honestly, I would just do nothing :-)
This is work in progress anyway, nobody can currently use the packages,
so they have just been silently updated.

Andreas

PS: I will commit my qtbase fix tomorrow after the release unless there are
    comments.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[Ludovic Courtès]

David Craven <david@craven.ch> skribis:

> * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.

Commit d26e2b9f306a1170d46f7c860c81840d9d600161 introduced breakage:
‘make’ would fail due to the unbound variable.  I fixed it in
47e2fe3cdf0ecfcfc6dccc048d4b1da94fa5a4a2.

Ludo’.

Re: [PATCH 03/31] gnu-maintenance: Add KDE updater.

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Tue, Aug 02, 2016 at 12:02:36PM +0200, Ludovic Courtès wrote:
>> Eventually we’ll move the Xorg and KDE updaters outside of
>> gnu-maintenance, since they have little to do with GNU.
>
> Or rename the file?

No, it really contains mostly stuff related to GNU maintenance.  :-)

Ludo’.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[Ludovic Courtès]

David Craven <david@craven.ch> skribis:

>> Ups I just realized I made a mistake on this commit.
>
> What do you want me to do? not that I make things worse... This is
> what I pushed.
>
> commit d26e2b9f306a1170d46f7c860c81840d9d600161
> Author: David Craven <david@craven.ch>
> Date:   Mon Aug 1 16:39:00 2016 +0200
>
>     gnu: kde-frameworks: Remove kde-frameworks-version.
>
>     * gnu/packages/kde-frameworks (kde-frameworks-version): Delete variable.
>       (kwindowsystem)[version]: Replace kde-frameworks-version with
> version string.
>       (oxygen-icons)[version]: Replace kde-frameworks-version with
> version string.
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 74fbac2..b60d85d 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -27,8 +27,6 @@
>    #:use-module (gnu packages qt)
>    #:use-module (gnu packages xorg))
>
> -(define kde-frameworks-version "5.21.0")

[...]

> +    (version "5.24.0")

Mistake here, fixed in 7b5fc3a320eea930e6bc85a4d65c2ddbe0c9cffa.

Now we should be all right.  :-)

Ludo’.

Re: [PATCH 08/31] gnu: kde-frameworks: Remove kde-frameworks-version.

[David Craven]

> Now we should be all right.  :-)

Thank you and sorry!

Re: [PATCH 02/31] download: Add KDE mirrors.

[Leo Famulari]

On Tue, Aug 02, 2016 at 12:08:22PM +0200, David Craven wrote:
> Does the ordering of the mirrors matter?
> 
> I had them all in in the order listed on the kde website, but that
> ended up causing really slow downloads from africa... =)

Do they offer a load balancer that we can put first in the list? Usually
such a machine would take care of such things.

Re: [PATCH 02/31] download: Add KDE mirrors.

[David Craven]

> Do they offer a load balancer that we can put first in the list? Usually
> such a machine would take care of such things.

I can't find one. Guix could also pick a mirror at random to
distribute the load.

[0] http://download.kde.org/extra/mirrors.html

Re: [PATCH 02/31] download: Add KDE mirrors.

[Leo Famulari]

On Tue, Aug 02, 2016 at 05:52:40PM +0200, David Craven wrote:
> > Do they offer a load balancer that we can put first in the list? Usually
> > such a machine would take care of such things.
> 
> I can't find one. Guix could also pick a mirror at random to
> distribute the load.
> 
> [0] http://download.kde.org/extra/mirrors.html

download.kde.org itself seems to redirect the request to one of the
mirrors. Maybe it should go first in the list?

Re: [PATCH 02/31] download: Add KDE mirrors.

[David Craven]

It's not a dns load balancer I don't think. dig download.kde.org
always resolves to 195.135.221.71. I don't know how to get curl to
show me the final destination after port forwarding and http
redirects.

Not that it isn't a good idea that is. I'm just testing my
understanding of networks that's all.

Re: [PATCH 02/31] download: Add KDE mirrors.

[David Craven]

download.kde.org itself seems to redirect the request to one of the
mirrors. Maybe it should go first in the list?

Oh yes you are right!

curl http://download.kde.org/stable/frameworks/5.24/attica-5.24.0.tar.xz
        ~
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>302 Found</title>
</head><body>
<h1>Found</h1>
<p>The document has moved <a
href="http://www-ftp.lip6.fr/pub/X11/kde/stable/frameworks/5.24/attica-5.24.0.tar.xz">here</a>.</p>
<hr>
<address>Apache/2.2.22 (Debian) Server at download.kde.org Port 80</address>
</body></html>

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

As an update:
1. Thanks to your patch, all packages build!
2. extra-cmake-modules: swapping the test and install phase fixed this.
3. It's a pattern that the test failures are caused by the guix-daemon.
    Probably less surprising to the more seasoned packagers than me =)

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[Ludovic Courtès]

David Craven <david@craven.ch> skribis:

> 3. It's a pattern that the test failures are caused by the guix-daemon.
>     Probably less surprising to the more seasoned packagers than me =)

s/caused/exhibited/  ;-)

Make sure to read what follows “nothing but” at
<https://www.gnu.org/software/guix/manual/html_node/Build-Environment-Setup.html>.

Ludo’.

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

[-- Attachment #1: Type: text/plain, Size: 3277 bytes --]

So all test failures except two are resolved. I attached the wip
patches and pasted the logs below. I think this is getting to a
mergeable state =)

********* Start testing of KColumnResizerTest *********
Config: Using QtTest library 5.6.1, Qt 5.6.1
(x86_64-little_endian-lp64 shared (dynamic) release build; by GCC
4.9.3)
PASS   : KColumnResizerTest::initTestCase()
process 285: D-Bus library appears to be incorrectly set up; failed to
read machine uuid: Failed to open "/etc/machine-id": No such file or
directory
See the manual page for dbus-uuidgen to correct this issue.
QWARN  : KColumnResizerTest::test(forms) Unsupported screen format:
depth: 8, red_mask: 0, blue_mask: 0
QWARN  : KColumnResizerTest::test(forms) Unsupported screen format:
depth: 8, red_mask: 0, blue_mask: 0
libGL: OpenDriver: trying
/gnu/store/p9dwvvf9i16z6v9yawvz3z7yfy54xb5r-mesa-11.0.9/lib/dri/tls/swrast_dri.so
libGL: OpenDriver: trying
/gnu/store/p9dwvvf9i16z6v9yawvz3z7yfy54xb5r-mesa-11.0.9/lib/dri/swrast_dri.so
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/dvc/.drirc: No such file or
directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/dvc/.drirc: No such file or
directory.
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
QWARN  : KColumnResizerTest::test(forms) Could not initialize OpenGL
for RasterGLSurface, reverting to RasterSurface.
QWARN  : KColumnResizerTest::test(forms) Unsupported screen format:
depth: 8, red_mask: 0, blue_mask: 0
QWARN  : KColumnResizerTest::test(forms) QPainter::begin: Paint device
returned engine == 0, type: 3
QWARN  : KColumnResizerTest::test(forms) QPainter::setCompositionMode:
Painter not active
QWARN  : KColumnResizerTest::test(forms) QWidget::paintEngine: Should
no longer be called
QWARN  : KColumnResizerTest::test(forms) QPainter::begin: Paint device
returned engine == 0, type: 1
QWARN  : KColumnResizerTest::test(forms) QPainter::save: Painter not active

========= Received signal, dumping stack ==============
========= End of stack trace ==============
QFATAL : KColumnResizerTest::test(forms) Received signal 11
         Function time: 30ms Total time: 30ms
FAIL!  : KColumnResizerTest::test(forms) Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KColumnResizerTest *********

********* Start testing of KProcessTest *********
Config: Using QtTest library 5.6.1, Qt 5.6.1
(x86_64-little_endian-lp64 shared (dynamic) release build; by GCC
4.9.3)
PASS   : KProcessTest::initTestCase()
FAIL!  : KProcessTest::test_channels() Compared values are not the same
   Actual   (a): "mode: separate\nprogram output:\nreceived
stdout:\nreceived stderr:\n"
   Expected (e): "mode: separate\nprogram output:\nreceived
stdout:\nfoo - stdout\nreceived stderr:\nbar - stderr\n"
   Loc: [/tmp/guix-build-kcoreaddons-5.24.0.drv-0/kcoreaddons-5.24.0/autotests/kprocesstest.cpp(69)]
PASS   : KProcessTest::test_setShellCommand()
PASS   : KProcessTest::cleanupTestCase()
Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KProcessTest *********

[-- Attachment #2: 0001-gnu-kde-frameworks-Add-kwidgetsaddons.patch --]
[-- Type: text/x-patch, Size: 2732 bytes --]

From 64e2334454e6fa9e6160045b78d485458b57514d Mon Sep 17 00:00:00 2001
From: David Craven <david@craven.ch>
Date: Sun, 12 Jun 2016 20:49:12 +0200
Subject: [PATCH] gnu: kde-frameworks: Add kwidgetsaddons.

* gnu/packages/kde-frameworks.scm (kwidgetsaddons): New variable.

Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
---
 gnu/packages/kde-frameworks.scm | 43 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c10356a..c5350d6 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -734,6 +734,49 @@ are adjusted to be what a Qt developer expects - two arguments of int are
 represented by a QPoint or a QSize.")
     (license license:lgpl2.1+)))
 
+(define-public kwidgetsaddons
+  (package
+    (name "kwidgetsaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1kppx0ppfhnb6q6sijs2dffyar86wkkx8miqavsjsgw1l2wiymcx"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)
+       ("xorg-server" ,xorg-server)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments ; FIXME libGL error: failed to load driver: swrast
+     `(#:phases
+        (modify-phases %standard-phases
+          (add-before 'check 'check-setup
+            (lambda* _
+              (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; enable debug output
+              (setenv "LIBGL_DEBUG" "verbose") ; enable debug output
+              (setenv "DBUS_FATAL_WARNINGS" "0")))
+          (add-before 'check 'start-xorg-server
+            (lambda* (#:key inputs #:allow-other-keys)
+              ;; The test suite requires a running X server.
+              (system (string-append (assoc-ref inputs "xorg-server")
+                                     "/bin/Xvfb :1 &"))
+              (setenv "DISPLAY" ":1")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Large set of desktop widgets")
+    (description "Provided are action classes that can be added to toolbars or
+menus, a wide range of widgets for selecting characters, fonts, colors, actions,
+dates and times, or MIME types, as well as platform-aware dialogs for
+configuration pages, message boxes, and password requests.")
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
   (package
     (name "kwindowsystem")
-- 
2.9.0


[-- Attachment #3: 0001-gnu-kde-frameworks-Add-kcoreaddons.patch --]
[-- Type: text/x-patch, Size: 2586 bytes --]

From f00ac9336c2c8c47a14a647c3f22ed09064a04aa Mon Sep 17 00:00:00 2001
From: David Craven <david@craven.ch>
Date: Sun, 12 Jun 2016 20:39:34 +0200
Subject: [PATCH] gnu: kde-frameworks: Add kcoreaddons.

* gnu/packages/kde-frameworks.scm (kcoreaddons): New variable.

Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
---
 gnu/packages/kde-frameworks.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d6a7636..540610f 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -349,6 +349,46 @@ propagate their changes to their respective configuration files.")
                    license:lgpl3+ license:gpl1 ; licende:mit-olif
                    license:bsd-2 license:bsd-3))))
 
+(define-public kcoreaddons
+  (package
+    (name "kcoreaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "06sx7by3nvaridnavj5p0bxv4nh47n708jlacfw8ydaikmd9i03h"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)
+       ("xorg-server" ,xorg-server))) ; for the tests
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+        (modify-phases %standard-phases
+          (add-before 'check 'check-setup
+            (lambda* _
+              (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; enable debug output
+              (setenv "HOME" (getcwd))
+              (setenv "TMPDIR" (getcwd)))))))
+    ; FIXME test failure because stout/stderr are piped to the same file
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Qt addon library with a collection of non-GUI utilities")
+    (description "KCoreAddons provides classes built on top of QtCore to
+perform various tasks such as manipulating mime types, autosaving files,
+creating backup files, generating random sequences, performing text
+manipulations such as macro replacement, accessing user information and
+many more.")
+    ;; Some source files mention lgpl2.0+, but the included license is
+    ;; the lgpl2.1. Some source files are under non-copyleft licenses.
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
   (package
     (name "kwindowsystem")
-- 
2.9.0

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

Andreas, did you merge the qt-base patch yet?

After I do some license auditing, is it ok to merge kde framework
tier1? Or do you prefer me to dump the patches on the mailinglist
again? =)

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[Andreas Enge]

On Fri, Aug 05, 2016 at 04:36:01PM +0200, David Craven wrote:
> Andreas, did you merge the qt-base patch yet?

Yes, commits 7972d8a2e98af6592050a37036c2c80a01358fcf
(and cce28b0c3ad14c42e08500bb51b23ba02ed449a2 and
2470d779c9105c7ac7d03bd27bd53da0548384c4).

> After I do some license auditing, is it ok to merge kde framework
> tier1? Or do you prefer me to dump the patches on the mailinglist
> again? =)

Merge no, we commit :-) Maybe you could send them to the list. However,
I am leaving for vacation without e-mail until the GNU Hackers Meeting,
so if nobody reviews them after a few days, you can push them to master.
These are new packages anyway, so no user will be harmed in the process.

Thanks for your work!

Andreas

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[Andreas Enge]

PS: Okay to update the existing packages to the latest version, of course.

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[Andreas Enge]

On Wed, Aug 03, 2016 at 04:08:37PM +0200, David Craven wrote:
> So all test failures except two are resolved.
> I think this is getting to a mergeable state

This sounds like a contradiction to me...
Or do you mean, test failures in only two packages, and the
other ones are fine?

Andreas

Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven]

> Or do you mean, test failures in only two packages, and the
> other ones are fine?

Yep that's what I meant. It mainly required setting env variables
and adding a xorgserver-start, dbus-launch phase to some packages
like has been done before. Sorry if it was unclear.