From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 22/22] gnu: Add roary. Date: Fri, 29 Jul 2016 17:07:46 -0400 Message-ID: <20160729210746.GA16455@jasmine> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTF0j-0000rg-7A for guix-devel@gnu.org; Fri, 29 Jul 2016 17:08:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTF0e-00072P-VL for guix-devel@gnu.org; Fri, 29 Jul 2016 17:08:00 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:33859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTF0d-00071m-LD for guix-devel@gnu.org; Fri, 29 Jul 2016 17:07:56 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org On Wed, Jul 27, 2016 at 10:54:23PM +1000, Ben Woodcroft wrote: > * gnu/packages/bioinformatics.scm (roary): New variable. Wow, this is a complicated package! Thanks for doing the work! > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'delete-bundled-binaries > + (lambda _ > + (delete-file-recursively "binaries") > + #t)) The only thing I would suggest you change is to delete these binaries in an origin snippet. The effect would be that the binaries would not be provided by `guix build --source roary`. If the binaries aren't provided with their source code, then I think this change is required.