From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add perl-db_file. Date: Tue, 26 Jul 2016 22:48:37 +0200 Message-ID: <20160726204837.GA14094@solar> References: <20160726173513.572a6d5d@scratchpost.org> <20160726183531.GA11804@solar> <20160726210138.6b90aef7@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS9HT-00072Z-Lo for guix-devel@gnu.org; Tue, 26 Jul 2016 16:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS9HP-00047R-Oe for guix-devel@gnu.org; Tue, 26 Jul 2016 16:48:47 -0400 Received: from mailrelay6.public.one.com ([91.198.169.200]:45473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS9HP-000470-6q for guix-devel@gnu.org; Tue, 26 Jul 2016 16:48:43 -0400 Content-Disposition: inline In-Reply-To: <20160726210138.6b90aef7@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org, Danny Milosavljevic Hello, On Tue, Jul 26, 2016 at 09:01:38PM +0200, Danny Milosavljevic wrote: > Yeah, I thought about it but decided against it - there are very few options in that file, substitute* can't substitute entire lines (or only at the beginning of the line) or entire words (so it's not safe), the user is supposed to set PREFIX and HASH (it's just a coincidence we didn't have to change them) and if we did that then new versions of the package could sneak in new options we wouldn't notice but we should have changed. Better for it to fail instead of silently doing something strange. well, substitute* is closer to a diff - it makes it easy to see what actually changes. And I would make the converse argument of you - for the next version, if more things change (an option is added to the file, for instance), then the substitute* still has a chance to get a working package. Imagine that someone without knowledge of the package might be the one to update it, for instance. I pushed with tiny changes to the description. Thanks! Andreas