From: Leo Famulari <leo@famulari.name>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add perceptualdiff.
Date: Sun, 24 Jul 2016 17:44:38 -0400 [thread overview]
Message-ID: <20160724214438.GA2122@jasmine> (raw)
In-Reply-To: <20160724034325.16952-1-me@tobias.gr>
On Sun, Jul 24, 2016 at 05:43:25AM +0200, Tobias Geerinckx-Rice wrote:
> * gnu/packages/image.scm (perceptualdiff): New variable.
LGTM
> + (arguments
> + '(#:phases (modify-phases %standard-phases
> + (add-after 'unpack 'fix-tests
> + ;; cmake-build-system uses a build/ directory outside
> + ;; of the source tree, one level higher than expected
> + (lambda _
> + (substitute* "test/run_tests.bash"
> + (("../build") "../../build")))))))
Do you think this is a bug that should be reported?
next prev parent reply other threads:[~2016-07-24 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 3:43 [PATCH] gnu: Add perceptualdiff Tobias Geerinckx-Rice
2016-07-24 21:32 ` Ludovic Courtès
2016-07-24 21:44 ` Leo Famulari [this message]
2016-07-24 21:56 ` Tobias Geerinckx-Rice
2016-07-24 22:21 ` Leo Famulari
2016-07-25 10:49 ` Vincent Legoll
2016-07-25 15:10 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160724214438.GA2122@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).