From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 5/7] gnu: Add spice.
Date: Sat, 23 Jul 2016 18:40:08 -0400
Message-ID: <20160723224008.GE26113@jasmine>
References: <20160723131859.13525-1-david@craven.ch>
	<20160723131859.13525-5-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR5ak-0005M9-B4
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:40:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR5ai-0008Ld-G1
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:40:17 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR5ai-0008KZ-9c
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:40:16 -0400
Content-Disposition: inline
In-Reply-To: <20160723131859.13525-5-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Jul 23, 2016 at 03:18:57PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.

> +(define-public spice

> +    (propagated-inputs
> +      `(("openssl" ,openssl)
> +        ("pixman" ,pixman)
> +        ("spice-protocol" ,spice-protocol)))

Same questions as with the previous patch. Do these need to be
propagated?

> +    (inputs
> +      `(("glib" ,glib)
> +        ("libjpeg" ,libjpeg)
> +        ("lz4" ,lz4)
> +        ("opus" ,opus)
> +        ("python" ,python)
> +        ("spice-gtk" ,spice-gtk)
> +        ("zlib" ,zlib)))

The built package is missing references to python and spice-gtk. Do you
think that's a problem? Are they needed?

> +      `(#:configure-flags
> +        '("--disable-celt051" 

Would a comment like "Disable support for unpackaged audio codec"
explain this flag?

> +    (license license:gpl2)))

Released under lgpl2.1+ with a few lgpl2.0+ files.