From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check. Date: Thu, 21 Jul 2016 08:17:10 -0500 Message-ID: <20160721081710.41c69c50@openmailbox.org> References: <20160719164916.6597-1-david@craven.ch> <20160719164916.6597-4-david@craven.ch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/n4fQXK3kF0vpPCOUXVrcGqF"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDqw-0007yW-Hg for guix-devel@gnu.org; Thu, 21 Jul 2016 09:17:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQDqs-0004zm-8b for guix-devel@gnu.org; Thu, 21 Jul 2016 09:17:25 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:33034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQDqr-0004zf-Ur for guix-devel@gnu.org; Thu, 21 Jul 2016 09:17:22 -0400 In-Reply-To: <20160719164916.6597-4-david@craven.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel@gnu.org --Sig_/n4fQXK3kF0vpPCOUXVrcGqF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 19 Jul 2016 18:49:15 +0200 David Craven wrote: > * guix/scripts/lint.scm (check-inputs-should-be-sorted): Add it. > (lint-checker): Add it. > --- > guix/scripts/lint.scm | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm > index d64a066..d3a82c9 100644 > --- a/guix/scripts/lint.scm > +++ b/guix/scripts/lint.scm > @@ -220,6 +220,21 @@ by two spaces; possible infraction~p at ~{~a~^, ~}") > (when (string-suffix? ":bin" package-name) (warn package-n= ame))) > labels))))))) > =20 > +(define (check-inputs-should-be-sorted package) > + ;; Emit a warning if inputs, native-inputs or propagated-inputs are no= t sorted. I don't think this needs to be a thing. While I personally added the code in the cpan importer to sort inputs by name, I recognize that there are also valid reasons to not do that in some packages. E.g. grouping a set of inputs that are all related to or required for some aspect of a package's functionality, etc. `~Eric --Sig_/n4fQXK3kF0vpPCOUXVrcGqF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJXkMtWAAoJEB670gR4H5YsTZ4H/jTL8ED/btukP5fyCs0PXySt aHxEh57umDLDX2wuLH4/IoIte6XICQZfnKwR6F6/oo7vpj9chb8MO/FftIQVF03f n9RKQQZF8fNDrUSfRGCDlznhyi/wfilhPT6qgPW50C3FKy3oUzCycX8ma6H4HZLc uL0ZFMA3t4SnxYP4kMynAhKUpA4RATucaexHbH7R1n72QBQIXoEaPLPVo6A/SHA5 5GJyquEAE+xow0DWVfDH+yo4vKPim3v9QxxKq7Uu3NgQ1PENyECiqb6SquTBuovR 70NNs8xWF9LzisUaZmdwzsLPy36ZiHQjLDYlWgqXmKQKQqDGLQPcYUWkNSjiJzw= =adXY -----END PGP SIGNATURE----- --Sig_/n4fQXK3kF0vpPCOUXVrcGqF--