From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: Obs on non-x86 Date: Tue, 12 Jul 2016 13:17:49 +0300 Message-ID: <20160712101749.GB4575@debian-netbook> References: <20160712070019.GA4828@solar> <20160712080627.GA4575@debian-netbook> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CUfgB8w4ZwR/yMy5" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMulQ-0007yM-0J for guix-devel@gnu.org; Tue, 12 Jul 2016 06:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMulL-0000AQ-Qt for guix-devel@gnu.org; Tue, 12 Jul 2016 06:18:02 -0400 Received: from flashner.co.il ([178.62.234.194]:42952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMulL-00009W-Jx for guix-devel@gnu.org; Tue, 12 Jul 2016 06:17:59 -0400 Content-Disposition: inline In-Reply-To: <20160712080627.GA4575@debian-netbook> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Andreas Enge Cc: guix-devel@gnu.org --CUfgB8w4ZwR/yMy5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 12, 2016 at 11:06:27AM +0300, Efraim Flashner wrote: > On Tue, Jul 12, 2016 at 09:00:19AM +0200, Andreas Enge wrote: > > Hello, > >=20 > > the obs package fails to build on arm: > > http://hydra.gnu.org:3000/build/1298768/nixlog/1/tail-reload > > since it uses "-msse" and so on. > >=20 > > Can this be disabled on non-x86 architectures, or should we mark it > > as non available there? > >=20 > > Andreas >=20 > I grepped the source and found the offending code here: > https://github.com/jp9000/obs-studio/blob/master/libobs/CMakeLists.txt#L3= 50 >=20 > A quick fix would be to change `IF(NOT MSVC)' to `IF(MSVC)' and (without > checking) that would likely get the old functionality back, but I bet > there's somewhere else we can change it. >=20 > Looking at git blame that code has been there for almost 2 years, so it > looks like something else changed that caused them to either change the > default config or finally read and process the flags. >=20 I found debian's obs patch for this issue https://sources.debian.net/src/obs-studio/0.14.2%2Bdfsg1-3/debian/patches/0= 002-Buildsystem.patch/ so it looks like I'm on the right path. I don't have easy access to non-Intel hardware to test my patch, so I'll at least test that it doesn't break x86_64. My goal to keep failed builds under 600 went out the window when I switched a bunch of packages to modular Qt, but I bet there's a number of similar issues out there for failed builds among armhf and mips. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --CUfgB8w4ZwR/yMy5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXhMPJAAoJEPTB05F+rO6Tv7QP/3qZUYvisSPdkMc7OCq5iUzx xe03BuVeeJmOlC69XujEfYpDb+J6z1UqKy8RONbYtwUM19FHRnxctv0Iq+6CskF+ 3bctRb46NwCUUhIpLHmiVCukH7j0hEfCidqULM/LmBceLrrYXUR//G58+FpypKxo edOrWdx9l7HkkL9f+3NB9WdTi0YsZNjobhgsPgYh0sxWNiGyUVLF4eV2/b8OI9UH 2dl6HIxS5Vkm0cATXZmsDs9XK8PZ7rv+eP3UD1+Xwit81VDmPTpTEsGtDQm9pinO 0VM1AdQ7MBIG3LJ/6MOE8PZHUxzb5HR2bixa+rO6Z7cL6XfceSfXOvNCzdRhK/9C uc6DAS63k3I2GCBtiz8Gtu5s/wRssa3tJqcPYVtFI3PP47ZkIPgCY+9R28PtJBXT B40qmZ2GmX9gHdWOCEnqSy5UznGFI5ytNfghT9sFHptRpc36N8k/d+5XPrs673S2 QT5SEft5z7nUcTY27grcuKAf4+kfjv2+b+Akz++471x+u6UPL3twjcrlF7TfmQGd X4ZpPaZYtCrxVly0eLZ8x4CuJsESRNZRQMYnepy5PUp9TVKxOZ+wYif8EMoezD8u 7l7IpMtg/XHa6VZhNYxB/E+sPM4FTROTyinubkzaAeJ8wv8LYcf9vy+G5ivQfjZe eYcfDC1pxO0Pafn6JplM =u7BR -----END PGP SIGNATURE----- --CUfgB8w4ZwR/yMy5--