From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] add go@1.5 Date: Mon, 11 Jul 2016 23:17:53 -0400 Message-ID: <20160712031753.GA2237@jasmine> References: <87k2gtyrtj.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMoD2-0000cW-Q2 for guix-devel@gnu.org; Mon, 11 Jul 2016 23:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMoCy-0001X1-JC for guix-devel@gnu.org; Mon, 11 Jul 2016 23:18:07 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMoCx-0001Vn-75 for guix-devel@gnu.org; Mon, 11 Jul 2016 23:18:04 -0400 Content-Disposition: inline In-Reply-To: <87k2gtyrtj.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Matthew Jordan Cc: guix-devel On Sun, Jul 10, 2016 at 07:52:08PM -0400, Matthew Jordan wrote: > * gnu/packages/golang.scm (go-1.5): New variable. I don't have the knowledge to comment on the Go specific stuff in this package, but I have some more general comments. The tests 'runtime' and 'cmd/go' failed due to the default 3 minute time-limit when building on my slow machine, this thing: They passed in 193 and 216 seconds, respectively, when I set the environment variable GO_TEST_TIMEOUT_SCALE to 9999, as suggested in this bug report: I've used the system-on-a-chip (SOC) mentioned in that bug report (Allwinner A20), and my slow computer is faster than it. Since we support ARMv7 and the A20 is a very popular ARMv7 SOC, I think we should set this variable in the package definition. > +(define-public go-1.5 > + (package > + (inherit go-1.4) We should try to inherit as much as possible from go-1.4, and when we can't, we should at least try to use the same style (indentation, etc), so that it's clear to readers what is different. Can anyone say if it's possible to inherit specific build phases that are common between the two packages? > + (name "go") I believe the name should be inherited, so this can be removed. > + (add-before 'build 'prebuild If it is possible to inherit some phases and as mentioned above, maybe this phase could be split into parts that are common between go-1.4 and go-1.5 and parts that are different.